From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A1B361F55B for ; Thu, 28 May 2020 12:31:26 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D99A53840C3B; Thu, 28 May 2020 12:31:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D99A53840C3B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1590669085; bh=cb1dG9Z74XrXxGuftSXiyxOPdw6oYH8+NlDt0Yyiv48=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=qeeQ26cvhtTwxRU7y7HtU3zaZPbmUPN5OUCd8QvJubqoInmCBG0Hv5KnIE2pVz7AS BKGhB3tzeTb+mBi4pYspn0GgOTlcaozfL2vKdI7xE4gzhQ3YXc5ejfbMjZ4YSSFHYS YK4Ql+j5+MgGbEx+jbT1kezTS5d1WYwkVv/9UIQU= Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 33EA7386F831 for ; Thu, 28 May 2020 12:31:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 33EA7386F831 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-99-vPydMb4_O9qoK057YolvwQ-1; Thu, 28 May 2020 08:31:20 -0400 X-MC-Unique: vPydMb4_O9qoK057YolvwQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24566835B76; Thu, 28 May 2020 12:31:19 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-91.ams2.redhat.com [10.36.112.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6F360A09AD; Thu, 28 May 2020 12:31:18 +0000 (UTC) To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 12/13] string: Add sigabbrev_np and sigdescr_np References: <20200519180518.318733-1-adhemerval.zanella@linaro.org> <20200519180518.318733-13-adhemerval.zanella@linaro.org> Date: Thu, 28 May 2020 14:31:16 +0200 In-Reply-To: <20200519180518.318733-13-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 19 May 2020 15:05:17 -0300") Message-ID: <871rn4ckbv.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella via Libc-alpha: > The sigabbrev_np returns the abbreviated signal name (i.g. "HUP" for > SIGHUP) while sigdescr_np returns string describing error number > (i.g "Hangup" for SIGHUP). Different than strsignal, sigdescr_np > does not attempt to translate the return description and both > functions return NULL for an invalid signal number. > > They should be used instead of sys_siglist or sys_sigabbrev and they > are both thread and async-signal safe. They are added as GNU > extensions on string.h header (same as strsignal). > > Checked on x86-64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu, > and s390x-linux-gnu. Most of my comments on the errno version of this patch apply here as well. If the non-localized names are useful, should we add strsignal_l to capture that? Thanks, Florian