From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: libc-alpha@sourceware.org, Sunil K Pandey <skpgkp2@gmail.com>
Subject: Re: [PATCH] Revert "x86_64: Suppress false positive valgrind error"
Date: Sat, 13 Apr 2024 17:20:20 +0200 [thread overview]
Message-ID: <871q792ssr.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOrt2vBdnVT=x7Nzm10gBasTeOog1GDW8mp0x-_dt41NyQ@mail.gmail.com> (H. J. Lu's message of "Sat, 13 Apr 2024 08:09:04 -0700")
* H. J. Lu:
> On Sat, Apr 13, 2024 at 8:03 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * H. J. Lu:
>>
>> > On Sat, Apr 13, 2024 at 7:49 AM Florian Weimer <fweimer@redhat.com> wrote:
>> >>
>> >> This reverts commit a1735e0aa858f0c8b15e5ee9975bff4279423680.
>> >>
>> >> The test failure is a real valgrind bug that needs to be fixed before
>> >> valgrind is usable with a glibc that has been built with
>> >> CC="gcc -march=x86-64-v3". The valgrind fix addresses the observed
>> >> test failure as well.
>> >>
>> >> Upstream bug: <https://bugs.kde.org/show_bug.cgi?id=485487>
>> >>
>> >> Tested on x86_64-linux-gnu with and without CC="gcc -march=x86-64-v3".
>> >> The elf/tst-valgrind-smoke tests again fails with an unpatched valgrind,
>> >> and the proposed upstream patch fixes it. (Apparently, valgrind
>> >> matches on soname, and not the file name, which is ld.so in the test.)
>> >
>> > Please clarify that your patch fixes the glibc valgrind test by not using
>> > strcmp-avx2.S in the valgrind test.
>>
>> Sorry, clarify where? In the commit message here? On the upstream bug?
>
> In the glibc commit message.
>
>> My valgrind patch replaces the strcmp implementation in ld.so with its
>> own.
>>
>
> Please mention it in the glibc commit message.
Okay, I'll send a v2.
Could someone proficient in x86-64 assembly have a look at my strcmp
implementation?
<https://bugsfiles.kde.org/attachment.cgi?id=168460>
It seems to work, but …
Thanks,
Florian
next prev parent reply other threads:[~2024-04-13 15:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 14:48 [PATCH] Revert "x86_64: Suppress false positive valgrind error" Florian Weimer
2024-04-13 14:58 ` H.J. Lu
2024-04-13 15:03 ` Florian Weimer
2024-04-13 15:09 ` H.J. Lu
2024-04-13 15:20 ` Florian Weimer [this message]
2024-04-13 15:27 ` H.J. Lu
2024-04-13 15:49 ` H.J. Lu
2024-04-13 15:52 ` Florian Weimer
2024-04-13 15:56 ` H.J. Lu
2024-04-13 17:50 ` Florian Weimer
-- strict thread matches above, loose matches on Subject: below --
2024-04-13 15:21 Florian Weimer
2024-04-13 15:27 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q792ssr.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).