From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Carlos O'Donell Newsgroups: gmane.comp.lib.glibc.alpha Subject: Re: [PATCH 0/2] nptl: Update struct pthread_unwind_buf Date: Wed, 7 Mar 2018 09:34:47 -0800 Message-ID: <86d5d5ba-2b53-1904-dada-3efe2b3ad501@redhat.com> References: <20180201205757.51911-1-hjl.tools@gmail.com> <87a7vyjsqv.fsf@mid.deneb.enyo.de> <87vaelbetu.fsf@mid.deneb.enyo.de> <87fu5pb7ql.fsf@mid.deneb.enyo.de> <877er1b4zp.fsf@mid.deneb.enyo.de> <87371pb3ga.fsf@mid.deneb.enyo.de> <87tvu59o21.fsf@mid.deneb.enyo.de> <87po4t9mxt.fsf@mid.deneb.enyo.de> <3764b0a1-9f26-6f5f-1bc5-d374f2672f3a@redhat.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1520443979 6847 195.159.176.226 (7 Mar 2018 17:32:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 7 Mar 2018 17:32:59 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Cc: Florian Weimer , GNU C Library To: "H.J. Lu" Original-X-From: libc-alpha-return-90875-glibc-alpha=m.gmane.org@sourceware.org Wed Mar 07 18:32:55 2018 Return-path: Envelope-to: glibc-alpha@blaine.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=Z4jK/9CcqzD/8FTi SlnxVe3li3svb5ARuBIuTLOd6ktICLIpXQlBDSzy4S+xn8AEXSuUDDx14PMnu2sz AZB9G6ljQytp4L49uEfQcVYw3jcS9amc6E6AZin5qo+GVNWHTwd1DMpBRuusj512 04+3OahMKRsbsbE4Q4DW/6MpBxQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=MG7b0gxa8GddWmy78L5HUh Ww1bQ=; b=TcAbP8vhOMu53K9fkd2gCh4zT5tSQnyfkWUmV0hexa1dgsvuZKtfZ0 bg6Za76HdQdq17p8bp4e0KHMnojDSvFRJ+auz+xXciGz196ZZDbnhLkX+zAGveuF K2ziL4cpGk8w1NnTwQVI7JJkWc/kTb58VusQThAI0F2WLAp/6cURs= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f178.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=bVhnnjhtVXs4x0Ay9WAFHZHqLDAIVS3I+nDQ9sCakv8=; b=M3gduMKttprAPnVm9ssC/Gfp7/Qy0wOLva9nLKcJFV4aT2Mr4HWXTZWX9uJleLOqmz ii1KTgnCTmjuiWtGO7/jKuI37j2CxEIiGXzrb41VnzgMnf/UknVHHUuEyM6NgmS8ZBch q0Eznoxpwzf7DaHXqST99lD4ozviaxGlwKYiyWSf+awhuC+NyQuaxK0zOPUkAnB3LDRW quwwfXiT4EGOAmlKkh+0lp4P8ktYeSVzs0ZAPnjjXWiK3TltwUxOE/WQrcV5bcXbfOZg /nNX/yD39r0qiWqILKkb+42Oj8l/jgDCk+XmYMT5Jxbkd2R5NRFrdFHbXwwmja/2oT8q SyaA== X-Gm-Message-State: AElRT7HT2bo8yg10GUqTJ/9grbs+GU71x/bT9H4sVMbqYY7r76IZMZRh 4e9A+4vXgqkiI7lq4PxSQA/e3olP+58= X-Google-Smtp-Source: AG47ELu/+9T+hqzWAuUWV+5gRdNp3URP9mlc9+8i1tJXZ7j/U017GsPcKpItfxsucMRMWSMQ5AmTsQ== X-Received: by 10.55.217.220 with SMTP id q89mr35093504qkl.64.1520444090461; Wed, 07 Mar 2018 09:34:50 -0800 (PST) In-Reply-To: Xref: news.gmane.org gmane.comp.lib.glibc.alpha:83206 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etcvr-0000lr-AV for glibc-alpha@blaine.gmane.org; Wed, 07 Mar 2018 18:32:51 +0100 Received: (qmail 47512 invoked by alias); 7 Mar 2018 17:34:54 -0000 Received: (qmail 47501 invoked by uid 89); 7 Mar 2018 17:34:53 -0000 On 03/07/2018 03:56 AM, H.J. Lu wrote: >>> 1. I have to add __setjmp_cancel and __sigsetjmp_cancel which won't >>> save and restore shadow stack register. > > I have been testing this. I ran into one issue. GCC knows that setjmp will > return via longjmp and inserts ENDBR after it. But it doesn't know > __setjmp_cancel and __sigsetjmp_cancel. We can either add them to GCC > or add NOTRACK prefix to the corresponding longjmps. I would rather GCC did not know about these implementation details. I have no objection to the NOTRACK prefix in the corresponding longjmps. What would be a downside to this choice? -- Cheers, Carlos.