From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 615FD1F4BD for ; Tue, 8 Oct 2019 06:22:41 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:reply-to:subject:from:to:references:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=LFHvzh8xjjz+VlgH 0Fg43NI1PSavvSi3DsxPzCTNa+U03htYi3in6u8H9jLydFPQCVTcAHWzv/edAVCt XVnTCNpnTEyyN0Mn5ceLLmiGT6c6Lc9AdaG3pAhrlMw8qdZ+BCyTwGiK4cBePq82 Hcq1uy9Mczldb4ak1AwghLLk1iA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:reply-to:subject:from:to:references:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=etgUdkmf5gK/g42EZynTi/ 6BtV0=; b=RrICk3rk33/oE7NdTU4IV4R9/gIva+6vNb3aas4JPQWIxcmMxxXjS8 om/Oo9n6zNJr2aWYgrLLbg6YuxAIBmqkmhHphzwsZhKs54Cb5efVpouag7d1e6n8 uQ6nNbtf/mCZROzTwNF1zFVQiubmvZfXBJkKtaw4jtr2P4iNXv2rg= Received: (qmail 45237 invoked by alias); 8 Oct 2019 06:22:39 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 45229 invoked by uid 89); 8 Oct 2019 06:22:39 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: esa4.mentor.iphmx.com IronPort-SDR: rYExDQWkiYAzEFZlCs/HyLUJY05IeeGoziVaETvILmhq2fdKVVKYEKoNPNDaAi63GolZT8JHNB mg3QAkcIBO2wngNYeCuSKLHPBFymLY5lb+8vjSRufWAueCyBIjR+fEurkV1fS6oezjaSlq1HsB yCpqI+00Lkp9F7LPbjbvuZQNvniDeMafUd2sODX20OHc4lWaK1E2/BlpDPBuKMi8Xc6ehCkq/d IWjFl6bU7q7ZlJ/mOLFx9SYhDWrlc+vpM0Wc+Ewji7QaL7dyr33GlRx2DNSvHavHwPbS2MGljd J1E= IronPort-SDR: ECOLHLSkgb2jZMrgRa+VxzAhlpxxux2Oe0aOuNh2eBqm/R/BLv6JZmPNYa20pXKLWrMNS08DAF hZkhlTdZA4MnyzUJ8umXy9QYuEoT2tHzfRElGMkJdadavKEdfTMHkXvhRg/euBKCdiEUcXBER0 euMO6uWcIC6oRjV5CUGfK2InCIFVjqmeoty0RglEEtjH+RZiqKrqcbBbRVzCvEZ1GRKVX2Fjgw e8W+OtRwNSCJK0CXLY7l3u+TUZAAigqrXN4QV789NkOUca+2YbnBXfXqogPQXXxjW9Sjl2DI1B LH0= Reply-To: Subject: Ping x2 Re: [PATCH 1/2][RFC] #17645, fix slow DSO sorting behavior in dynamic loader From: Chung-Lin Tang To: GNU C Library References: <2dea2558-c711-eab5-3728-be4986b7aad5@mentor.com> Message-ID: <8588322f-6391-7d6a-6b2e-f2cc05419622@mentor.com> Date: Tue, 8 Oct 2019 14:22:27 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <2dea2558-c711-eab5-3728-be4986b7aad5@mentor.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Ping again. On 2019/9/17 5:55 PM, Chung-Lin Tang wrote: > Ping? > > On 2019/7/21 1:50 AM, Chung-Lin Tang wrote: >> Hi, this patch is our attempt at resolving the slow shared object sorting >> situation in #17645, #15310, and some effort at #15311.  I realize this is >> pretty unsuitable timing to be submitting a patch of such nature now (probably >> way too late to be included into 2.30), but still sending now anyways as this >> will probably need quite some discussion before being approved. >> >> Prior attempts at solving this slow sorting behavior appeared to have failed >> due to inadequate proposed testing, therefore cannot convince reviewers to >> touch what seems to be perceived as a sensitive and easy to break part of ld.so. >> >> Therefore the first part of this patch is not a change to the dynamic loader >> code proper, but a testing framework for constructing DSO sorting tests. >> It consists of a new Python script 'dso-ordering-test.py' that serves to >> generate both testcase source files and the needed Makefile fragments from >> a short description string, for example: >> >>      a->b->c->d          // four objects linked one after another >> >>      a->[bc]->d;b->c     // a depends on b and c, which both depend on d, >>                          // b depends on c (b,c linked to object a in fixed order) >> >>      a->b->c;{+a;%a;-a}  // a, b, c serially dependent, main program uses >>                          // dlopen/dlsym/dlclose on object a >> >>      a->b->c;{}!->[abc]  // a, b, c serially dependent; multiple tests generated >>                          // to test all permutations of a, b, c ordering linked >>                          // to main program >> >>     (Above is just a short description of what the script can do, more >>      documentation is in the script comments.) >> >> and, a patch to glibc/elf/Makefile which uses this script to add a few >> DSO sorting testcases.  The description string notation and output form of the >> generated testcases is short enough that both the test descriptions >> and expected outcomes can all directly be specified in the Makefile. >> >> In terms of the tests I added using this script, I am not completely sure they are >> (together with existing tests) adequate to prove algorithmic integrity in face >> of any ld.so code changes, but the script should provide a solid tool to further >> improve on coverage.  Also welcome suggestions if the current features are still >> lacking in expressing some case of shared object relations, or if the documentation >> still feels unclear. >> >> Thanks, >> Chung-Lin >> >> 2019-07-20  Chung-Lin Tang  >> >>          [BZ #17645] >>          [BZ #15311] >>          [BZ #15310] >>          * elf/Makefile (test_dso_ordering): New make function. >>          (tst-dso-ordering[123456789]): Define new DSO sorting tests. >>          (tst-bz15311): Testcase from #15311. >>          * scripts/dso-ordering-test.py: New script.