From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: [PATCH v2 1/4] CVE-2024-33599: nscd: Stack-based buffer overflow in netgroup cache (bug 31677)
Date: Wed, 24 Apr 2024 22:54:27 +0200 [thread overview]
Message-ID: <856155216699813fd1e533665adc1669abbcfc8b.1713991707.git.fweimer@redhat.com> (raw)
Using alloca matches what other caches do. The request length is
bounded by MAXKEYLEN.
---
v2: Added the comment Sid requested. CVE assignment.
nscd/netgroupcache.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/nscd/netgroupcache.c b/nscd/netgroupcache.c
index 0c6e46f15c..f227dc7fa2 100644
--- a/nscd/netgroupcache.c
+++ b/nscd/netgroupcache.c
@@ -502,12 +502,13 @@ addinnetgrX (struct database_dyn *db, int fd, request_header *req,
= (struct indataset *) mempool_alloc (db,
sizeof (*dataset) + req->key_len,
1);
- struct indataset dataset_mem;
bool cacheable = true;
if (__glibc_unlikely (dataset == NULL))
{
cacheable = false;
- dataset = &dataset_mem;
+ /* The alloca is safe because nscd_run_worker verfies that
+ key_len is not larger than MAXKEYLEN. */
+ dataset = alloca (sizeof (*dataset) + req->key_len);
}
datahead_init_pos (&dataset->head, sizeof (*dataset) + req->key_len,
base-commit: f4724843ada64a51d66f65d3199fe431f9d4c254
--
2.44.0
next reply other threads:[~2024-04-24 20:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 20:54 Florian Weimer [this message]
2024-04-24 20:54 ` [PATCH v2 2/4] CVE-2024-33600: nscd: Do not send missing not-found response in addgetnetgrentX (bug 31678) Florian Weimer
2024-04-24 20:54 ` [PATCH v2 3/4] CVE-2024-33600: nscd: Avoid null pointer crashes after notfound response " Florian Weimer
2024-04-24 20:54 ` [PATCH v2 4/4] CVE-2024-33601, CVE-2024-33602: nscd: netgroup: Use two buffers in addgetnetgrentX (bug 31680) Florian Weimer
2024-04-25 11:25 ` [PATCH v2 1/4] CVE-2024-33599: nscd: Stack-based buffer overflow in netgroup cache (bug 31677) Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=856155216699813fd1e533665adc1669abbcfc8b.1713991707.git.fweimer@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).