unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Alistair Francis <alistair.francis@wdc.com>
To: libc-alpha@sourceware.org
Cc: arnd@arndb.de, adhemerval.zanella@linaro.org, fweimer@redhat.com,
	joseph@codesourcery.com, palmerdabbelt@google.com, macro@wdc.com,
	zongbox@gmail.com, alistair.francis@wdc.com,
	alistair23@gmail.com
Subject: [RFC v6 03/23] time: Add a timeval with a long tv_sec and tv_usec
Date: Sun, 12 Jan 2020 02:33:38 -0800	[thread overview]
Message-ID: <85291ec316dcd3f3a3155488a8c290298650dc77.1578824547.git.alistair.francis@wdc.com> (raw)
In-Reply-To: <cover.1578824547.git.alistair.francis@wdc.com>

On y2038 safe 32-bit systems the Linux kernel expects itimerval to
use a 32-bit time_t, even though the other time_t's are 64-bit. To
address this let's add a timeval_long struct to be used internally.
---
 include/time.h                   | 29 +++++++++++++++++++++++++++++
 time/bits/types/struct_timeval.h |  8 ++++++++
 2 files changed, 37 insertions(+)

diff --git a/include/time.h b/include/time.h
index e5e8246eac..201342d1ca 100644
--- a/include/time.h
+++ b/include/time.h
@@ -310,6 +310,35 @@ valid_timespec64_to_timeval (const struct __timespec64 ts64)
   return tv;
 }
 
+/* Conversion functions for converting to/from __timeval_long
+.  If the seconds field of a __timeval_long would
+   overflow, they write { INT32_MAX, 999999 } to the output.  */
+static inline struct timeval
+valid_timeval_long_to_timeval64 (const struct __timeval_long tv)
+{
+  return (struct timeval) { tv.tv_sec, tv.tv_usec };
+}
+
+static inline struct __timeval_long
+valid_timeval64_to_timeval_long (const struct timeval tv64)
+{
+  if (__glibc_unlikely (tv64.tv_sec > (time_t) 2147483647))
+    return (struct __timeval_long) { 2147483647, 999999};
+  return (struct __timeval_long) { tv64.tv_sec, tv64.tv_usec };
+}
+
+static inline struct timespec
+valid_timeval_long_to_timespec (const struct __timeval_long tv)
+{
+  return (struct timespec) { tv.tv_sec, tv.tv_usec * 1000 };
+}
+
+static inline struct __timeval_long
+valid_timespec_to_timeval_long (const struct timespec ts)
+{
+  return (struct __timeval_long) { (time_t) ts.tv_sec, ts.tv_nsec / 1000 };
+}
+
 /* Check if a value is in the valid nanoseconds range. Return true if
    it is, false otherwise.  */
 static inline bool
diff --git a/time/bits/types/struct_timeval.h b/time/bits/types/struct_timeval.h
index 70394ce886..73697689cc 100644
--- a/time/bits/types/struct_timeval.h
+++ b/time/bits/types/struct_timeval.h
@@ -10,4 +10,12 @@ struct timeval
   __time_t tv_sec;		/* Seconds.  */
   __suseconds_t tv_usec;	/* Microseconds.  */
 };
+
+/* A version of 'struct timeval' with `long` time_t
+   and suseconds_t.  */
+struct __timeval_long
+{
+  long tv_sec;		/* Seconds.  */
+  long tv_usec;		/* Microseconds.  */
+};
 #endif
-- 
2.24.1


  parent reply	other threads:[~2020-01-12 10:40 UTC|newest]

Thread overview: 138+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-12 10:33 [RFC v6 00/23] RISC-V glibc port for the 32-bit Alistair Francis
2020-01-12 10:33 ` [RFC v6 01/23] math/gen-libm-test.py: Convert to Python 3 Alistair Francis
2020-01-12 14:46   ` Joseph Myers
2020-01-14  6:53     ` Alistair Francis
2020-01-12 10:33 ` [RFC v6 02/23] tst-clone3: Use __NR_futex_time64 if we don't have __NR_futex Alistair Francis
2020-01-12 10:33 ` Alistair Francis [this message]
2020-01-12 14:48   ` [RFC v6 03/23] time: Add a timeval with a long tv_sec and tv_usec Joseph Myers
2020-01-14  7:18     ` Alistair Francis
2020-01-14 11:27       ` Lukasz Majewski
2020-01-14 10:16   ` Lukasz Majewski
2020-01-15  5:15     ` Alistair Francis
2020-01-15  8:01       ` Arnd Bergmann
2020-01-15  8:48       ` Lukasz Majewski
2020-01-12 10:33 ` [RFC v6 04/23] linux: Use 32-bit time_t for itimerval Alistair Francis
2020-01-14 10:58   ` Lukasz Majewski
2020-01-15 23:39     ` Alistair Francis
2020-01-16  1:21       ` Joseph Myers
2020-01-16  1:33         ` Alistair Francis
2020-01-16 13:34           ` Lukasz Majewski
2020-01-17  6:39             ` Alistair Francis
2020-01-17 11:14               ` Lukasz Majewski
2020-01-17 12:03                 ` Alistair Francis
2020-01-17 12:19                   ` Lukasz Majewski
2020-01-17 14:14                   ` Joseph Myers
2020-01-16 16:19           ` Joseph Myers
2020-01-17  6:40             ` Alistair Francis
2020-01-12 10:33 ` [RFC v6 05/23] linux: Use 32-bit time_t for rusage Alistair Francis
2020-01-14 11:58   ` Lukasz Majewski
2020-01-15 23:42     ` Alistair Francis
2020-01-12 10:33 ` [RFC v6 06/23] sysdeps: Use long types with 64-bit time_t on 32-bit archs Alistair Francis
2020-01-12 21:41   ` Arnd Bergmann
2020-01-16  7:30     ` Alistair Francis
2020-01-16  7:41       ` Alistair Francis
2020-01-16  8:36       ` Arnd Bergmann
2020-01-16 22:16         ` Alistair Francis
2020-01-16 22:41           ` Joseph Myers
2020-01-12 10:33 ` [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 Alistair Francis
2020-01-14 12:07   ` Lukasz Majewski
2020-01-15  5:09     ` Alistair Francis
2020-02-12  0:14   ` Vineet Gupta
2020-02-12  0:14     ` Alistair Francis
2020-02-12  1:30       ` Joseph Myers
2020-02-14 22:39         ` Alistair Francis
2020-02-18 23:05           ` switching ARC to 64-bit time_t (Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64) Vineet Gupta
2020-02-18 23:13             ` Joseph Myers
2020-02-19 23:09               ` Lukasz Majewski
2020-02-19 23:11             ` Lukasz Majewski
2020-02-20  8:31               ` Arnd Bergmann
2020-02-20  9:37                 ` Lukasz Majewski
2020-02-20 12:37                   ` Arnd Bergmann
2020-02-20 13:14                     ` Lukasz Majewski
2020-02-20 14:44                       ` Arnd Bergmann
2020-02-20 15:42                         ` Lukasz Majewski
2020-02-20 16:08                           ` Arnd Bergmann
2020-02-20 16:31                             ` Lukasz Majewski
2020-02-24  2:48                         ` Viresh Kumar
2020-02-21 19:56                     ` Alistair Francis
2020-02-22  8:42                   ` Arnd Bergmann
2020-02-24  9:00                     ` Lukasz Majewski
2020-02-24  9:46                       ` Andreas Schwab
2020-02-24 10:14                         ` Lukasz Majewski
2020-02-24 10:23                           ` Andreas Schwab
2020-02-24 10:36                             ` Lukasz Majewski
2020-02-24 10:42                               ` Andreas Schwab
2020-02-24 11:13                                 ` Lukasz Majewski
2020-02-24 12:41                                   ` Lukasz Majewski
2020-02-25  0:03                               ` Joseph Myers
2020-02-25 11:39                                 ` Lukasz Majewski
2020-02-25 14:36                                   ` Joseph Myers
2020-02-26 13:18                                     ` Lukasz Majewski
2020-02-26 14:48                                       ` Joseph Myers
2020-02-26 16:28                                         ` Lukasz Majewski
2020-02-25  9:03                       ` Arnd Bergmann
2020-02-20 16:27                 ` Helmut Grohne
2020-03-26  0:25                   ` ARC rebootstrap prereq (was Re: switching ARC to 64-bit time_t ) Vineet Gupta via Libc-alpha
2020-03-26  5:54                     ` Helmut Grohne
2020-03-26 11:51                       ` Alexey Brodkin via Libc-alpha
2020-03-26 12:24                         ` Helmut Grohne
2020-03-26 12:53                           ` Alexey Brodkin via Libc-alpha
2020-03-26 14:28                             ` Helmut Grohne
2020-03-26 19:04                               ` Lennart Sorensen via Libc-alpha
2020-08-26 14:39                       ` Vineet Gupta via Libc-alpha
2020-08-26 15:43                         ` Helmut Grohne
2020-08-26 21:16                           ` Aurelien Jarno
2021-02-24 20:17                             ` Vineet Gupta via Libc-alpha
2021-02-26  9:47                               ` Helmut Grohne
2021-02-26 15:58                                 ` Vineet Gupta via Libc-alpha
2021-08-21 17:36                             ` Aurelien Jarno
2020-02-12  1:42       ` [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 Vineet Gupta
2020-02-12 12:58         ` Arnd Bergmann
2020-02-19  0:56   ` Vineet Gupta
2020-02-19  1:03     ` Alistair Francis
2020-02-19  1:31       ` Vineet Gupta
2020-02-19  8:30         ` Andreas Schwab
2020-02-19 18:42           ` Vineet Gupta
2020-02-19 23:18             ` Lukasz Majewski
2020-02-20  0:26               ` Vineet Gupta
2020-02-20  0:46                 ` Joseph Myers
2020-02-20  8:24                   ` Arnd Bergmann
2020-02-20 10:28                     ` Lukasz Majewski
2020-02-20 14:14                     ` Joseph Myers
2020-01-12 10:33 ` [RFC v6 08/23] RISC-V: Define __NR_* as __NR_*_time64/64 for 32-bit Alistair Francis
2020-01-13 13:39   ` Arnd Bergmann
2020-01-14  7:14     ` Alistair Francis
2020-01-14 12:47       ` Arnd Bergmann
2020-01-15  7:03         ` Alistair Francis
2020-01-25 20:33           ` Khem Raj
2020-01-27  8:39             ` Arnd Bergmann
2020-01-27 10:02               ` Florian Weimer
2020-01-27 13:11                 ` Arnd Bergmann
2020-01-27 13:17                   ` Florian Weimer
2020-01-27 14:08                     ` Arnd Bergmann
2020-01-12 10:33 ` [RFC v6 09/23] RISC-V: Add support for 32-bit vDSO calls Alistair Francis
2020-01-13 13:33   ` Arnd Bergmann
2020-01-14  7:23     ` Alistair Francis
2020-01-12 10:33 ` [RFC v6 10/23] RISC-V: Add socket-constants.h for RV32 Alistair Francis
2020-01-12 10:34 ` [RFC v6 11/23] RISC-V: Support dynamic loader for the 32-bit Alistair Francis
2020-01-12 10:34 ` [RFC v6 12/23] RISC-V: Add path of library directories " Alistair Francis
2020-01-12 10:34 ` [RFC v6 13/23] RISC-V: Add arch-syscall.h for RV32 Alistair Francis
2020-01-12 10:34 ` [RFC v6 14/23] RISC-V: The ABI implementation for the 32-bit Alistair Francis
2020-01-12 10:34 ` [RFC v6 15/23] RISC-V: Hard float support for 32-bit Alistair Francis
2020-01-12 10:34 ` [RFC v6 16/23] RISC-V: Add ABI lists Alistair Francis
2020-01-12 10:34 ` [RFC v6 17/23] RISC-V: Add the RV32 libm-test-ulps Alistair Francis
2020-01-12 10:34 ` [RFC v6 18/23] RISC-V: Fix llrint and llround missing exceptions on RV32 Alistair Francis
2020-01-12 10:34 ` [RFC v6 19/23] RISC-V: Build Infastructure for 32-bit Alistair Francis
2020-01-12 10:34 ` [RFC v6 20/23] riscv32: Specify the arch_minimum_kernel as 5.4 Alistair Francis
2020-01-12 10:56   ` Andreas Schwab
2020-01-14  7:25     ` Alistair Francis
2020-01-14  9:03       ` Andreas Schwab
2020-01-12 10:34 ` [RFC v6 21/23] RISC-V: Add rv32 path to RTLDLIST in ldd Alistair Francis
2020-01-12 10:34 ` [RFC v6 22/23] Documentation for the RISC-V 32-bit port Alistair Francis
2020-01-12 10:34 ` [RFC v6 23/23] Add RISC-V 32-bit target to build-many-glibcs.py Alistair Francis
2020-01-12 14:44 ` [RFC v6 00/23] RISC-V glibc port for the 32-bit Joseph Myers
2020-01-14  7:30   ` Alistair Francis
2020-01-14 22:08     ` Joseph Myers
2020-01-15  4:30       ` Alistair Francis
2020-01-15 21:50         ` Joseph Myers
2020-01-15 23:50           ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85291ec316dcd3f3a3155488a8c290298650dc77.1578824547.git.alistair.francis@wdc.com \
    --to=alistair.francis@wdc.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=alistair23@gmail.com \
    --cc=arnd@arndb.de \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=macro@wdc.com \
    --cc=palmerdabbelt@google.com \
    --cc=zongbox@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).