From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EBC201F601 for ; Mon, 5 Dec 2022 16:40:36 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="CfNYHIHt"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 314EB3952492 for ; Mon, 5 Dec 2022 16:40:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 314EB3952492 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670258436; bh=+j5Yz5h0wydTO/fx4ZSaajvUCbW/v1JFkdEoRw7UIYs=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=CfNYHIHt2+zT/uR+kqKdZV2HtCaeOJGb1+oZfT8LGG/ObDTNawi2ztDSUUY6NoYf9 0d8gwA61lE1ZGPCz1b/nnYIihCTGAmddyGo5zMBt7Y1+dbUqj8QKO2Z3SdWg/4de1i yyI1PcwFTJHeYk6id2CqX21ruuvmN9sihP6ewKzs= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B48943945C3A for ; Mon, 5 Dec 2022 16:40:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B48943945C3A Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-344-ZHxhIbhqOXODVAJgXsOOOQ-1; Mon, 05 Dec 2022 11:40:12 -0500 X-MC-Unique: ZHxhIbhqOXODVAJgXsOOOQ-1 Received: by mail-io1-f71.google.com with SMTP id l21-20020a5d9315000000b006df7697880aso10301539ion.23 for ; Mon, 05 Dec 2022 08:40:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+j5Yz5h0wydTO/fx4ZSaajvUCbW/v1JFkdEoRw7UIYs=; b=GBvYzT6bPROykUlcTQMOgf5+G6ekktsA/HD0Ze34m7itZWkTk62kE9V5hHlwlLeWCH 5uirlVSH0j/Pu97QbtrVprrt36zrOIweCNWcwoAOag3P3drNHdTwgPw4SUvQgiCBYC0y qRULppQ/ztiFwOSo86DmpmKz6OzK4Z/2WUQ/qT5EwJxgbOyRqYNUC+gfiDxLXsU3SlLn aPQNe20PG1TSz8yATa2tO6ubf1NS68VZAYW7yDBCuhmOoK0W/pn/3PV/2DnNCfLL67Pk ik+RN0YZ1naBf7bD0xG8InYyD5pwkwsG61nCXsaHiXJGISdMExPihOLJHrBL1/LeOB9o 0Rrw== X-Gm-Message-State: ANoB5pluXLsa6k1nih562ecHKLOnYK8dfs0cKXeFR59Xko5X0hlMBizX /3NDoLePiQc0bf6Qv5Im35Uvhv27vehc33zYndGPDYjtIJpPDG95SQYl9pEuYE/oNHCFa3PYPr7 BYEpy+vtgVhmKWRi0c7LI X-Received: by 2002:a02:2422:0:b0:375:1ad6:e860 with SMTP id f34-20020a022422000000b003751ad6e860mr40201535jaa.191.1670258411406; Mon, 05 Dec 2022 08:40:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf52B4lA36aYr+mOh3JDI2fHAdbhByEtQyyHJ5L9fsvzGitgUwcW9O7KKNXiVmnUGR7WTWaoPw== X-Received: by 2002:a02:2422:0:b0:375:1ad6:e860 with SMTP id f34-20020a022422000000b003751ad6e860mr40201528jaa.191.1670258411145; Mon, 05 Dec 2022 08:40:11 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id r6-20020a92c506000000b002fc323a2902sm5357737ilg.62.2022.12.05.08.40.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 08:40:10 -0800 (PST) Message-ID: <8453e7c0-2411-7b6b-2a07-698a308d5298@redhat.com> Date: Mon, 5 Dec 2022 11:40:09 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 04/30] Linux: consolidate chown implementation To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20221019221433.1082017-1-adhemerval.zanella@linaro.org> <20221019221433.1082017-5-adhemerval.zanella@linaro.org> Organization: Red Hat In-Reply-To: <20221019221433.1082017-5-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 10/19/22 18:14, Adhemerval Zanella via Libc-alpha wrote: > Use chown syscall if defined, otherwise use fchownat. > > Checked on x86_64-linux-gnu. LGTM. No regressions on x86_64 and i686. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > --- > sysdeps/unix/sysv/linux/{generic => }/chown.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > rename sysdeps/unix/sysv/linux/{generic => }/chown.c (77%) > > diff --git a/sysdeps/unix/sysv/linux/generic/chown.c b/sysdeps/unix/sysv/linux/chown.c > similarity index 77% > rename from sysdeps/unix/sysv/linux/generic/chown.c > rename to sysdeps/unix/sysv/linux/chown.c > index 53997a1127..c1cd4d6c3d 100644 > --- a/sysdeps/unix/sysv/linux/generic/chown.c > +++ b/sysdeps/unix/sysv/linux/chown.c > @@ -1,4 +1,5 @@ > -/* Copyright (C) 2011-2022 Free Software Foundation, Inc. > +/* Change ownership of a file. Linux version. > + Copyright (C) 2011-2022 Free Software Foundation, Inc. > This file is part of the GNU C Library. > > The GNU C Library is free software; you can redistribute it and/or > @@ -23,7 +24,11 @@ > int > __chown (const char *file, uid_t owner, gid_t group) > { > - return INLINE_SYSCALL (fchownat, 5, AT_FDCWD, file, owner, group, 0); > +#ifdef __NR_chown > + return INLINE_SYSCALL_CALL (chown, file, owner, groups); > +#else > + return INLINE_SYSCALL_CALL (fchownat, AT_FDCWD, file, owner, group, 0); > +#endif OK. > } > libc_hidden_def (__chown) > weak_alias (__chown, chown) -- Cheers, Carlos.