From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EFD161F601 for ; Mon, 5 Dec 2022 16:42:19 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="MJ7mtHtF"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C79DD3942033 for ; Mon, 5 Dec 2022 16:42:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C79DD3942033 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670258538; bh=+/X4xziY4b3tf5h+zbeZ/MknBbxiRL9dOTpBJDxgXB0=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=MJ7mtHtFFnQd9zf7EGITnPoU70oIU6RQnazQoqr9PNV20MCKc5x45lTqS2T4zY2G9 rRLGSFkm7FGgyZ7sb5fPUTWt8q4hkMFMf6h3mXQUPyCNOzCWC6ZDTB9maE/vsbL+we 3JbTH2c4sW/Dazm9MIa/zHKb3VrHJ8Hkw6uRA9WA= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6DE663945C25 for ; Mon, 5 Dec 2022 16:40:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6DE663945C25 Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-159-cjWiUrS1M92JOTWzUAqb0g-1; Mon, 05 Dec 2022 11:40:10 -0500 X-MC-Unique: cjWiUrS1M92JOTWzUAqb0g-1 Received: by mail-il1-f200.google.com with SMTP id l16-20020a056e02067000b0030325bbd570so12391720ilt.0 for ; Mon, 05 Dec 2022 08:40:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+/X4xziY4b3tf5h+zbeZ/MknBbxiRL9dOTpBJDxgXB0=; b=42yyjHTF2x3nc4BxSQpgO789UkvAbhJ3c4L4opahqhRdqA9fyOLUbRa8g1TqD13lje /PcCbuX20v+Kqc1R8D8KfQ0WPDWjFnp05eKysc6P192rDr2a/R1pGxbP4VD3NFLqt6eI qadICD5tT7s/oXyAeVyk08recNguXhGwnRcIFv5MeDJdH5KouP4GclqoiXRtjN26c5oB UgJJJCutUE44pHkLNRSHv2PG7sL9/jkts7K2lw+HcrrzvTARqILwKaHBz91oA88fU5aW +yZ2PS8WFOKRvN3jb5Y65EfNaPVh4gJZ8topFtO04KlHiYjvJ9zKTLiwXvmQfuxcVRE/ pzHQ== X-Gm-Message-State: ANoB5pngMoQSwSdAwJeTyqEiFfkMF+iiM2+WUz3qAlfDPzW18MiJKWJq 1wCrckiIWdeVTzcttzwJlGazinAKN9cMLRhE8PZPa3p8cgP5Q4vD2SIKAflEaK1M6trDPBCStCG 9GPWgR4csY8pzfTiHxAHw X-Received: by 2002:a5d:97cc:0:b0:6df:c622:6d11 with SMTP id k12-20020a5d97cc000000b006dfc6226d11mr10833810ios.195.1670258409422; Mon, 05 Dec 2022 08:40:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf6w2WWwy8KLruecHCKuI36fupwqtzrVFCQ/uACeqAGBI7ixBQxuE1NXqkF5rCzDnFF6/2OFhw== X-Received: by 2002:a5d:97cc:0:b0:6df:c622:6d11 with SMTP id k12-20020a5d97cc000000b006dfc6226d11mr10833802ios.195.1670258409155; Mon, 05 Dec 2022 08:40:09 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id s8-20020a02b148000000b0036ee761e2f4sm5795449jah.159.2022.12.05.08.40.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 08:40:08 -0800 (PST) Message-ID: <82a012fa-776c-502b-95f6-36f6cbcd81b0@redhat.com> Date: Mon, 5 Dec 2022 11:40:07 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 06/30] Lninux: consolidate epoll_create implementation To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20221019221433.1082017-1-adhemerval.zanella@linaro.org> <20221019221433.1082017-7-adhemerval.zanella@linaro.org> Organization: Red Hat In-Reply-To: <20221019221433.1082017-7-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 10/19/22 18:14, Adhemerval Zanella via Libc-alpha wrote: As noted by Florian s/Lninux/Linux/g so first line has typo. This needs a v2. > Use epoll_create syscall if defined, otherwise use epoll_create1. Tested-by: Carlos O'Donell > --- > sysdeps/unix/sysv/linux/{generic => }/epoll_create.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > rename sysdeps/unix/sysv/linux/{generic => }/epoll_create.c (79%) > > diff --git a/sysdeps/unix/sysv/linux/generic/epoll_create.c b/sysdeps/unix/sysv/linux/epoll_create.c > similarity index 79% > rename from sysdeps/unix/sysv/linux/generic/epoll_create.c > rename to sysdeps/unix/sysv/linux/epoll_create.c > index fa28694929..afb1921637 100644 > --- a/sysdeps/unix/sysv/linux/generic/epoll_create.c > +++ b/sysdeps/unix/sysv/linux/epoll_create.c > @@ -1,4 +1,5 @@ > -/* Copyright (C) 2011-2022 Free Software Foundation, Inc. > +/* Open an epoll file descriptor. Linux version. > + Copyright (C) 2011-2022 Free Software Foundation, Inc. > This file is part of the GNU C Library. > > The GNU C Library is free software; you can redistribute it and/or > @@ -23,12 +24,16 @@ libc_hidden_proto (epoll_create) > int > epoll_create (int size) > { > +#ifdef __NR_epoll_create > + return INLINE_SYSCALL_CALL (epoll_create); OK. > +#else > if (size <= 0) > { > __set_errno (EINVAL); > return -1; > } > > - return INLINE_SYSCALL (epoll_create1, 1, 0); > + return INLINE_SYSCALL_CALL (epoll_create1, 0); OK. > +#endif > } > libc_hidden_def (epoll_create) -- Cheers, Carlos.