From: Carlos O'Donell <carlos@redhat.com>
To: Liusirui <liusirui@huawei.com>, libc-alpha@sourceware.org
Cc: siddhesh@gotplt.org, dj@redhat.com, hushiyuan@huawei.com,
liqingqing3@huawei.com
Subject: Re: [PATCH] fix null pointer in mtrace
Date: Wed, 13 Nov 2019 07:59:50 -0500 [thread overview]
Message-ID: <8199beb2-2d9d-fd6b-f9d3-7f538392102a@redhat.com> (raw)
In-Reply-To: <1573637811-7639-1-git-send-email-liusirui@huawei.com>
On 11/13/19 4:36 AM, Liusirui wrote:
> In a multi-threaded program, some threads request or free memory and try to write trace info
> into file which "mallstream" points to. At the same time, another thread calls "muntrace" and
> set "mallstream" to NULL. This may cause a segmentation fault.
>
> The comment in malloc/mtrace.c says "We could be printing a NULL here; that's OK.". Although
> the functions mtrace/muntrace are used for debugging, program isn't expected to crash while using
> these functions.
Just a reminder that we're still waiting on the completion of a corporate assignment from Huawei.
We can't accept these patches until that is complete.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2019-11-13 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 9:36 [PATCH] fix null pointer in mtrace Liusirui
2019-11-13 12:59 ` Carlos O'Donell [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-12 9:22 Liusirui
2019-11-12 9:39 ` liqingqing
2019-11-12 10:41 ` Florian Weimer
2019-11-13 1:28 ` liqingqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8199beb2-2d9d-fd6b-f9d3-7f538392102a@redhat.com \
--to=carlos@redhat.com \
--cc=dj@redhat.com \
--cc=hushiyuan@huawei.com \
--cc=libc-alpha@sourceware.org \
--cc=liqingqing3@huawei.com \
--cc=liusirui@huawei.com \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).