From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B0E331F44D for ; Wed, 27 Mar 2024 19:32:09 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=bFew1248; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C7685385DC0F for ; Wed, 27 Mar 2024 19:32:08 +0000 (GMT) Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 9771A3858D20 for ; Wed, 27 Mar 2024 19:31:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9771A3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9771A3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::529 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711567908; cv=none; b=qu8ofIzBNGZufcemeHriMeHBnvmnVXfZQ1D68V/Khs92bGlNGcZLI5V+uzSw3Aa69hm+Kkcrv/WQQUPqhXOWzH0Lo91CKP/4yFaqPlcBH/57gVzkKvPGwfWSzjUAEWqW82V6zy4PxWWWIaXxgiZQihL8V5uNiNgl5Gh0uwNkTlk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711567908; c=relaxed/simple; bh=Pg3T5kr82e6AcH4LtdyINTwjKMJVY3aGR7Zcb9W+uE4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tu0vCTY6nb1YXoIPvzN59okOThHLv9wGSMSAc75gkatcPx7UqC6sHZufxhnis+lJPL4KpeOOttvsBmS6twX7rQxYdjECkJDHOea2UvjqhGHwcaSd70uaZ44D8e4LpMdv+l+pzn/HXIeZfBdSFeU2X0WtxMg7TrE0iaDeYnUnGeQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-5e152c757a5so83624a12.2 for ; Wed, 27 Mar 2024 12:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711567905; x=1712172705; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=VWdWOoHUAFw+mrX8KrZXYDpk77Y5eAvnVT27ZWtM0XM=; b=bFew1248albv6eaCcni41ahp08oFRbIkiya09PnqTCBJX4WAly9lmIGWbHUHPFSiES IY2EJF28bgApdPbY9RNx0fqeky7hNSrcqkl8CExqHLnQUP31Et2+NZMrQohJDMZi9pMs 0OQ+Pi/rV8xSM35l/1G8QYab5gSMGAMq99mHILTPl16yRFAWOTUrLqkKgezeDwbSHzPZ u2cIlnrH9RPzu1NIxOOh0l5B1NDqG8zLlbDDBuEHc0UWZ/uJuLDQ66GFMxcxbCuL1smL Z0kgavsx2mX9Dj1jOONtigcjfwTElE6iqf2m7BugSYKjH3n5Z3DK6b5RYHTIp78xW76M GWAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711567905; x=1712172705; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VWdWOoHUAFw+mrX8KrZXYDpk77Y5eAvnVT27ZWtM0XM=; b=iEtM19FVZu3M6yhOJtO7jRKN14/yUeZl7cBwniwi6amcmKZk/40FU5Azc9FsR8iRfv 930mwZ1wlYFvFr3o29wLfpFO28B29RJjV5jy28i0TePEehyfOYYIG3b7lxFQZYOhuQMu UzztRflfey5LoKCCXjyAAc3TnOspSCHYWHVafs5na3+aPAYzcBgbDBw2iJIawq/648OE CnNGt6yeMrpWdt5dm1g1ClTPBgbK5rltcibrAqtphZG4D3Kv5QGEleACIWJ563Yxe6BF Ft1v5MWIGnbevWh+Lk4dc0dHVrHQzeIl4XhJjNVnEvp+VXplCbjCUdXDSGp3lIT4ls6Z 93vQ== X-Gm-Message-State: AOJu0Yx8S2/wt/OdjvP+hmy3OAR2OjeZte2wfGf5NIazn4PZ4lSO7iGI Yq3h6zRiq9ZPdOt3KSq7eMALsO8kxbeKg8I2zywRtT6GOzynFz20bPky3sDBoy0= X-Google-Smtp-Source: AGHT+IGJ6hKylEoQ66Dap2JB6/lyPas1+PJEzbez3V9nTcMr1i/H+WnH7Qz57rh5jZ2/PrhGI+chyw== X-Received: by 2002:a05:6a20:3c9f:b0:1a3:a639:ef7c with SMTP id b31-20020a056a203c9f00b001a3a639ef7cmr1095672pzj.1.1711567905451; Wed, 27 Mar 2024 12:31:45 -0700 (PDT) Received: from [192.168.15.31] ([187.56.129.71]) by smtp.gmail.com with ESMTPSA id 15-20020a63000f000000b005dc26144d96sm9804961pga.75.2024.03.27.12.31.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 12:31:44 -0700 (PDT) Message-ID: <80716bb6-2d25-49ec-bcd4-a68ac576734d@linaro.org> Date: Wed, 27 Mar 2024 16:31:41 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/15] math: Fix acos template for arguments greater than 1 To: Joseph Myers Cc: libc-alpha@sourceware.org, Florian Weimer , "H . J . Lu" References: <20240327164527.3717523-1-adhemerval.zanella@linaro.org> <20240327164527.3717523-12-adhemerval.zanella@linaro.org> <21a70abc-787c-403d-bf3d-24e386be8a7e@linaro.org> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On 27/03/24 16:04, Joseph Myers wrote: > On Wed, 27 Mar 2024, Adhemerval Zanella Netto wrote: > >> And I think it is unrelated to gcc PR95115 because x86_64/i686 will use >> and specific sysdeps/i386/fpu/e_acosl.c that explicit does not handle this >> input case for overflow exceptions. For shared build this case is >> handle by w_acosl_compat.c: >> >> if (__builtin_expect (isgreater (fabsl (x), 1.0L), 0) >> && _LIB_VERSION != _IEEE_) >> { >> /* acos(|x|>1) */ >> feraiseexcept (FE_INVALID); >> return __kernel_standard_l (x, x, 201); >> } > > The compat code is dealing with the possibility of SVID exceptions, which > isn't relevant here. I meant that __ieee754_acosl in being called in both code paths, but the compat code returns early without calling __ieee754_acosl for the possible problematic code path. > >> And that's why I though following the same logic on template would be >> better. But I think maybe we should fix on x86_64 implementation instead. > > Yes, we should fix the x86_64 implementation. > > Such issues in dbl-64, flt-32 or ldbl-128 sources would largely have been > fixed (modulo compiler bugs) when we started adding new architectures > after new architectures stopped using the compat wrappers - but any issues > for ldbl-128ibm, ldbl-96 or architecture-specific sources wouldn't have > been detected then. > I will drop this change and rather focus on the original issues on missing symbols. I will open some bug against the x86 implementation so we keep track of these issues with static linkage.