unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: GNU C Library <libc-alpha@sourceware.org>
Subject: LTP highlights and thanks reviewers using Reviewed-by tags, so should we!
Date: Wed, 23 Jan 2019 12:41:40 -0500	[thread overview]
Message-ID: <8042e438-bc3b-e4d1-21a4-59cbd6553ac3@redhat.com> (raw)
In-Reply-To: <20190115145747.GB7842@rei.lan>

See here:
https://www.sourceware.org/ml/libc-alpha/2019-01/msg00339.html
~~~
git log 20180926.. | grep -Ei '(reviewed|acked)-by:' | sed 's/.*by: //' | sort | uniq -c | sort -n -r
     86 Cyril Hrubis <chrubis@suse.cz>
     20 Petr Vorel <pvorel@suse.cz>
     13 Li Wang <liwang@redhat.com>
     10 Jan Stancek <jstancek@redhat.com>
      7 Alexey Kodanev <alexey.kodanev@oracle.com>
      4 Xiao Yang <yangx.jy@cn.fujitsu.com>
      3 Richard Palethorpe <rpalethorpe@suse.de>
      1 Steve Muckle <smuckle@google.com>
      1 Richard Palethorpe <rpalethorpe@suse.com>
      1 Jan Kara <jack@suse.cz>
      1 Amir Goldstein <amir73il@gmail.com>
~~~

I just wanted to point out that I think the example below
of highlighting and thanking reviewers is a really great
example of how Reviewed-by: tags in commits helps the
community as a whole and gives thanks to those that are
doing the often thankless task of review :-)

I encourage everyone to review patches, give your Reviewed-by:
and to put the Reviewed-by: tags in your commits when you
receive them. Eventually we'll get our workflow down to the
point where this is easier not to forget.

Thank you!

--
Cheers,
Carlos.

      reply	other threads:[~2019-01-23 17:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 14:57 [LTP] [ANNOUNCE] The Linux Test Project has been released for JANUARY 2019 Cyril Hrubis
2019-01-23 17:41 ` Carlos O'Donell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8042e438-bc3b-e4d1-21a4-59cbd6553ac3@redhat.com \
    --to=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).