From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5EB3A1F85E for ; Fri, 13 Jul 2018 21:09:32 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=rOsH7PsNPyEedb/T HgZZ/HetfmgSelFFM9UGAN/PWjJ5sncojJ+TDMUYboZ9j+PXcmZF4jsv0RByoAxr 1cAoWU0vLZH2/ezPMuXGORH2G3mAG4tA+v3BmJy4gVQNtPfyIsdbDAF6C9qrIDfK DuHs+cmbd5w39g3wjYHADo+rupc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=MZEslaqt7oY9fAHddy1Vpy H0Yw8=; b=MSQohU24X2ZgYyJwOJo+Qm6RR0NlsPnLRTRL4YpB41qD+eYZJ+6YqO ST07VPy6VnsMLxv51Z8Qs+bSBqr8h/Lb7q3a+7NoiDy+VqCPIp2usWqf33uwqSmX i5uSgnxatUhVI3aruYkPqrObQkEoaXYB82ig+wDyWXkxDClC+sxe4= Received: (qmail 89238 invoked by alias); 13 Jul 2018 21:09:29 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 89228 invoked by uid 89); 13 Jul 2018 21:09:29 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-vk0-f68.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NgdHiql5ydNVmmOGaHJsUicf5aL7ntEpuv7rFbspKPk=; b=F1Q/VfiCJHkz6Fq5bBsObME12o3q1Qvfl+q6rVlNN5d+UZggE/RWPVOsq2t4aiU2kc MJbTi3DzC6S1+MdZbmtZM6OhfJdU6OGjfaLwdMgpKipd+eKs5uktAPFFGIpi9BDUO7Gq oxqO6ZB410raJmWdr5W8eKF3SI8MYtK1Atjx8= Subject: Re: [PATCH v8 6/8] nptl: Add abilist symbols for C11 threads To: Florian Weimer Cc: Florian Weimer , libc-alpha@sourceware.org References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-7-git-send-email-adhemerval.zanella@linaro.org> <97b42cb3-e76a-ac71-65cd-c1f6d8c404aa@redhat.com> <90dc04ab-81df-b0d7-a086-d00ea5cc979d@linaro.org> <5ec19a17-30a3-e9b7-9475-c28b247c8daa@redhat.com> <98a36756-5dc8-680b-c065-3501ca4ec7d4@linaro.org> <87muuuc3jw.fsf@mid.deneb.enyo.de> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: <7f8e17f2-198f-a2cc-8fc1-be1979605229@linaro.org> Date: Fri, 13 Jul 2018 18:09:21 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87muuuc3jw.fsf@mid.deneb.enyo.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 13/07/2018 16:56, Florian Weimer wrote: > * Adhemerval Zanella: > >>> I think ONCE_FLAG_INIT needs to be a compound literal, not an >>> initializer, at least that's how I read the standard (“which expands >>> to a value that can be used to initialize an object”). >> >> Right, you are correct, this will prevent ONCE_FLAG_INIT to be wrongly >> used to initialize other objects than once_flag. I adjust to be a >> struct as well. > > Sorry, I forgot that this needs another __cplusplus conditional. > > Something like this: > > #ifdef __cplusplus > # define ONCE_FLAG_INIT (once_flag {}) > #else > # define ONCE_FLAG_INIT (once_flag) { 0 } > #endif > > Compound literals in C++ are a GCC extension. Fixed.