From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EC1351F463 for ; Mon, 23 Sep 2019 17:49:28 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=GnNF8U2j8HchKe35 /51E353r4CRnnivd566gIvBSCqKi/9CTkO3VrCzXNCiIzdAxS2E/vCGmF51MJjum YFixR4CIL0FVcohbrcnUqXTYpgnsyv1xnmTKrfOkP2rSweAsC3hwmuY6pZGfSXdo fSvLd9XAlpGzoVcxXK36+t1jA5k= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=wrtnSLgVCg/MhHSqBg0Irv 0kA4s=; b=jjld0YgTNc0dIS4lWHBPl+iHzwLm4EERmU4DawSGdoDaUurAILF9kH VuPz+rSG7/GJsS3+j4sk8IB6bUdxRnsLUzyHVyPv0H6Aoum5+kL31WdqGTGqhZuu E/sMRkxt/DRFEboiLeV/klBvl65Hn5cg3HNSFu4c7Apj5iI9CTKRM= Received: (qmail 40518 invoked by alias); 23 Sep 2019 17:48:44 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 40291 invoked by uid 89); 23 Sep 2019 17:48:27 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH v2 6/6] [powerpc] Rename fegetenv_status to fegetenv_control To: Paul E Murphy , libc-alpha@sourceware.org Cc: tuliom@ascii.art.br References: <1568918810-20393-1-git-send-email-pc@us.ibm.com> <1568918810-20393-7-git-send-email-pc@us.ibm.com> <986b012c-90dc-3f17-6b12-c80174d32f9a@linux.ibm.com> From: Paul Clarke Message-ID: <7c42954d-6fd3-4401-3665-c98fd7583454@us.ibm.com> Date: Mon, 23 Sep 2019 12:48:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <986b012c-90dc-3f17-6b12-c80174d32f9a@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 9/23/19 11:21 AM, Paul E Murphy wrote: > On 9/19/19 1:46 PM, Paul A. Clarke wrote: >> fegetenv_status is used variously to retrieve the FPSCR exception enable >> bits, rounding mode bits, or both.  These are referred to as the control >> bits in the POWER ISA.  FPSCR status bits are also returned by the >> 'mffs' and 'mffsl' instructions, but they are uniformly ignored by all >> uses of fegetenv_status.  Change the name to be reflective of its >> current and expected use. >> >> 2019-09-19  Paul A. Clarke  >> >>     * sysdeps/powerpc/fpu/fenv_libc.h (fegetenv_status): Rename to >>     fegetenv_control. >>     * sysdeps/powerpc/fpu/fedisblxcpt.c (fedisableexcept): Accommodate >>     rename of fegetenv_status to fegetenv_control. >>     * sysdeps/powerpc/fpu/feenablxcpt.c (feenableexcept): Likewise. >>     * sysdeps/powerpc/fpu/fegetexcept.c (__fegetexcept): Likewise. >>     * sysdeps/powerpc/fpu/fegetmode.c (fegetmode): Likewise. >>     * sysdeps/powerpc/fpu/fesetenv.c (__fesetenv): Likewise. >>     * sysdeps/powerpc/fpu/fesetmode.c (fesetmode): Likewise. >> --- >> v2: This is a new patch in the series. > > OK. Thanks! > Reviewed-By: Paul E Murphy > >> diff --git a/sysdeps/powerpc/fpu/fegetmode.c b/sysdeps/powerpc/fpu/fegetmode.c >> index 0e0a01c..65c5ebe 100644 >> --- a/sysdeps/powerpc/fpu/fegetmode.c >> +++ b/sysdeps/powerpc/fpu/fegetmode.c >> @@ -21,6 +21,6 @@ >>   int >>   fegetmode (femode_t *modep) >>   { >> -  *modep = fegetenv_status (); >> +  *modep = fegetenv_control (); >>     return 0; >>   } > > Slightly off-topic, is fegetmode documented? Again, not an expert here, but "git blame math/fegetmode.c" shows this: -- commit ec94343f592df68ba1ba49bb2c558f7d2629387c Author: Joseph Myers Date: Wed Sep 7 16:40:09 2016 +0000 Add femode_t functions. TS 18661-1 defines a type femode_t to represent the set of dynamic floating-point control modes (such as the rounding mode and trap enablement modes), and functions fegetmode and fesetmode to manipulate those modes (without affecting other state such as the raised exception flags) and a corresponding macro FE_DFL_MODE. [...] -- PC