From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3F5491F85E for ; Thu, 12 Jul 2018 20:32:24 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=vI83tsRQ8yGnGCEX fM9MsxZ8iVmzK/vIf9dCJwov4yvrUf3c555Mqk+TFY8CG/Z3kS6E5TYE5jE+GUz8 okhaFknQSizrbcXnRlyPz7lo+jjZ9BDz/dM7+O2R/62LqxjWzaaz1R+lv34FaEh+ QQutmOfeZ2KX/5TlaZPuF7FIwfQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=7KVWJkfS8aokrm5KjlMPI6 wrzpE=; b=Xgfgh4pmnRwOhAxsT4TsKmZ6xWUhv99++sVV1TDfoWCT+C0Qf6hRgT fPdZGRGw52OFKHyWuslbSBwuIcMbFIwyiMHbjTFg7+Kl3GVjTukYahTbxKrp0ooZ wDFgCl8Lmf7byS/L+UknGaJMeCGSfJrm98b0sMKDeD4H17/joN2rw= Received: (qmail 89152 invoked by alias); 12 Jul 2018 20:32:22 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 89138 invoked by uid 89); 12 Jul 2018 20:32:21 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-ua0-f194.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TikYzRG2e0KYL9FnbKeaGI5+/K/3QfspcJZEDQLW0Bk=; b=OUdEQXzRge9vytZ/VlMaHgxhjIwlkG3A+1aEu/KUXNgIwtqhRC/0ht0z7RJD9tEmIu uqEoyJiZPisaIeiFKc1GFxe6uQDbNcchT5Fl+1EuX+azcXpscXQEop1B2URkSS4+dilQ SuBsVPrkUVUodzYr14V4oX2fpa+PSKi6Jry/c= Subject: Re: [PATCH v8 5/8] nptl: Add C11 threads tss_* functions To: Florian Weimer , libc-alpha@sourceware.org References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-6-git-send-email-adhemerval.zanella@linaro.org> <542a0078-8a10-b0be-fbf7-ae3f8bece155@redhat.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: <7bc71183-1c78-21d8-f482-6acd04c8fd66@linaro.org> Date: Thu, 12 Jul 2018 17:32:16 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <542a0078-8a10-b0be-fbf7-ae3f8bece155@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 12/07/2018 13:48, Florian Weimer wrote: > On 02/02/2018 06:04 PM, Adhemerval Zanella wrote: >> diff --git a/sysdeps/nptl/threads.h b/sysdeps/nptl/threads.h >> index eb89b0a..6a807ee 100644 >> --- a/sysdeps/nptl/threads.h >> +++ b/sysdeps/nptl/threads.h >> @@ -28,6 +28,10 @@ __BEGIN_DECLS >>   #include >>     #define ONCE_FLAG_INIT 0 >> +#define thread_local _Thread_local > > This needs a __cplusplus conditional.  _Thread_local does not exist in C++.  The macro has to be defined to thread_local starting with C++11. I think we can just not define it for C++, not really checking which version is being used.