From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 04A101F8C6 for ; Sat, 31 Jul 2021 18:42:02 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 09D8A3858434 for ; Sat, 31 Jul 2021 18:42:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 09D8A3858434 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627756921; bh=JbjlToYlL8XHmMtSZKFtA5NB5zPIT1U2sowr2AKMM08=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TiPs5DeKQpfxLRmhLtETz3fInuc2UQ6ynemBn6uIglq6SCH1YWAPg9k3wn+hBmnjM fG6Jz/M3YTZjeDw6cx+x6nd/qjPjxLqqk+t5bBjkHdSFYPoTbiOWits9s/dO/T/ws1 9qM/uORL7n/MFyLOuNdiLiV4BXgFOU5JdM3kDpvc= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1DFF33858402 for ; Sat, 31 Jul 2021 18:41:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1DFF33858402 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-506-BKl6py1lPKa51VMLxekkwg-1; Sat, 31 Jul 2021 14:41:39 -0400 X-MC-Unique: BKl6py1lPKa51VMLxekkwg-1 Received: by mail-qk1-f198.google.com with SMTP id b9-20020a05620a1269b02903b8bd5c7d95so7881742qkl.12 for ; Sat, 31 Jul 2021 11:41:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=JbjlToYlL8XHmMtSZKFtA5NB5zPIT1U2sowr2AKMM08=; b=AuyF9E/OV6n2p28qIEFra/pYI0OTzPx9vjmajy3bpI7zDLAcQI0U6DHb4j9/e06YMc fsVxRoqqkG0C+GN8UIHCwCYbBdTD3gcO2U9ESk5/O1oscS+ntiiBUbAwXuSMeivVc5sn bAF0z5x+jl6K8fDr+KUKb2SA+Sd4Xx46LTulWkKkhUWyezKWxoDynCbdBsGkJf44iULx fHaX2Vs4ol0kx/OrhAt7NFyK1nYOWgFhq8XKeAe4zJL/FpeeWe+j3vOQPlqAGqDl0tlg Q9DjMhbTY8x10dgxbBf45tvQgyOgwonGti18bx79k/fxQ8xPG1Uo20/1tTuHvgYgUdmg xC5A== X-Gm-Message-State: AOAM531y+BKcFYhxJ77woQllHKahpZv5h1LZJ6+cStP5vCdEe1cRvBaD ro/2JIDgrKLinYCdLdjyrNpyYIa72TmWBFDhZ8BTgBfWy2jki40FbyR1NQoBSF4jj9qCV9lHjUy CSwAE3HLmPKX9YhPaNnqnh7Mur37DitHNznGJlyciIYBLo6kFxR6cZ36LkhvfbYYf2wFB4Q== X-Received: by 2002:a0c:c78b:: with SMTP id k11mr9035853qvj.55.1627756899020; Sat, 31 Jul 2021 11:41:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHtHQtFxc4hTYVVyYz8gKGNdF3hk1qwd451WHHRO+cNl0vhWHZe1n3iPz56OgCFroqzQO/yg== X-Received: by 2002:a0c:c78b:: with SMTP id k11mr9035838qvj.55.1627756898808; Sat, 31 Jul 2021 11:41:38 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id g4sm2820427qkk.104.2021.07.31.11.41.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Jul 2021 11:41:38 -0700 (PDT) Subject: Re: [PATCH v6 1/2] Add 'strcmp_collation' support for LC_COLLATE. To: Florian Weimer , Andreas Schwab References: <20210730194845.2165087-1-carlos@redhat.com> <20210730194845.2165087-2-carlos@redhat.com> <87tukb7dx3.fsf@igel.home> <87lf5nwnuu.fsf@oldenburg.str.redhat.com> Organization: Red Hat Message-ID: <7ad7aa3f-8e53-baf5-27b9-c820ecb46107@redhat.com> Date: Sat, 31 Jul 2021 14:41:36 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87lf5nwnuu.fsf@oldenburg.str.redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Cc: Carlos O'Donell via Libc-alpha Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 7/30/21 4:25 PM, Florian Weimer via Libc-alpha wrote: > * Andreas Schwab: > >> On Jul 30 2021, Carlos O'Donell via Libc-alpha wrote: >> >>> Support a new directive 'strcmp_collation' in the LC_COLLATE >> >> strcmp is wrong for wide strings. How about codepoint_collation? > > Very good point. I like codepoint_collation. Agreed. Under the hood we are using either strcmp or wcscmp in strcoll and wcscoll respectively for nrules == 0 and that is correct. Fixing this for v7. -- Cheers, Carlos.