unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
To: Florian Weimer <fweimer@redhat.com>,
	Andreas Schwab <schwab@linux-m68k.org>
Cc: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v6 1/2] Add 'strcmp_collation' support for LC_COLLATE.
Date: Sat, 31 Jul 2021 14:41:36 -0400	[thread overview]
Message-ID: <7ad7aa3f-8e53-baf5-27b9-c820ecb46107@redhat.com> (raw)
In-Reply-To: <87lf5nwnuu.fsf@oldenburg.str.redhat.com>

On 7/30/21 4:25 PM, Florian Weimer via Libc-alpha wrote:
> * Andreas Schwab:
> 
>> On Jul 30 2021, Carlos O'Donell via Libc-alpha wrote:
>>
>>> Support a new directive 'strcmp_collation' in the LC_COLLATE
>>
>> strcmp is wrong for wide strings.  How about codepoint_collation?
> 
> Very good point.  I like codepoint_collation.

Agreed. Under the hood we are using either strcmp or wcscmp in
strcoll and wcscoll respectively for nrules == 0 and that is
correct.

Fixing this for v7.

-- 
Cheers,
Carlos.


  reply	other threads:[~2021-07-31 18:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 19:48 [PATCH v6 0/2] C.UTF-8 Carlos O'Donell via Libc-alpha
2021-07-30 19:48 ` [PATCH v6 1/2] Add 'strcmp_collation' support for LC_COLLATE Carlos O'Donell via Libc-alpha
2021-07-30 20:19   ` Andreas Schwab
2021-07-30 20:25     ` Florian Weimer via Libc-alpha
2021-07-31 18:41       ` Carlos O'Donell via Libc-alpha [this message]
2021-07-30 19:48 ` [PATCH v6 2/2] Add generic C.UTF-8 locale (Bug 17318) Carlos O'Donell via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ad7aa3f-8e53-baf5-27b9-c820ecb46107@redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=carlos@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).