From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: Fix another -Os strcoll build issue
Date: Mon, 26 Feb 2018 15:25:33 -0300 [thread overview]
Message-ID: <7a914b3d-14ff-a2b2-0894-756d2f40d39a@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1802231740550.24555@digraph.polyomino.org.uk>
On 23/02/2018 14:41, Joseph Myers wrote:
> While there are now clean -Os build and test results on x86_64 (given
> my patch <https://sourceware.org/ml/libc-alpha/2018-02/msg00602.html>,
> pending review), testing with -Os with build-many-glibcs.py shows the
> build is still failing with -Os everywhere except for x86_64, x86 and
> s390x.
>
> There are a variety of different build failures, but the most common
> seem to be in strcoll / wcscoll, similar to existing such cases where
> DIAG_* are used to disable -Wmaybe-uninitialized. There are various
> different failures even within those functions. This patch fixes one
> particular case that seems quite common, where the warning appears at
> the declarations of seq1 and seq2.
>
> Tested with build-many-glibcs.py that this fixes the -Os build for
> aarch64-linux-gnu with GCC 7.
>
> 2018-02-23 Joseph Myers <joseph@codesourcery.com>
>
> * string/strcoll_l.c: Include <libc-diag.h>.
> (STRCOLL): Ignore -Wmaybe-uninitialized for -Os around
> declarations of seq1 and seq2.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> diff --git a/string/strcoll_l.c b/string/strcoll_l.c
> index 4a63c56..c001ff4 100644
> --- a/string/strcoll_l.c
> +++ b/string/strcoll_l.c
> @@ -24,6 +24,7 @@
> #include <stdint.h>
> #include <string.h>
> #include <sys/param.h>
> +#include <libc-diag.h>
>
> #ifndef STRING_TYPE
> # define STRING_TYPE char
> @@ -291,7 +292,17 @@ STRCOLL (const STRING_TYPE *s1, const STRING_TYPE *s2, locale_t l)
>
> int result = 0, rule = 0;
>
> + /* With GCC 7 when compiling with -Os the compiler warns that
> + seq1.back_us and seq2.back_us might be used uninitialized.
> + Sometimes this warning appears at locations in locale/weightwc.h
> + where the actual use is, but on architectures other than x86_64,
> + x86 and s390x, a warning appears at the definitions of seq1 and
> + seq2. This uninitialized use is impossible for the same reason
> + as described in comments in locale/weightwc.h. */
> + DIAG_PUSH_NEEDS_COMMENT;
> + DIAG_IGNORE_Os_NEEDS_COMMENT (7, "-Wmaybe-uninitialized");
> coll_seq seq1, seq2;
> + DIAG_POP_NEEDS_COMMENT;
> seq1.len = 0;
> seq1.idxmax = 0;
> seq1.rule = 0;
>
prev parent reply other threads:[~2018-02-26 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 17:41 Fix another -Os strcoll build issue Joseph Myers
2018-02-26 18:08 ` Ping " Joseph Myers
2018-02-26 18:25 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a914b3d-14ff-a2b2-0894-756d2f40d39a@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).