From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C909B1F5AE for ; Thu, 29 Apr 2021 11:43:31 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CDED1395B403; Thu, 29 Apr 2021 11:43:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDED1395B403 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619696609; bh=9n43d1EBlTrQudjrY+FvhkBWgjk1howh0EX1pKBfatU=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=XraPETpRg4C5OZqSN7UGS9HnZ3CQjkMaapW4sneTyVi6unyEfvwhKtu9i4SGK3AxV FR2xOjhSjdmnIdqVCCB1MNhPrd7tPnGY3zAKxiBh52RGCbd5MVd0ppRCAF9+Kv4vhy YEVDlXfL1nB3WcUa/TWfRwOY4XF8FEBkTXF/MiV4= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 71ED5395A00A for ; Thu, 29 Apr 2021 11:43:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 71ED5395A00A Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-496-6jnyOWXSM3ixYEFPRel2jA-1; Thu, 29 Apr 2021 07:43:25 -0400 X-MC-Unique: 6jnyOWXSM3ixYEFPRel2jA-1 Received: by mail-qk1-f197.google.com with SMTP id s10-20020a05620a030ab02902e061a1661fso27690978qkm.12 for ; Thu, 29 Apr 2021 04:43:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=9n43d1EBlTrQudjrY+FvhkBWgjk1howh0EX1pKBfatU=; b=A5mxnKqHXJ/f76odCresepxRkKR/kZaKjrqLQIhZ+Olrlu7EnXDRHmODBq3tqwAm3m FI0Rjgg+qfl4p4Q8dsgAnqurCNhcrgdojVj8GujY7vYkh7jM+p7s57uGiHsF2ThkcW5d opsT4FgmeNhMYsTi5NBiLDd/cTOqyxqV6dd+/GiW805hhkT/+kKtsSpT4KK81nk74zqc 2hc5cMoIJ5DkubZRa7LZpCbwYypMw2vetNbM17Vv6V0dBxNO95YBcL23q8G7ZmP51gR2 V71KP8fng1tjnXwSEIATrQwWaRXsLeJzDbeThe3onwndbbdLD2Iz1GXwS46mGs3YyfqS GqUQ== X-Gm-Message-State: AOAM5312HFRwz0Uf0+ceWjxvK2gMq2dBNGwb+WmVcPi9BboYtGmwNVhN 7ooGm5UX0KAkP/E3KLUyWBloJ/rTm8HvhP5lrmO3rLuPinkIberLlpKCGlquD3QQ28Vy74qJe1i BBUUdeZor6V5Ey4LXLoPXVUKUZp161rKvDV2KYZgjOIJB8OubFyEenf6MzJyZRXy8s00ryw== X-Received: by 2002:ac8:48d4:: with SMTP id l20mr17007648qtr.113.1619696604699; Thu, 29 Apr 2021 04:43:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUwICY+I1m7ozBhxCyTwfTl03U/BPEQBxXtvVb/cxdAlrIT/l+lHrw2oU38hLg/EMFFIE0LA== X-Received: by 2002:ac8:48d4:: with SMTP id l20mr17007633qtr.113.1619696604415; Thu, 29 Apr 2021 04:43:24 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id x7sm1875204qts.42.2021.04.29.04.43.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Apr 2021 04:43:23 -0700 (PDT) Subject: Re: [PATCH v3] Add new C.UTF-8 locale (Bug 17318) To: Joseph Myers References: <20210219032748.564216-1-carlos@redhat.com> <87v99xcxzm.fsf@oldenburg.str.redhat.com> Organization: Red Hat Message-ID: <799656d4-ec84-98f7-8b8a-ca507c707d8c@redhat.com> Date: Thu, 29 Apr 2021 07:43:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Cc: Florian Weimer , Carlos O'Donell via Libc-alpha Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 4/28/21 1:36 PM, Joseph Myers wrote: > On Wed, 28 Apr 2021, Carlos O'Donell via Libc-alpha wrote: > >>>> diff --git a/localedata/locales/i18n_ctype b/localedata/locales/i18n_ctype >>>> index c63e0790fc..c92bb95148 100644 >>>> --- a/localedata/locales/i18n_ctype >>>> +++ b/localedata/locales/i18n_ctype >>>> @@ -26,7 +26,7 @@ fax "" >>>> language "" >>>> territory "Earth" >>>> revision "13.0.0" >>>> -date "2020-06-25" >>>> +date "2021-02-17" >>>> category "i18n:2012";LC_CTYPE >>>> END LC_IDENTIFICATION >>> >>> Those date changes seem spurious. Is this no-op file regeneration >>> really needed? >> >> The protocol is: >> >> cd localedata/unicode-gen >> make install >> >> The spurious regeneration is not needed, but it's easier to run the >> above commands. It gives a date for the last generation for all files >> consistently. > > Is it required to have a date in the file at all? > > For anything that's generated during the glibc build and ends up > installed, we'd avoid having such dates to allow for reproducible builds. > As this is a maintainer generation of something checked in as a source > file, rather than regenerated from makefile dependencies in a normal glibc > build, that doesn't strictly apply, but I still think it would be a good > idea to avoid having dates or other such non-reproducible output in > maintainer-generated files as far as possible. Good point. Let me remove the dates from the generation of files as a first patch. -- Cheers, Carlos.