From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4174F1F44D for ; Wed, 27 Mar 2024 20:39:47 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=uVxTa3p9; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 491FF385DC06 for ; Wed, 27 Mar 2024 20:39:46 +0000 (GMT) Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 804613858D34 for ; Wed, 27 Mar 2024 20:39:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 804613858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 804613858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711571966; cv=none; b=hv1O/iXLiKrtftEThxBtcB/FPim2qVwvXdeIqS2mmruWGI1uKtz/UuOZGWaV0kZSrM/jZ6cAsW7WW/kP1excWX/MpALbji75pS49dfjcT8vmv4qQYSDIL3fbEkd6PLUgQzb9VSBrLj+ji5/Op6Fhb8pVmKjxGSVq3iqaKDO0/4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711571966; c=relaxed/simple; bh=+WYqPaDnvAEwlFF4xba/Iz2GXKM5eRCVNs3Ap9B3pFE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=f3Ye6kKYvM2VYchvh5CTY7eUdx83lbZ0R6lKiY3fG3tCcYnAJQ83nIe1aYR51u/m1b7OaPnnSLKuGf3laxzJrpEdJRiFZ4c369koXW1S9+zA07FIzg8mtkt8jPB0Ylejf/6GvuAO86DSNOcq6g27C01ulLAV4ZSAwOIwFSm+BBQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1e0878b76f3so2497815ad.0 for ; Wed, 27 Mar 2024 13:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711571962; x=1712176762; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=FiN+6EpNSWL+tto14C+BZYKuni7tAYZ2/xToQvQL9FY=; b=uVxTa3p9EB8+7rqXJ+I/TRDGTnw7Ti2daHMeTeNLgdpbwt8IsnT94ZX45/NEsLg+un RQLaobj7wi8me4WZoqv4XtFkk8UrXCXc5rvIJnCjIQ/MBoJ3MNk1d6KcQTRNYNSn7tbA N5TNDNxfR/dFW9n29T3pFbsHHfkBIzTvUh01HfuR7MldPC4yxhxKFh7/Inhdbo9k2r9/ c424hlFQqvu2UZ+0sPolWH1Ouso4U66EoIQGCm4b0GHlpa2cypCqXN+V98YnGJcED+io kelbEGpPLsIiEwzyQkwZjPixdEfCq6SvTyuWvijqlVLQRHwt+nkZQy5DGLmXwqxvssnN GJAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711571962; x=1712176762; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FiN+6EpNSWL+tto14C+BZYKuni7tAYZ2/xToQvQL9FY=; b=bSE/lTkFgwQOYOON8QLG6FYWrV+1fuLwymXfxghnpHkh1bVwfrj0uN5ykQNwXhEp0k 6pkcgeZb8BL8Os3FtELdVdpcxqyrL6Lr+B+aoRcByjMrhxQhKWqMGb8dmoSu8Itwy7F0 8cilR04zRV+zCGDeHO2l4gSVs9NMPdikVGdKz3DUKBmsNGm2OAUAfu1cWijQuFWBcqO7 PklIkP/5g6TLN68EucFmvPUzTWyyp2PVkUkaGBz+hSBeSS0VNPNhJozXol3mLKF0Vgcp XNhQABq+nywW/LquDMVQE2MasZXNIIBIoBgTjykeptYZQ4gIVJabjMpG7oPCNJJoJ1e5 br4A== X-Gm-Message-State: AOJu0Yyxq32DW+seeUPY2p9ECwAWhNGzb7Sxhh+VzqnhV2MHaHfZ9ttY CCCApSOJotc5Knt8fCpQPW2T3IF+bBoW+lDT6gm/xmR60lr/r/qU+XYhGZ/X+70= X-Google-Smtp-Source: AGHT+IGMjL46nyqivg7t5Bd8xvwdDmzK/r7EMNxQfaq+dQwOS8IERWecos90zPmfxXlLnCWstQ6CmQ== X-Received: by 2002:a17:902:e74b:b0:1dd:dcd3:662c with SMTP id p11-20020a170902e74b00b001dddcd3662cmr524253plf.4.1711571962443; Wed, 27 Mar 2024 13:39:22 -0700 (PDT) Received: from [192.168.15.31] ([187.56.129.71]) by smtp.gmail.com with ESMTPSA id w11-20020a170902e88b00b001e0aded0ca7sm8316906plg.239.2024.03.27.13.39.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 13:39:21 -0700 (PDT) Message-ID: <781e8f81-b6a9-4300-9ee2-c44f5a12337e@linaro.org> Date: Wed, 27 Mar 2024 17:39:18 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/10] math: Fix i386 and m68k exp10 on static build To: "H.J. Lu" Cc: libc-alpha@sourceware.org, Joseph Myers , Florian Weimer References: <20240327194024.1409677-1-adhemerval.zanella@linaro.org> <20240327194024.1409677-6-adhemerval.zanella@linaro.org> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On 27/03/24 16:57, H.J. Lu wrote: > On Wed, Mar 27, 2024 at 12:40 PM Adhemerval Zanella > wrote: >> >> The commit 08ddd26814 removed the static exp10 on i386 and m68k with an >> empty w_exp10.c (required for the ABIs that uses the newly >> implementation). This patch fixes by adding the required symbols on the >> arch-specific w_exp{f}_compat.c implementation. >> >> Checked on i686-linux-gnu and with a build for m68k-linux-gnu. >> --- >> math/Makefile | 4 +++- >> sysdeps/i386/fpu/w_exp10_compat.c | 9 +++++++-- >> sysdeps/m68k/m680x0/fpu/w_exp10_compat.c | 9 +++++++-- >> 3 files changed, 17 insertions(+), 5 deletions(-) >> >> diff --git a/math/Makefile b/math/Makefile >> index 964bf2be71..f1d210797d 100644 >> --- a/math/Makefile >> +++ b/math/Makefile >> @@ -367,7 +367,9 @@ $(libm-test-c-narrow-obj): $(objpfx)libm-test%.c: libm-test%.inc \ >> $(PYTHON) gen-libm-test.py -c $< -a auto-libm-test-out$* -C $@ >> >> >> -libm-test-funcs-auto-static = >> +libm-test-funcs-auto-static = \ >> + exp10 \ >> + # libm-test-funcs-auto-static > > This doesn't provide confidence that static libm issues are fixed. > I think we should add a configure option to enable static tests for > all libm functions. This fixes the issue for exp10 symbol and checks that it can be used on static build for all supported type, which is the purpose of this fix. I do think the testing all static symbol with extra testing are valuable, but I also think it should be done in a different patch/thread. > >> libm-test-funcs-noauto-static = \ >> fmod \ >> # libm-test-funcs-noauto-static >> diff --git a/sysdeps/i386/fpu/w_exp10_compat.c b/sysdeps/i386/fpu/w_exp10_compat.c >> index b53455386e..49a0e03385 100644 >> --- a/sysdeps/i386/fpu/w_exp10_compat.c >> +++ b/sysdeps/i386/fpu/w_exp10_compat.c >> @@ -1,3 +1,8 @@ >> /* i386 provides an optimized __ieee754_exp10. */ >> -#define NO_COMPAT_NEEDED 1 >> -#include >> +#ifdef SHARED >> +# define NO_COMPAT_NEEDED 1 >> +# include >> +#else >> +# include >> +# include >> +#endif >> diff --git a/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c b/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c >> index 0d3e718626..350f2e4b4d 100644 >> --- a/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c >> +++ b/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c >> @@ -1,3 +1,8 @@ >> /* m68k provides an optimized __ieee754_exp10. */ >> -#define NO_COMPAT_NEEDED 1 >> -#include >> +#ifdef SHARED >> +# define NO_COMPAT_NEEDED 1 >> +# include >> +#else >> +# include >> +# include >> +#endif >> -- >> 2.34.1 >> > >