From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS,URIBL_BLACK shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1F5371F8C6 for ; Fri, 9 Jul 2021 08:13:56 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 58B3A3889C21 for ; Fri, 9 Jul 2021 08:13:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 58B3A3889C21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625818435; bh=5dfqjcoFMjW5m3tFpgoBcPkaMVYh+QrBUl3Qdr3eVpI=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=CYrGpe2kzhu/uCwfXitJsKpl02g668BsL8lkl2lyD6+0uH9OvHSL85JTBWgm7kVAg 4KRaSKTDEfoaAKmD/GDp4la7w4KDwGnpo2C0tQAzQAcAQxhh3thdi7H3kopf/RSoV6 HbwGugW2gwcGDgSrr88HUPlvOWFn0cvzsSMX+Kxw= Received: from bee.birch.relay.mailchannels.net (bee.birch.relay.mailchannels.net [23.83.209.14]) by sourceware.org (Postfix) with ESMTPS id 855203983804 for ; Fri, 9 Jul 2021 08:13:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 855203983804 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D82FE541C36; Fri, 9 Jul 2021 08:13:22 +0000 (UTC) Received: from pdx1-sub0-mail-a31.g.dreamhost.com (100-96-11-33.trex.outbound.svc.cluster.local [100.96.11.33]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 304EA541353; Fri, 9 Jul 2021 08:13:22 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a31.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.11.33 (trex/6.3.3); Fri, 09 Jul 2021 08:13:22 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Exultant-Whimsical: 37ca369c6bdb8236_1625818402687_348584603 X-MC-Loop-Signature: 1625818402687:2567940682 X-MC-Ingress-Time: 1625818402687 Received: from pdx1-sub0-mail-a31.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTP id D920B852E0; Fri, 9 Jul 2021 01:13:21 -0700 (PDT) Received: from [192.168.1.137] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTPSA id 18C698080F; Fri, 9 Jul 2021 01:13:19 -0700 (PDT) Subject: Re: [PATCH v7 3/8] Move malloc hooks into a compat DSO To: Florian Weimer References: <20210708174325.3243721-1-siddhesh@sourceware.org> <20210708174325.3243721-4-siddhesh@sourceware.org> <87czrrkiyg.fsf@oldenburg.str.redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a31 Message-ID: <74c790ec-1a38-9d1a-142a-4edbec064e47@sourceware.org> Date: Fri, 9 Jul 2021 13:43:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87czrrkiyg.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Siddhesh Poyarekar via Libc-alpha Reply-To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 7/9/21 1:38 PM, Florian Weimer wrote: > * Siddhesh Poyarekar: > >> Remove all malloc hook uses from core malloc functions and move it >> into a new library libc_malloc_debug.so. With this, the hooks now no >> longer have any effect on the core library. >> >> libc_malloc_debug.so is a malloc interposer that needs to be preloaded >> to get hooks functionality back so that the debugging features that >> depend on the hooks, i.e. malloc-check, mcheck and mtrace work again. >> Without the preloaded DSO these debugging features will be nops. >> These features will be ported away from hooks in subsequent patches. >> >> Similarly, legacy applications that need hooks functionality need to >> preload libc_malloc_debug.so. >> >> The symbols exported by libc_malloc_debug.so are maintained at exactly >> the same version as libc.so. >> >> Finally, static binaries will no longer be able to use malloc >> debugging features since they cannot preload the debugging DSO. > > Commit subject could be adjusted because the DSO contains more than just > the hooks. OK, I'll update it to "Introduce malloc debug DSO" > This patch needs to update the shlib-versions file on architectures > which do not use DEFAULT. For example, on ia64-linux-gnu, there is a > malloc/check-abi-libc_malloc_debug failure that looks like this: Thanks, fixed locally. Siddhesh