From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 867941F45F for ; Fri, 10 May 2019 12:20:24 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:from:to:cc:references:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=sl2jCwNtOrKouU5y Y+HjSTFZKwNlzeBmdTs1BoymONi3BjeBj8Tau6yBTTRKLquhdFUVzGqrKXyW7QGh zDOBobbakY9e+UlFPJNYveRz18wWm3lUWcDU/rZ9La3SGVzAloIscj630XEb7KdN rqHKxzqujKveaj8knuWGfWRdRjQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:from:to:cc:references:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=BczuUNqzZN9q1FP4fJK1eN 3iP/U=; b=K8R1LZNgWA9+5RJAgMQsvFedacgYOeZ3Z8ghX/GKy3KDar7eHhSxfA p6mGNNZaQPFjF26bEh25oHgYffvpnS1rJuCzH4zji2F/MURwNwdTsvqtEPoNsJnE oDIM80yfaLAdx5fSh0aHArLsavJArVH1Uq3ulMQUcJclUNPreXmSI= Received: (qmail 20583 invoked by alias); 10 May 2019 12:20:22 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 20572 invoked by uid 89); 10 May 2019 12:20:22 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-ua1-f67.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:from:to:cc:references:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VaXQW/Z8UeI5cJRIjdDFD/aghz7xhvFJlagraDZ4Ghs=; b=Lnw57Hvkq/6XyD7HEpPQkRXfkBhOX0xvpz5HNmsnqxLRNDxQXvDYlZeGc2JEFB4JbB 2fUqy8iAOvwKhTx4AlzT54HEvjJ1tfoliCQ8T9OzrvK/p6yTPOvaKZXxp3q9JMy2ARYo HvA/kfwEKmvfXR6huz3Tn8vAXMQAsrREuORZypBpCH6otIK165RfCnrs5pQEfVLpBckN nINQ4HlL7PTezPBOkO2DYhdHyF6tBC6Wy0zSr2zjcZlgEuNlUhvlKJ5r/hzrXTrZ7Z+T 04XrxaDI86PFZpkeUUsPNFR1+Vg3hHh8voRNrDgnJd3VsUuB3WykmTqgEtfHZuQzvxSl GGTQ== Subject: Re: [PATCH 2/5] nptl: Convert tst-cond11.c to use libsupport From: Adhemerval Zanella To: Joseph Myers Cc: Florian Weimer , libc-alpha@sourceware.org References: <874l63sgh0.fsf@oldenburg2.str.redhat.com> <7ccfbf05-d808-2046-3ed6-f340ab190040@linaro.org> Openpgp: preference=signencrypt Message-ID: <73eb7a6c-88d8-fdda-79f0-ac407a29e352@linaro.org> Date: Fri, 10 May 2019 09:20:16 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 10/05/2019 06:42, Adhemerval Zanella wrote: > > >> Il giorno 9 mag 2019, alle ore 20:03, Joseph Myers ha scritto: >> >>> On Thu, 9 May 2019, Adhemerval Zanella wrote: >>> >>>> On 09/05/2019 14:08, Florian Weimer wrote: >>>> * Adhemerval Zanella: >>>> >>>>>> support/Makefile | 3 +- >>>>>> support/README | 5 +- >>>>>> support/timespec-add.c | 71 ++++++++++++++++++- >>>>>> support/timespec-sub.c | 71 ++++++++++++++++++- >>>>>> support/timespec.c | 58 ++++++++++++++- >>>>>> support/timespec.h | 79 ++++++++++++++++++++- >>>> >>>> Could you push these changes as a separate commit? Thanks. >>>> >>>> Florian >>>> >>> Ok, I will split the patch. >> >> These changes have broken the build for x32, with errors such as: >> >> timespec.c: In function 'test_timespec_before_impl': >> timespec.c:32:23: error: format '%ld' expects argument of type 'long int', but argument 4 has type '__time_t' {aka 'const long long int'} [-Werror=format=] > > I will check this out. > I will check the following patch to fix it: --- diff --git a/support/timespec.c b/support/timespec.c index f1b88c1f4c..653293970a 100644 --- a/support/timespec.c +++ b/support/timespec.c @@ -18,6 +18,7 @@ #include #include +#include void test_timespec_before_impl (const char *file, int line, @@ -29,12 +30,12 @@ test_timespec_before_impl (const char *file, int line, && left.tv_nsec > right.tv_nsec)) { support_record_failure (); const struct timespec diff = timespec_sub (left, right); - printf ("%s:%d: %ld.%09lds not before %ld.%09lds " - "(difference %ld.%09lds)n", + printf ("%s:%d: %jd.%09jds not before %jd.%09jds " + "(difference %jd.%09jds)n", file, line, - left.tv_sec, left.tv_nsec, - right.tv_sec, right.tv_nsec, - diff.tv_sec, diff.tv_nsec); + (intmax_t) left.tv_sec, (intmax_t) left.tv_nsec, + (intmax_t) right.tv_sec, (intmax_t) right.tv_nsec, + (intmax_t) diff.tv_sec, (intmax_t) diff.tv_nsec); } } @@ -48,11 +49,11 @@ test_timespec_equal_or_after_impl (const char *file, int line, && left.tv_nsec < right.tv_nsec)) { support_record_failure (); const struct timespec diff = timespec_sub (right, left); - printf ("%s:%d: %ld.%09lds not after %ld.%09lds " - "(difference %ld.%09lds)n", + printf ("%s:%d: %jd.%09jds not after %jd.%09jds " + "(difference %jd.%09jds)n", file, line, - left.tv_sec, left.tv_nsec, - right.tv_sec, right.tv_nsec, - diff.tv_sec, diff.tv_nsec); + (intmax_t) left.tv_sec, (intmax_t) left.tv_nsec, + (intmax_t) right.tv_sec, (intmax_t) right.tv_nsec, + (intmax_t) diff.tv_sec, (intmax_t) diff.tv_nsec); } ---