From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E140D1F953 for ; Fri, 26 Nov 2021 21:00:04 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 213853857C5E for ; Fri, 26 Nov 2021 21:00:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 213853857C5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637960404; bh=Vn3CiiOnilOKYziy2gmR7+jUPg0Z5M4bljBoRvB2Qz8=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ERsEnTNXPJZ2mb0Aj6NXw+upTTxoXedKLQRObGloaddcpTd19pHeYlHNFK6BnW4h9 Z9AvCcoF45MV7IO3slIEf8aNOzYwwsHQ8tdJeVHQGBOJrhusX9cEAnizbyN+joPEU7 kGBaKfHulkidY5khUMNCVFqHjFkiZtftwoLKyTJs= Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id D9E213857C7B for ; Fri, 26 Nov 2021 20:59:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D9E213857C7B Received: by mail-wr1-x434.google.com with SMTP id c4so21107732wrd.9 for ; Fri, 26 Nov 2021 12:59:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version; bh=Vn3CiiOnilOKYziy2gmR7+jUPg0Z5M4bljBoRvB2Qz8=; b=oBlQHTOU9d9K1l8/rc+Knif0QMdaOTRP1mpaKddwCluOxIGZJRPkCXIFaRRruho5sW Shmf8BXh6jyPQuG2hTma+TNbYDoPpylY0dqgQc7uX6nkBroQcJ584A9TROUJPfsk3sdz Of6er7cRzA667FgzLv2zX9nfViBYJr4ECrPnNes9698e7cVGHO6jUzDKgYcLUu60d1kl /piTnIxhXeZuv9bK3hbmM/evvEM1Mis4Ap//EL2uO1IXyfEmMdIo0gYDFOl6xzFIFW0V NQ8iil564QcV9wSofAVdy7tp60U6WK+odU2mCLXrU5JyHGAZPhSQL8GZaRNZ5dDlpkIe xCkA== X-Gm-Message-State: AOAM532tRUEC5Sm5Z+OfN1onRyAc9sUyqehtJG+qk1dW8rMn5vy3e7Rw oU5TMvm6Fnq33UNnPzUG7+Q= X-Google-Smtp-Source: ABdhPJyDZ6CvtBzQ7mQPtKwMQGosGI7Gnm4XXUTCcdbMxvJFvkG6+9bCpJA25ZwNvEGEprk0EPy9Wg== X-Received: by 2002:adf:e0c7:: with SMTP id m7mr16790694wri.530.1637960376622; Fri, 26 Nov 2021 12:59:36 -0800 (PST) Received: from ?IPv6:2a01:4b00:f41a:3600:df86:cebc:8870:2184? ([2a01:4b00:f41a:3600:df86:cebc:8870:2184]) by smtp.googlemail.com with ESMTPSA id h2sm6288434wrz.23.2021.11.26.12.59.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 12:59:35 -0800 (PST) Message-ID: <72dca5034b7c5a7e5aaf26a8d964a88ead50fa54.camel@gmail.com> Subject: Re: [PATCH v2] elf: add definition for NT_FDO_PACKAGING_METADATA note To: Florian Weimer Date: Fri, 26 Nov 2021 20:59:34 +0000 In-Reply-To: <87h7byirw4.fsf@oldenburg.str.redhat.com> References: <20211121193939.105186-1-luca.boccassi@gmail.com> <20211126170127.1075409-1-luca.boccassi@gmail.com> <87h7byirw4.fsf@oldenburg.str.redhat.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-es7bTxqsDgtdCRyaVo49" User-Agent: Evolution 3.42.1-1 MIME-Version: 1.0 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luca Boccassi via Libc-alpha Reply-To: Luca Boccassi Cc: mark@klomp.org, libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" --=-es7bTxqsDgtdCRyaVo49 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2021-11-26 at 21:27 +0100, Florian Weimer wrote: > * luca boccassi: >=20 > > From: Luca Boccassi > >=20 > > As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/ > > this note will be used starting from Fedora 36. > >=20 > > Signed-off-by: Luca Boccassi > > --- > > v2: as suggested by Mark, indent comment and add NT_ suffix > >=20 > > =C2=A0elf/elf.h | 4 ++++ > > =C2=A01 file changed, 4 insertions(+) > >=20 > > diff --git a/elf/elf.h b/elf/elf.h > > index 50f87baceb..f2b72bd9f5 100644 > > --- a/elf/elf.h > > +++ b/elf/elf.h > > @@ -1302,6 +1302,10 @@ typedef struct > > =C2=A0/* Program property.=C2=A0 */ > > =C2=A0#define NT_GNU_PROPERTY_TYPE_0 5 > > =C2=A0 > > +/* Packaging metadata as defined on > > +=C2=A0=C2=A0 https://systemd.io/COREDUMP_PACKAGE_METADATA/=C2=A0*/ > > +#define NT_FDO_PACKAGING_METADATA 0xcafe1a7e > > + > > =C2=A0/* Note section name of program property.=C2=A0=C2=A0 */ > > =C2=A0#define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property" >=20 > Would you please add a definition of ELF_NOTE_FDO earlier in the > file, > similar to ELF_NOTE_GNU? >=20 > I would like to point out that the format of the note is JSON- > encoded, > so it's not really how we have done things so far in the GNU ABI.=C2=A0 I > guess we can add this as a one-off exception.=C2=A0 It shouldn't be an > example where things are supposed to go in the future. >=20 > Thanks, > Florian Sent v3 as suggested, thanks. --=20 Kind regards, Luca Boccassi --=-es7bTxqsDgtdCRyaVo49 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEE6g0RLAGYhL9yp9G8SylmgFB4UWIFAmGhSrYACgkQSylmgFB4 UWJ9lgf+LNn8dRnU4imzynPzxUlDgYZoC9iWS8odjVQBWoaML5AQt0JiX1pSxMdO 0ABMi5H4ZH6Kw0mW/tcNy5Rp3sbs6fhPTbcsaxP85zzSqaVVod73H5idydCBybwZ vHiglwbcZOLNfte/5F7Emz3RiMbi6XF9oxmXHibWsXRC/jMUgwv86Frtai9Zl8gM dJiSXw3a3VTSrif+TGNDGLK40e9brAHG/NIEITiNh4821wxJYwNA3xSUxdRswezh E6qA/KIeMyOx1P5awbMA4DlFTc2MT3kzrD2m/bOO2tMy/+WuHcWa3EO1S9hpaIgU c4ldgwur9wLZlMvqcYpxdXTybP8DLg== =2bEj -----END PGP SIGNATURE----- --=-es7bTxqsDgtdCRyaVo49--