From: Mathieu Desnoyers via Libc-alpha <libc-alpha@sourceware.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: Rich Felker <dalias@libc.org>,
libc-alpha <libc-alpha@sourceware.org>,
linux-api <linux-api@vger.kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ben Maurer <bmaurer@fb.com>, Dave Watson <davejwatson@fb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Paul <paulmck@linux.vnet.ibm.com>, Paul Turner <pjt@google.com>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: [RFC PATCH glibc 1/3] glibc: Perform rseq(2) registration at C startup and thread creation (v18)
Date: Thu, 30 Apr 2020 13:20:03 -0400 (EDT) [thread overview]
Message-ID: <729499446.78182.1588267203324.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <874kt0lx6i.fsf@oldenburg2.str.redhat.com>
----- On Apr 30, 2020, at 1:07 PM, Florian Weimer fweimer@redhat.com wrote:
[...]
> __libc_fatal does not attribute the error to glibc, so I suggest to
> start the error messages with “glibc fatal error: ”, so that people know
> where to look.
OK. Is there a strict requirement on limiting to 80 columns for code
including an error message string in glibc ? IOW:
if (__rseq_abi.cpu_id != RSEQ_CPU_ID_UNINITIALIZED)
__libc_fatal ("glibc fatal error: rseq already initialized for this thread\n");
or
if (__rseq_abi.cpu_id != RSEQ_CPU_ID_UNINITIALIZED)
__libc_fatal ("glibc fatal error: "
"rseq already initialized for this thread\n");
?
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2020-04-30 17:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 17:15 [RFC PATCH glibc 1/3] glibc: Perform rseq(2) registration at C startup and thread creation (v18) Mathieu Desnoyers via Libc-alpha
2020-04-28 17:15 ` [RFC PATCH glibc 2/3] glibc: sched_getcpu(): use rseq cpu_id TLS on Linux (v7) Mathieu Desnoyers via Libc-alpha
2020-04-28 17:15 ` [RFC PATCH glibc 3/3] rseq registration tests (v10) Mathieu Desnoyers via Libc-alpha
2020-04-30 12:20 ` [RFC PATCH glibc 1/3] glibc: Perform rseq(2) registration at C startup and thread creation (v18) Florian Weimer via Libc-alpha
2020-04-30 16:11 ` Mathieu Desnoyers via Libc-alpha
2020-04-30 16:36 ` Florian Weimer via Libc-alpha
2020-04-30 16:55 ` Mathieu Desnoyers via Libc-alpha
2020-04-30 17:07 ` Florian Weimer via Libc-alpha
2020-04-30 17:20 ` Mathieu Desnoyers via Libc-alpha [this message]
2020-04-30 17:46 ` Florian Weimer via Libc-alpha
2020-04-30 19:39 ` Mathieu Desnoyers via Libc-alpha
2020-04-30 19:53 ` Mathieu Desnoyers via Libc-alpha
2020-04-30 19:59 ` Mathieu Desnoyers via Libc-alpha
2020-04-30 20:34 ` Florian Weimer via Libc-alpha
2020-04-30 20:37 ` Mathieu Desnoyers via Libc-alpha
2020-04-30 20:37 ` Florian Weimer via Libc-alpha
2020-04-30 20:39 ` Mathieu Desnoyers via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=729499446.78182.1588267203324.JavaMail.zimbra@efficios.com \
--to=libc-alpha@sourceware.org \
--cc=bmaurer@fb.com \
--cc=boqun.feng@gmail.com \
--cc=dalias@libc.org \
--cc=davejwatson@fb.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).