From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5EDE51F910 for ; Fri, 25 Nov 2022 02:37:40 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 28B713889E1E for ; Fri, 25 Nov 2022 02:37:39 +0000 (GMT) Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 8CA75385842D for ; Fri, 25 Nov 2022 02:37:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8CA75385842D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [125.69.28.136]) by gateway (Coremail) with SMTP id _____8DxfetjKoBj_c0AAA--.2084S3; Fri, 25 Nov 2022 10:37:23 +0800 (CST) Received: from [192.168.1.6] (unknown [125.69.28.136]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxtuNiKoBjWdsZAA--.1546S3; Fri, 25 Nov 2022 10:37:23 +0800 (CST) Subject: Re: [PATCH] LoongArch: Add syscall.c for getting correct return value To: Adhemerval Zanella Netto , Xi Ruoyao Cc: libc-alpha@sourceware.org, i.swmail@xen0n.name, caiyinyu@loongson.cn, wanghongliang@loongson.cn, hejinyang@loongson.cn References: <20221123015711.707809-1-lixing@loongson.cn> <95f208a9-92aa-bf29-036e-5ae7a4556195@linaro.org> From: XingLi Message-ID: <724989a8-57c4-48b8-da1e-5516d894316e@loongson.cn> Date: Fri, 25 Nov 2022 10:37:22 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <95f208a9-92aa-bf29-036e-5ae7a4556195@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf8BxtuNiKoBjWdsZAA--.1546S3 X-CM-SenderInfo: pol0x03j6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBjvdXoWrtr4UKFWkGr48urWUCF1kuFg_yoWxKrg_Wr yIvr17G34UXr4xJFs2qFyFv39rKryUt34xC3s3WrWfWF13trZ7GrnIvr9xWFn7Ja10grWU uw4kZrWxWF1Y9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8wcxFpf9Il3svdxBIdaVrn0 xqx4xG64xvF2IEw4CE5I8CrVC2j2Jv73VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUY c7kC6x804xWl14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3w AFIxvE14AKwVWUXVWUAwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK 6xIIjxv20xvE14v26r1j6r1xM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r1j6r4UM28EF7 xvwVC2z280aVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8JVW8Jr1le2I2 62IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4xG64xvF2IEw4 CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4UMcvj eVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487MxAIw2 8IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4l x2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrw CI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI 42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z2 80aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxU70PfDUUUU X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" 在 2022/11/23 下午9:36, Adhemerval Zanella Netto 写道: > > > On 23/11/22 00:40, Xi Ruoyao wrote: >> On Wed, 2022-11-23 at 09:57 +0800, Xing Li wrote: >>> The __SYS_mmap syscall should return 47bits value. If we use >>> the common syscall interface which defined in >>> sysdeps/unix/sysv/linux/syscall.c, the syscall return value >>> is 32bits with sign extend, which lead to mmap failure. >> >> Could we just change >> >> int r = INTERNAL_SYSCALL_NCS_CALL (number, a0, a1, a2, a3, a4, a5); >> >> in sysdeps/unix/sysv/linux/syscall.c to "long r = ..." instead? >> > > Yes, afaik INTERNAL_SYSCALL_NCS on all architecture returns long int. > Yes, the __SYSCALL_DEFINEx all returns long in linux kernel.