From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 01F581F44D for ; Tue, 19 Mar 2024 23:51:07 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=hi4pZncH; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5113C3858420 for ; Tue, 19 Mar 2024 23:51:05 +0000 (GMT) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 0CC7C3858D37 for ; Tue, 19 Mar 2024 23:50:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CC7C3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0CC7C3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710892239; cv=none; b=rEXBglnvZahtHKTEnaDB0pGWBbSimCGvabOAPfeoAdUJQuiZl+u7KfxBofDY4/+PWmIcx7KmCudjOZtr4XqCzI6m0xn3KIUb3enx4z0Jrl1jfAnvWYsXvOH1nDAh/1JcR+w0tq0wWgBi4Type5t+VsS5yvEfaymqiJ2EPMjW5zU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710892239; c=relaxed/simple; bh=YljL8uQ9aLkO+YwZfNthzjKH3a8CnwqGzv/XBphrvTg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=HdAFlL0stNGuraPiKgnOmeon8qj2pJvqO1NZ6sNTyWZmaogY7S0arK0xL/vjT4Rwnidvh749/Aq3K0265Of9qj3+aZgk0GqL+KQcSm5A3DiNm6ka9zCcnEu7xm6bpkPWpEB5SH2Pfy0Kdt4PkessJ+jYaegUJOm9VO8dkv+xy+Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42JNo2Ww003238 for ; Tue, 19 Mar 2024 23:50:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=cu+IEGYKidN2RJXUpEbs4UrvJzKl9zUhbjda0+BFtTE=; b=hi4pZncHNGLQgUEQfCslz0eK/75hwLIemcXEphMdzbGnZCl8GRultpLuUG/RbnQl5Pip aaxblgqmUWMRiE32/n329wnQefoIi/R1fswfB+Uxsr4b+kpKZU098W7ERiLVq/vZkREj bZUe5hKhgXFhU9sde2JbepENxyDCuND2Ncq8q/gXIoEElm54N8O/mI004zDmCCFII8P+ uWj4hcsGeBomnKMV5KN3SuoTlbQA40CU5eTChKAfLC57bJy19AY6xqWvEe2Xt8wSUHTl WU4Rm7LhSmY23+1djv6xYUfSUzC03NCf6N+3JGKHXsYBNh1n1T6WCYJ1MwC6/7i/Tjym Nw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wykvjg2y3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 19 Mar 2024 23:50:36 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 42JNoaCD004353 for ; Tue, 19 Mar 2024 23:50:36 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wykvjg2y2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Mar 2024 23:50:36 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42JMniEP011606; Tue, 19 Mar 2024 23:50:35 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3wwq8m2rfr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Mar 2024 23:50:35 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42JNoWbr25952860 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Mar 2024 23:50:34 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 035355805B; Tue, 19 Mar 2024 23:50:32 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8296558059; Tue, 19 Mar 2024 23:50:31 +0000 (GMT) Received: from [9.61.153.201] (unknown [9.61.153.201]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 19 Mar 2024 23:50:31 +0000 (GMT) Message-ID: <6fa85026-e0cf-4d9b-b65e-2d24c85be366@linux.ibm.com> Date: Tue, 19 Mar 2024 18:50:31 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] powerpc: Add HWCAP3/HWCAP4 data to TCB for Power Architecture. Content-Language: en-US From: Peter Bergner To: Manjunath Matti , libc-alpha@sourceware.org Cc: fweimer@redhat.com References: <20231205123848.2505641-1-mmatti@linux.ibm.com> <20231205123848.2505641-2-mmatti@linux.ibm.com> <8c5c3b9d-30d5-47b6-8da2-3aca0d9a5d22@linux.ibm.com> In-Reply-To: <8c5c3b9d-30d5-47b6-8da2-3aca0d9a5d22@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Fjt55WYDEqRqiZYAT6-D_XGB1wh3Qkcf X-Proofpoint-ORIG-GUID: NjvNgZ1U3qzMwDytkzmlkHC_dVsqjqcR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-19_10,2024-03-18_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 clxscore=1015 impostorscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2403140000 definitions=main-2403190184 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On 12/13/23 5:47 PM, Peter Bergner wrote: > On 12/5/23 6:38 AM, Manjunath Matti wrote: >> This patch adds a new feature for powerpc. In order to get faster >> access to the HWCAP3/HWCAP4 masks, similar to HWCAP/HWCAP2 (i.e. for >> implementing __builtin_cpu_supports() in GCC) without the overhead of >> reading them from the auxiliary vector, we now reserve space for them >> in the TCB. >> >> This is an ABI change for GLIBC 2.39. >> >> Suggested-by: Peter Bergner >> --- >> elf/dl-diagnostics.c | 2 + >> elf/dl-support.c | 2 + >> elf/elf.h | 4 ++ >> sysdeps/generic/ldsodefs.h | 2 + >> sysdeps/powerpc/dl-procinfo.c | 6 ++- >> sysdeps/powerpc/dl-procinfo.h | 52 +++++++++++++------ >> sysdeps/powerpc/hwcapinfo.c | 11 ++-- >> sysdeps/unix/sysv/linux/dl-parse_auxv.h | 2 + >> sysdeps/unix/sysv/linux/dl-sysdep.c | 2 + >> .../unix/sysv/linux/powerpc/cpu-features.c | 2 + >> .../unix/sysv/linux/powerpc/cpu-features.h | 2 + >> sysdeps/unix/sysv/linux/powerpc/libc-start.c | 6 +++ >> 12 files changed, 74 insertions(+), 19 deletions(-) > > LGTM. The only catch is that this patch is dependent on the associated > kernel patch that adds the AT_HWCAP3 and AT_HWCAP4 getting upstream so > glibc can rely on their values. I'm still working on upstreaming that. The kernel patch this is dependent on has finally reached Linus's tree, so I have pushed this patch. Peter