From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 76FF620248 for ; Wed, 17 Apr 2019 17:08:56 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=ftRjm89lPpbpP94Z Pj7oOTzXriWOo0vkukA6ff3fWPdru0+B7yfpal1Ll2gUPZhdsXmbyVrkJKBBuiOV tfdFnacdQMM7nIGJXSu+/WuLqk3PQFXN4CqmAltPDjCR+U+YQ3d6JlMEADoUSeNG KwAnhmWUuM/mpKPBchldg4zjXfA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=5igIWuXX9lxJ/kUcBjwap5 NysRg=; b=Ho1H6voguhizoaTvkHEz9c1QhXVbthXbUzxDyOXT2ygXNq/BsVw9fR iBxbLWlOsT7m4j/1NKo+EBzJ3O04ZYnyZ1VWZNqlw3453fR+Ten0kEE6lLC9v8jq ZlnQCYjlipYhf9gfVRXgzpo4pi7EZltVRdWsNmx1V62pMvoXE6uQQ= Received: (qmail 27896 invoked by alias); 17 Apr 2019 17:08:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 27888 invoked by uid 89); 17 Apr 2019 17:08:54 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-vk1-f194.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6Cm0QGwNpuYYmvD1CJ4ufhQNY+7Jvi5DuADXx7V9tTE=; b=Cf2uDhoB5YtSsEkArvNWmbFyYXMJKRczPSxxGP6B+7sETWgT/9HQIedvo0UoS3M58Z jJqUuSey7v3YFZl7r1hAEb551JiVv2bpXPR/LB5rN3dzWrn4lLfbNKWFtRbeQFWxOoas 8SOQnJzVvA+oGKm0eJIryg3Lkxvnp6UMOt5swljsL3eElViGjZM98xUaGl/HRHecfZWm beO/KkUETr4x8I+IZMKzKt45H1mB2XyiQI2Chkfw40nCdITPQB7BMuoLz8gprVVlwHjN aYSG8gnaSBDyWhQcQlXbJU6Xg4H+m3lgfk1nW2lXArVaXlF6HPqDfbbfB1wqUIkcDavB +9Mg== Subject: Re: [PATCH 01/28] powerpc: Use generic fabs{f} implementations To: Tulio Magno Quites Machado Filho , "Gabriel F. T. Gomes" Cc: Joseph Myers , libc-alpha@sourceware.org References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-2-adhemerval.zanella@linaro.org> <20190415202356.7cltpw3akrcxjv6e@tereshkova> <87d0ln2bv4.fsf@linux.ibm.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: <6e9154ce-241c-5d9c-c961-8ec042bf141d@linaro.org> Date: Wed, 17 Apr 2019 14:08:47 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87d0ln2bv4.fsf@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 15/04/2019 18:32, Tulio Magno Quites Machado Filho wrote: > "Gabriel F. T. Gomes" writes: > >> The code generated by these functions is as follows (on powerpc64le): >> >> Before the patch: >> 000000000004dac0 : >> 4dac0: 0e 00 4c 3c addis r2,r12,14 >> 4dac4: 40 9b 42 38 addi r2,r2,-25792 >> 4dac8: 10 0a 20 fc fabs f1,f1 >> 4dacc: 20 00 80 4e blr >> >> After the patch: >> 000000000004dac0 : >> 4dac0: 10 0a 20 fc fabs f1,f1 >> 4dac4: 20 00 80 4e blr > > This is showing that __fabs could have been using ENTRY_TOCLESS instead of > ENTRY. ;-) > And another point try use C implementation where possible (since it abstracts that kind of possible ABI issues) ;)