From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 73A141F4B4 for ; Fri, 9 Oct 2020 14:05:55 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4D739385702E; Fri, 9 Oct 2020 14:05:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D739385702E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1602252354; bh=LYNPC0dFlgdRuu5cjqYIhrmRwmQ31PQlLTapKjc0PnA=; h=To:References:Subject:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rB7jajJ5eT88QFL0NIdgnxlk1XrmuwT1kkoxIgGFaMo0xZV9+3Oo/W7/V9mN4EhK5 RGUmK3sJup4g/SY5wlS2POkKw1jmoYoJdiqcu6R0kdjTffG7SoLXzKp/1xigMFzf8C OyYUmpMKwv/WcxZJr5xFc0pJyowLXwmUTDeYy9tE= Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) by sourceware.org (Postfix) with ESMTPS id 52DA73857C55 for ; Fri, 9 Oct 2020 14:05:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 52DA73857C55 Received: by mail-qv1-xf44.google.com with SMTP id w5so4794870qvn.12 for ; Fri, 09 Oct 2020 07:05:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to; bh=LYNPC0dFlgdRuu5cjqYIhrmRwmQ31PQlLTapKjc0PnA=; b=Wh8Z9/9xJhl/Ca5kWFrOpR1bVyc+8jhhlQLVZh30srpTusUsSiEcG0Lt59GxX0xY2r pZmmXz/NRE1g7z9h6dwMF6SbD5J3V738a6aYbOdG67Nj8bzjFsa2jgVxpJfmFZUi+m01 R36w8/rmDzmbzpCopZcUUINVhFRL3nTHNk4xkmmwIcJxAwkxDthU82tev+TKbnkYuUiC 1RnkqRq5vXqqfZUuvamwdELXocuJg/qU/v62cd8fFN7Z2Fk2yspKMkJDz1rpDVLR+xHN MKp3BR3xMYbwVuNOq7dmZe1AKmfYXOgaHnwHNnXUpYnNPardzo3J4O5yaQDOzUsTW2cD X/mQ== X-Gm-Message-State: AOAM533Xp69OuJdcyeZiL4P7ITvrwOC+toFnwlVVinMpYarQ1chA3A/q G8RZoF0IFZ7IF92uH6x30GBhl0zmswVZGg== X-Google-Smtp-Source: ABdhPJx1Fd4oqGoHKOVKCd1Ls4srr2DIg2v4yvWKLIPf1r2L4n5Dlncbe8f7wZyBnHkte+dKc7NN/g== X-Received: by 2002:a0c:8e07:: with SMTP id v7mr13203630qvb.16.1602252349694; Fri, 09 Oct 2020 07:05:49 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id o4sm6480471qko.120.2020.10.09.07.05.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Oct 2020 07:05:48 -0700 (PDT) To: Lukasz Majewski References: <20200723194641.1949404-1-adhemerval.zanella@linaro.org> <20200723194641.1949404-16-adhemerval.zanella@linaro.org> <20201006114802.1450d29b@jawa> <99a35800-d0ed-5561-b36b-4416f041ab5d@linaro.org> <331ab260-ef82-8e94-7148-5522fdb6e195@linaro.org> <04ea13cc-5d00-fb13-9ff6-68645620d5b0@linaro.org> <20201008095748.1d3d7226@jawa> Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH 15/16] linux: Add {f}stat{at} y2038 support Message-ID: <6c95d492-4ca2-bec8-eb25-1095d190d462@linaro.org> Date: Fri, 9 Oct 2020 11:05:45 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201008095748.1d3d7226@jawa> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RAV7F3PVFJW8I6LhFFsesrs4fhncSylih" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Cc: Alistair Francis , libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RAV7F3PVFJW8I6LhFFsesrs4fhncSylih Content-Type: multipart/mixed; boundary="8VSm4vC2mSA1Md4C4YmL5fuo3ZICtWuud"; protected-headers="v1" From: Adhemerval Zanella To: Lukasz Majewski Cc: libc-alpha@sourceware.org, Alistair Francis Message-ID: <6c95d492-4ca2-bec8-eb25-1095d190d462@linaro.org> Subject: Re: [PATCH 15/16] linux: Add {f}stat{at} y2038 support References: <20200723194641.1949404-1-adhemerval.zanella@linaro.org> <20200723194641.1949404-16-adhemerval.zanella@linaro.org> <20201006114802.1450d29b@jawa> <99a35800-d0ed-5561-b36b-4416f041ab5d@linaro.org> <331ab260-ef82-8e94-7148-5522fdb6e195@linaro.org> <04ea13cc-5d00-fb13-9ff6-68645620d5b0@linaro.org> <20201008095748.1d3d7226@jawa> In-Reply-To: <20201008095748.1d3d7226@jawa> --8VSm4vC2mSA1Md4C4YmL5fuo3ZICtWuud Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 08/10/2020 04:57, Lukasz Majewski wrote: > Hi Adhemerval, >=20 >> On 07/10/2020 11:25, Adhemerval Zanella wrote: >>> >>> >>> On 07/10/2020 09:52, Adhemerval Zanella wrote: =20 >>>> >>>> >>>> On 06/10/2020 06:48, Lukasz Majewski wrote: =20 >>>>> Hi Adhemerval, >>>>> =20 >>>>>> A new struct __stat{64}_t64 type is added with the required >>>>>> __timespec64 time definition. Both non-LFS and LFS support were >>>>>> done with an extra __NR_statx call plus a conversion to the new >>>>>> __stat{64}_t64 type. The statx call is done only for >>>>>> architectures with support for 32-bit time_t ABI. >>>>>> >>>>>> Internally some extra routines to copy from/to struct stat{64} >>>>>> to struct __stat{64} used on multiple implementations (stat, >>>>>> fstat, lstat, and fstatat) are added on a extra file >>>>>> (stat_t64_cp.c). Aslo some extra routines to copy from statx to >>>>>> __stat{64} is added on statx_cp.c. >>>>>> >>>>>> Checked with a build for all affected ABIs. I also checked on >>>>>> x86_64, i686, powerpc, powerpc64le, sparcv9, sparc64, s390, and >>>>>> s390x. =20 >>>>> >>>>> When do you plan to pull this patch set to -master? >>>>> Those patches have been available for review on the mailing list >>>>> for more than two months now. =20 >>>> >>>> Hi Lukasz, thanks to remind me. I will rebase against master and >>>> run some regressions tests against some platforms and push it. >>>> =20 >>> >>> One required change with the rebase is adapt the riscv32 ABI to >>> exclude the __{f,l}xstat{at} symbol and replace with proper >>> {f,l}stat ones. It is possible because the new ABI was added on >>> current development branch, however one minor inconvenient is the >>> toolchain need to be rebuild with a updated glibc branch to avoid >>> linking failures with libstd++ (which uses __{f,l}xstat{at}). >>> =20 >> >> Ok, I have ran the testsuite on x86_64, x32, i686, aarch64, armhf, >> powerpc, powerpc64, powerpc64le, sparc64, sparcv9, s390x, and s390 >> without regression. I will just finish the testing on mips, mips64, >> and alpha since they require some specific implementations. >> >=20 > That would be a huge step forward. >=20 > According to list in the following commit message: > https://github.com/lmajewski/y2038_glibc/commit/73215359e184d96b415e87b= 585a4396b5bd0936c The mips testing caught an issue on where the "linux: Disentangle=20 fstatat from fxstatat" patch uses INTERNAL_SYSCALL_CALL where it should use INLINE_SYSCALL_CALL (which sets the errno). I have fixed and this only affects mips, so my testing should cover all the affects architectures (I got access to a ia64 machine again and I will run a regression test once I commit this to master). >=20 > Then I will send an RFC for enabling support for 64 bit time on > eligible architectures. There still some missing implementations I have on my local tree: 1. wait3: it is a straightforward fix since it just calls __wait4_time64= =2E 2. ftime: we need to move it to a compatibility symbol, so there will be no need to add a time64 variant to support the deprecated symbol. 3. futimesat: we need to remove the implementation on generic folder and handle UTIME_NOW and UTIME_OMIT correctly. 4. recvvmsg/recvmsg: we need to handle ancillary data. I recently send patch that tries to handle it [1] [2] [3]. It is more in a RFC and I don't think it is strictly necessary. 5. utmp/utmpx/lastlog: I also sent a fix to handle the 64-bit support on this [4] I will send 1. 2. 3., since they are the easiest one to review. [1] https://sourceware.org/pipermail/libc-alpha/2020-September/117484.htm= l [2] https://sourceware.org/pipermail/libc-alpha/2020-September/117485.htm= l [3] https://sourceware.org/pipermail/libc-alpha/2020-September/117486.htm= l [4] https://sourceware.org/pipermail/libc-alpha/2020-August/116850.html --8VSm4vC2mSA1Md4C4YmL5fuo3ZICtWuud-- --RAV7F3PVFJW8I6LhFFsesrs4fhncSylih Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEUMEGt8/rO2QSpplaqrHsFKeUiO8FAl+AbjkACgkQqrHsFKeU iO/kPQ/+NQ0KEEJ9daFqTdnOAszLlTi9XOSde0eGVohM0D7uYivI5MpOlUZYjykf NVFz1m3mdskIMp9irWhYrkqXaU9CHDYFI6AwwFI9Q/dtX4xysEkPD2MN+Fi8ZK91 vPlONJm7iiyRaa4e8YUsPSxBG9V+VEYn4aF1K/8EC+oA/A6131hQmM+MyOQPCDNY SPcO9PRPNhRm8m/ZVZyNwRGWz2GF3YwJc1eczg4XV7lQv/RBVsaOmEOWhGExoiFf /Wt5i6N1dFpASHQ73Wcv65vlUpCsnwi/Yz5arvMK8VKtky/y1ZAld84JKSs8k3nv 7D3EgB5MDaXZu5QOLHKHUUBNXh0jmYh04I2EYb9QtqtlUI4FEgzXD4QT5+IgCAUA ext3OFubzDCTKEgBji3VME42A5ZHMTImVRqmUZpThQvIILy5+xN2x0XsQIMBFq2A MvZ8ciXHN3jDJYNcST1z88BQSRAkLjbFuE5Po+K6cDUqKTcCpk2ipyEWzPiYqwZN 3EbFN+XOj6936wLJC/VS2hX5VchkFgOVSe6DsyrBMFhFkr4bf+REHs74wDqR1avz XksaeNj5KI87i9QL9s+64HsokGnStScwGlN0JyJD+YXDpkfo9et9aCBVlKDCKu+3 kTGzqpOJ4CX1hJ5aveKQYlvmTocdzE+71Nwd2rhLe7DzuqjLJsI= =s8B9 -----END PGP SIGNATURE----- --RAV7F3PVFJW8I6LhFFsesrs4fhncSylih--