From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 419F71F47C for ; Wed, 11 Jan 2023 21:27:25 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=LKIdQOjJ; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C71F03857BB3 for ; Wed, 11 Jan 2023 21:27:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C71F03857BB3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673472444; bh=v58CnZJPBlW7rZuY6quPXaz52GbvoC4pAPtLT3OGvvo=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=LKIdQOjJmxxyCxDUID+HD5AIrShj+MT2CPiUP6TNrp0e4rPUGe5LzQz3MJFyPFzqk XHwMmxOdITtDUt3Y7tVOD8YCUjiPqaLoI/nNOTRmah1BNas1Sxfb+z24/oZp1meOPg CDEfHKwEII+OU0mLfV28zSJyYz9XSrMJ7I8kOrbE= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 021CD3858C83 for ; Wed, 11 Jan 2023 21:27:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 021CD3858C83 Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-80-7fhJGezyML-OOItCDaKXXw-1; Wed, 11 Jan 2023 16:27:04 -0500 X-MC-Unique: 7fhJGezyML-OOItCDaKXXw-1 Received: by mail-io1-f72.google.com with SMTP id q21-20020a6bf215000000b006f305924242so9841575ioh.9 for ; Wed, 11 Jan 2023 13:27:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v58CnZJPBlW7rZuY6quPXaz52GbvoC4pAPtLT3OGvvo=; b=n71XZjaCr8KUGQetpCT1PJFeNxRVrzJ0ntVrtWmlUYXhzLAuQz9TghTci2HVZC2/QJ GO6lGEN6YlN/VfbY0E2HzqWrw2HhgZgjkVGo+vWt6MpuJtRBdBQ62Edgi5iqne7/5s5s lEw9sfv3dsVWnxLCe8pbfntjaQDRPG7if+WkXbhpIJU1GZbW0pxOzqRSX/v8CGIzsGbF JfQimMgDSq3N8MzGk27Cno/2fBq/tPG3BBjMthZYQljAxQ3DdUE0iScYRWlLUAJWVZ3I 9dIHKR4C2Pl+C0eqFagq1o32FyxaW+I0svOOZGCrnQQ/cV0fFNvQXNqEYTKuGWA5J5ZQ RSdA== X-Gm-Message-State: AFqh2kpwvzDNL4i2/hNF65Tv6B2vXGnoPWKxBPsAN6iiz+vvak78mpTv 1D2OgvvUcthsVCSPdK07EcKhHzuWNrbboUhl8riv+5JBCdw9dqKImQb0oel6Le6naIiwD+Zk4O/ p74m9HDfmpBSWxagTCZr7 X-Received: by 2002:a5d:88c4:0:b0:704:7066:9aec with SMTP id i4-20020a5d88c4000000b0070470669aecmr1544062iol.8.1673472423708; Wed, 11 Jan 2023 13:27:03 -0800 (PST) X-Google-Smtp-Source: AMrXdXtAX2+9t4YbGdDN5amJIJJhMI5bDC9NmsykVauDhwKPhGUSOydQNnPsv9qROdBGzIOAa9FQvQ== X-Received: by 2002:a5d:88c4:0:b0:704:7066:9aec with SMTP id i4-20020a5d88c4000000b0070470669aecmr1544055iol.8.1673472423506; Wed, 11 Jan 2023 13:27:03 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id q20-20020a0566022f1400b006ff6e8b3b8csm5393288iow.41.2023.01.11.13.27.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 13:27:03 -0800 (PST) Message-ID: <6c790e11-1d0b-fd7f-2574-c26815b8f6e4@redhat.com> Date: Wed, 11 Jan 2023 16:27:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 01/11] linux: Do not reset signal handler in posix_spawn if it is already SIG_DFL To: Adhemerval Zanella , libc-alpha@sourceware.org, Szabolcs Nagy , "H . J . Lu" Cc: Christian Brauner References: <20221104190112.2566409-1-adhemerval.zanella@linaro.org> <20221104190112.2566409-2-adhemerval.zanella@linaro.org> Organization: Red Hat In-Reply-To: <20221104190112.2566409-2-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 11/4/22 15:01, Adhemerval Zanella via Libc-alpha wrote: > There is no need to issue another sigaction is the disposition is > already SIG_DFL. > > Checked on x86_64-linux-gnu. Changes requested per original v2. See other review. Please post v4. > --- > sysdeps/unix/sysv/linux/spawni.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/spawni.c > index ee843a2247..65ee03c804 100644 > --- a/sysdeps/unix/sysv/linux/spawni.c > +++ b/sysdeps/unix/sysv/linux/spawni.c > @@ -129,7 +129,7 @@ __spawni_child (void *arguments) > else > { > __libc_sigaction (sig, 0, &sa); > - if (sa.sa_handler == SIG_IGN) > + if (sa.sa_handler == SIG_IGN || sa.sa_handler == SIG_DFL) > continue; > sa.sa_handler = SIG_DFL; > } -- Cheers, Carlos.