From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 749A41F453 for ; Thu, 2 May 2019 20:55:12 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; q=dns; s= default; b=Nby3bdyolR+m5tOIbx/FivDmd/JBoH5otPR9nbDr7StgzRD5sjZZL /nxnEJj3lWH5KCuMz78xq8P9VCold2oNUtRgGwUAKQFj5paJ/t16DyIHJCvxsprO +UW14XvRMgGjxBBku0vN7T9lM1op1YpQMuJ8i/oY/5lHob3ZYHcbHk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; s=default; bh=hM3SLpal0iVZGeZaKePBBxIQSHg=; b=e15MRmBPgqvayM3IXWpo6g+vsKpx EhsvQkehjSlIojk3IlEHHsGgVZ1ZwSyLa0aLbNgo69CR5XjivsizLYjx24vC5813 +he00/Muj2r8OSp+XYfpzU2ns3XXjNf3z6IkQCXd5pmCrXB3FRA2tXajgJnZRJ9M TMQWaKpag0tbiFg= Received: (qmail 121379 invoked by alias); 2 May 2019 20:54:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 121345 invoked by uid 89); 2 May 2019 20:54:56 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: avasout02.plus.net X-CM-Score: 0.00 From: Mike Crowe To: libc-alpha@sourceware.org Cc: Mike Crowe Subject: [PATCH 3/5] nptl: Use recent additions to libsupport in tst-sem5 Date: Thu, 2 May 2019 21:54:33 +0100 Message-Id: <6a2761067dfdedc077e90a3e0ca56473a8cd9934.1556830454.git-series.mac@mcrowe.com> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit * nptl/tst-sem5.c(do_test): Use xclock_gettime, timespec_add and TEST_TIMESPEC_NOW_OR_AFTER from libsupport. --- ChangeLog | 5 +++++ nptl/tst-sem5.c | 21 +++++---------------- 2 files changed, 10 insertions(+), 16 deletions(-) diff --git a/ChangeLog b/ChangeLog index cd0ef83..088076d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,10 @@ 2019-05-02 Mike Crowe + * nptl/tst-sem5.c(do_test): Use xclock_gettime, timespec_add and + TEST_TIMESPEC_NOW_OR_AFTER from libsupport. + +2019-05-02 Mike Crowe + * support/timespec.h: New file. Provide timespec helper functions along with macros in the style of those in check.h. diff --git a/nptl/tst-sem5.c b/nptl/tst-sem5.c index 50ab6f9..396222b 100644 --- a/nptl/tst-sem5.c +++ b/nptl/tst-sem5.c @@ -22,6 +22,8 @@ #include #include #include +#include +#include static int @@ -29,31 +31,18 @@ do_test (void) { sem_t s; struct timespec ts; - struct timeval tv; TEST_COMPARE (sem_init (&s, 0, 1), 0); TEST_COMPARE (TEMP_FAILURE_RETRY (sem_wait (&s)), 0); - TEST_COMPARE (gettimeofday (&tv, NULL), 0); - - TIMEVAL_TO_TIMESPEC (&tv, &ts); /* We wait for half a second. */ - ts.tv_nsec += 500000000; - if (ts.tv_nsec >= 1000000000) - { - ++ts.tv_sec; - ts.tv_nsec -= 1000000000; - } + xclock_gettime (CLOCK_REALTIME, &ts); + ts = timespec_add (ts, make_timespec (0, TIMESPEC_HZ/2)); errno = 0; TEST_COMPARE (TEMP_FAILURE_RETRY (sem_timedwait (&s, &ts)), -1); TEST_COMPARE (errno, ETIMEDOUT); - - struct timespec ts2; - TEST_COMPARE (clock_gettime (CLOCK_REALTIME, &ts2), 0); - - TEST_VERIFY (ts2.tv_sec > ts.tv_sec - || (ts2.tv_sec == ts.tv_sec && ts2.tv_nsec > ts.tv_nsec)); + TEST_TIMESPEC_NOW_OR_AFTER (CLOCK_REALTIME, ts); return 0; } -- git-series 0.9.1