From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C4C9E1F45E for ; Wed, 19 Feb 2020 17:34:32 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:references:from:subject:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=Wfe/lCM1bF1VOBad bX1Q87ZS/JoFwrpLEi1TWJAHgzyzSFzDUB0mGVIz3tdF69JrrEl1yOjEMBH9EC9j o7L5Ox0XRRP7J+o+ENfkPBgLlFaDrfu7wx6nw7/h1tADFvEuJdTWfxXMn4zHTjS9 1BPNAVkP/6fIEIX9GTSx8KnhoXo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:references:from:subject:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=W8SyVd53ct5GpdLW8+jlUL 56mBA=; b=tkZdfHLeNLBC2x6OeARMI9e5R8WtR3NwUuUQoL2PmuH5oAFsncuXN0 hLgQrphZAtheUD9gUqXM/Mc8Q2zsWd5HwU4Zm3FANkCVgf4p5sYm1VSiYO7ebzWj ZGUTZq42neTnIG/bI6qsuGvOCdd9YyisS0ZsjMXGwkCzKXkKnsRLA= Received: (qmail 80885 invoked by alias); 19 Feb 2020 17:34:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 80877 invoked by uid 89); 19 Feb 2020 17:34:30 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qt1-f196.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gmglYS0HdUDN7ZLBE1VJfK8BpCkwqbCuNKynWVAvuD8=; b=IG/d3ghMNqVO0NKvmITKeMzD1bsfUXtcq+13bnOphcMvDfbNCy3iMDDfnxK/2r5bV8 BcJYEQFMFtvAKzktIYe7LHpGwoRQ9eyOjTZtq9w6XIYPuZRaaAWn+h6vkAyPjwcfxxTn h77w/Rrk8PrOFm5uS7MZ9wYIstFhhq5xM8RAF0JUAXvxRqXR9GEGvjjUazk0qitsERSA OtISK1yDcDsM/84E1s+I2tqzYqj8ADUwc6riEqVia3O8O+N0CADzEkjevNUfjEFbTuDS 0x7jYBIPfsJI28Tb63DC6LO6iDpwdQza/MqrYlZR3sKBAm6TpAVLXtjqSy6cS9jRAB7b kCpQ== To: libc-alpha@sourceware.org References: <87037a063582b22acaede4def0245c5042fd8e22.1581418947.git.fweimer@redhat.com> From: Adhemerval Zanella Subject: Re: [PATCH 02/13] nptl: Sort routines list in Makefile alphabetically Message-ID: <6611e064-469a-d845-7a48-7f6a9df6c594@linaro.org> Date: Wed, 19 Feb 2020 14:34:24 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87037a063582b22acaede4def0245c5042fd8e22.1581418947.git.fweimer@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 11/02/2020 08:06, Florian Weimer wrote: > This will make it easier to review changes which move implementations > from libpthread to libc. This organization does help a lot not only refactoring, but also new files. Maybe we could enforce it from now one, thoughts? LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > nptl/Makefile | 28 +++++++++++++++++++++------- > 1 file changed, 21 insertions(+), 7 deletions(-) > > diff --git a/nptl/Makefile b/nptl/Makefile > index 40f27ea7cd..cd416f3208 100644 > --- a/nptl/Makefile > +++ b/nptl/Makefile > @@ -28,13 +28,27 @@ headers := pthread.h semaphore.h bits/semaphore.h \ > extra-libs := libpthread > extra-libs-others := $(extra-libs) > > -routines = alloca_cutoff forward libc-lowlevellock libc-cancellation \ > - libc-cleanup libc_pthread_init libc_multiple_threads \ > - register-atfork pthread_atfork pthread_self pthread_equal \ > - pthread_attr_destroy pthread_attr_init pthread_attr_getdetachstate \ > - pthread_attr_setdetachstate pthread_attr_getinheritsched \ > - pthread_attr_setinheritsched pthread_attr_getschedparam \ > - pthread_attr_setschedparam > +routines = \ > + alloca_cutoff \ > + forward \ > + libc-cancellation \ > + libc-cleanup \ > + libc-lowlevellock \ > + libc_multiple_threads \ > + libc_pthread_init \ > + pthread_atfork \ > + pthread_attr_destroy \ > + pthread_attr_getdetachstate \ > + pthread_attr_getinheritsched \ > + pthread_attr_getschedparam \ > + pthread_attr_init \ > + pthread_attr_setdetachstate \ > + pthread_attr_setinheritsched \ > + pthread_attr_setschedparam \ > + pthread_equal \ > + pthread_self \ > + register-atfork \ > + > shared-only-routines = forward > static-only-routines = pthread_atfork > >