From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-2.4 required=3.0 tests=BAYES_00,BODY_8BITS, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS,T_PDS_OTHER_BAD_TLD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 113D01F4C1 for ; Wed, 30 Nov 2022 08:40:34 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8101C385B184 for ; Wed, 30 Nov 2022 08:40:32 +0000 (GMT) Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id AC2C63858D20 for ; Wed, 30 Nov 2022 08:40:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC2C63858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [114.246.94.134]) by gateway (Coremail) with SMTP id _____8CxruvsFodjKFECAA--.5526S3; Wed, 30 Nov 2022 16:40:12 +0800 (CST) Received: from [IPv6:::ffff:192.168.3.4] (unknown [114.246.94.134]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Dx8VXpFodjImYiAA--.645S2; Wed, 30 Nov 2022 16:40:09 +0800 (CST) MIME-Version: 1.0 To: Xi Ruoyao , Florian Weimer Cc: "adhemerval.zanella@linaro.org" , "libc-alpha@sourceware.org" , "i.swmail@xen0n.name" , "xuchenghua@loongson.cn" , "sunxu@loongson.cn" From: Subject: =?utf-8?Q?=E5=9B=9E=E5=A4=8D:_=E5=9B=9E=E5=A4=8D:_[PATCH]_LoongArch:_Use_?= =?utf-8?Q?mediumcmodel_build_libc=5Fnonshared.a.?= Date: Wed, 30 Nov 2022 16:40:09 +0800 Importance: normal X-Priority: 3 In-Reply-To: <7ffa022e80ba4ab8942995da0d5c8371f180cb1b.camel@xry111.site> References: <20221123070905.1618136-1-caiyinyu@loongson.cn> <87zgcim07m.fsf@oldenburg.str.redhat.com> <33054b9098f4ef690cd1639e96b2c148e9e9e490.camel@xry111.site> <6386FE6D.025D62.50083@loongson.cn> <7ffa022e80ba4ab8942995da0d5c8371f180cb1b.camel@xry111.site> X-CM-TRANSID: AQAAf8Dx8VXpFodjImYiAA--.645S2 Message-Id: <638716EC.025EAB.50083@loongson.cn> X-CM-SenderInfo: 5fdl5xhq1xqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBjvJXoW7Cry5tw1fZw45ur43AFy5Jwb_yoW8Wr1fpr 93J345trWDt3409as5CFW5CFy5Wrs7WFZ8W3sIgw1Ska90k347WrZ3t3WUAF9FgF97Ja9F qa1xZrnxJ3Z5WrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj ya5I8CrVAYj202j2C_Jr0_Gr1l5I8CrVAKz4kIr2xC04v26r1j6r4UMc02F40E42I26xC2 a48xYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUUbTxYFVCjjxCrM7AC8VAFwI0_Jr 0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_JrI_Jryl8cAv FVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5Jw A2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWx Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v26F4UJVW0owAS0I0E0xvYzxvE52x082IY62kv04 87Mc804VCY07AIYIkI8VC2zVCFFI0UMc02F40Eb7x2x7xS6r1j6r4UMc02F40Ew4AK048I F2xKxVWUJVW8JwAqx4xG6xAIxVCFxsxG0wAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z2 80aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4kE6xkIj40E w7xC0wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14 v26r106r1rMI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkG c2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU8nSdDUUUU U== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" OK, I will use CFLAGS-.oS +=3D -mcmodel=3Dmedium and have-cmodel-medium. =E4=BB=8E Windows =E7=89=88=E9=82=AE=E4=BB=B6=E5=8F=91=E9=80=81 =E5=8F=91=E4=BB=B6=E4=BA=BA: Xi Ruoyao =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B411=E6=9C=8830=E6=97=A5 1= 5:34 =E6=94=B6=E4=BB=B6=E4=BA=BA: caiyinyu@loongson.cn; Florian Weimer =E6=8A=84=E9=80=81: adhemerval.zanella@linaro.org; libc-alpha@sourceware.or= g; i.swmail@xen0n.name; xuchenghua@loongson.cn =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [PATCH] LoongArch: Use mediumcm= odel build libc_nonshared.a. On Wed, 2022-11-30 at 14:55 +0800, caiyinyu@loongson.cn wrote: > +# All the objects in lib*_nonshared.a need to be compiled with medium > code > +# model or large applications may fail to link. > +CFLAGS-.oS +=3D -mcmodel=3Dmedium > =C2=A0 > We just need add -mcmodel=3Dmedium to four files not all. I still prefer "all", to prevent subtle breakages if someone adds a file into or removes a file from libc_nonshared.a. Currently other .oS files are in libsupport_nonshared.a which is used by the test suite and not installed. /* snip */ > +LIBC_CONFIG_VAR([enable_cmodel_medium], It looks like we are using "-" instead of "_" in the first parameter of LIBC_CONFIG_VAR calls everywhere. Note that it's a variable name in a Makefile, not a shell script. And I'd remove the "enable" prefix: this prefix makes the variable looks like "something can be turned on/off by `--{enable,disable}-cmodel- medium'" but it's not true. So I think "cmodel-medium" or "have-cmodel-medium" would be a better name. > [$libc_cv_loongarch_cmodel_medium]) --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University