From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 32D541F8C6 for ; Tue, 24 Aug 2021 01:16:30 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CCEFE3858010 for ; Tue, 24 Aug 2021 01:16:27 +0000 (GMT) Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68]) by sourceware.org (Postfix) with ESMTPS id DD39B3858C2C; Tue, 24 Aug 2021 01:16:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD39B3858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1E385160060; Mon, 23 Aug 2021 18:16:07 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id rpa6P4l2bLR8; Mon, 23 Aug 2021 18:16:02 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6A712160071; Mon, 23 Aug 2021 18:16:02 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id blyhMtN-vMUq; Mon, 23 Aug 2021 18:16:02 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 42A8F160060; Mon, 23 Aug 2021 18:16:02 -0700 (PDT) Subject: Re: [PATCH v4 1/2] Port shared code information from the wiki To: Siddhesh Poyarekar References: <20210823025410.590471-1-siddhesh@sourceware.org> <20210823025410.590471-2-siddhesh@sourceware.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <627a1c74-bd9e-6ce4-caff-7c126e01931b@cs.ucla.edu> Date: Mon, 23 Aug 2021 18:16:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210823025410.590471-2-siddhesh@sourceware.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libc-alpha@sourceware.org, joseph@codesourcery.com Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 8/22/21 7:54 PM, Siddhesh Poyarekar via Libc-alpha wrote: > +# The headers on most of these files indicate that glibc is the canonical > +# source for these files, although in many cases there seem to be useful > +# changes in the gnulib versions that could be merged back in. Not all gnulib > +# files contain such a header and it is not always consistent in its format, so > +# it would be useful to make sure that all gnulib files that are using glibc as > +# upstream have a greppable header. For files shared (or close to being shared and intended to be shared eventually) between glibc and gnulib, please see gnulib/config/srclist.txt. https://git.savannah.gnu.org/cgit/gnulib.git/plain/config/srclist.txt Some of these shared files (intprops.h, flexmembers.h) are edited in PATCH v4 2/2. Although I don't object to those two edits I suggest going through srclist.txt and making sure we're not going overboard here.