From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 175F41F45E for ; Wed, 12 Feb 2020 13:19:41 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=QPtyyyr5TPMIOGH5 vHCUgVcHj3mWNnfi3SjXD20J7314w9NrcHqrpkFyabQaI0DdvML2bju7b5GyIwIo 2D4oQyNs/kfP1S9iHgtm42DIhhvcvjREYCdFHcTx/34oq/gO9NVnPcr3+pRFJ1xr b4MHptZ2Rr3wGj9wxVtSdTbo0xo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=U8vkw3qsCi9z5XESdLg1RJ ONfGY=; b=sgb6xtCr9yFcXKYgAeWxg1UaRIOgXv5ojHNHBjsvhrEpjqApFk4g48 VIEB0I+H6FQz/b2PGNeq/4hKWV6LveKkZdtjlu4mqkfgqJcv2xl0qMpycysah+TL Jdvo/+dkWs1WjmpmMLnVZiabYvXk7ETlykUv702aKFOueEDcpTX6k= Received: (qmail 49798 invoked by alias); 12 Feb 2020 13:19:38 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 49790 invoked by uid 89); 12 Feb 2020 13:19:37 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qt1-f195.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mFQkjLyh0p10Vp53t4b3kfPgn2EIsOByHZdhUiiIPmo=; b=AAzlRubTMiQVbzICjWoFGAHHXIHqRwAmI34Sy8azklzoS7/zTGy7t+ifH//NagLnlM PsTE4DOfZdHigLg5FehvCux6aNPHJ71izNdlC33B5zWEMaGmwXTqgpi01ECf6egIgxYx znwVPR9ag7hLPviQV8aHeKhBI1UdFoivoAc/y6JRNSNQzMEkkArVKAE0ukHtd0QFeXWY Z7CIcuJOsDPPROpHMKjFzluMm80RRQBfN/UWMfhNX2EBkj1iIATSzp4PYraVK2Q22f+P UYu7K5LKezrxeP174L8wazPDbkEZwkqpaC2Z2KkIg4IVpze3v04i0UM6ZCAekR0GSM9b 1XNg== Subject: Re: [PATCH 01/15] powerpc: Consolidate Linux syscall definition To: Florian Weimer Cc: libc-alpha@sourceware.org References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <87tv3wnc43.fsf@mid.deneb.enyo.de> From: Adhemerval Zanella Message-ID: <622d4e4a-9cb6-6b0e-ecc4-7b05d71b6a06@linaro.org> Date: Wed, 12 Feb 2020 10:19:27 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87tv3wnc43.fsf@mid.deneb.enyo.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 11/02/2020 16:43, Florian Weimer wrote: > * Adhemerval Zanella: > >> +/* Define __set_errno() for INLINE_SYSCALL macro below. */ >> +#ifndef __ASSEMBLER__ >> +#include >> +#endif > > Missing indentation (but the existing files are not consistent about > that). > >> +/* Pointer mangling support. */ >> +#if defined(__PPC64__) || defined(__powerpc64__) >> +# define LOAD ld >> +# define TPREG r13 >> +#else >> +# define LOAD lwz >> +# define TPREG r2 >> +#endif > > Can you restrict those to #ifdef __ASSEMBLER__? is a > fairly widely included header, and this has the potential of breaking > future changes that compile on other architectures. Ack. > > Rest looks okay to me, but maybe a POWER maintainer wants to have a > look as well. >