From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5E4D21F453 for ; Fri, 25 Jan 2019 01:52:37 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=QZlxp0SiDE6tsY9j 75eyufUmk5UTOxMpUKilg2OCGnYmQNV/hqvh0w/SeTgI/PDri0S4JW7mIBJbT+1g POw+zBexltHvXdLu+as/C20yG7Cei7OchVSCTy8F/5bhSUD89jy1KzyxfpvgptUC ftOp3dwJcbKKIG8dSb9Hx68k5SY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=uqCu/4ZvSDJlfxX6fW7HO3 7l9fs=; b=mDDYXQTID7bXXL4fiuOFM4Cmb0XZv0e43bA6UfKBJ5HgIAXd8YryKN r5YW6jyt/EAvPx84utTysi3jO/aHQRn7dn2txtHQpcN+esMj2h35Dl/ZsKSXomq2 vayLYy54bmATJX2CiAdPAq2F97aGUMspfSYIDMIfIe5AWFu1eEJn4= Received: (qmail 62434 invoked by alias); 25 Jan 2019 01:52:34 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 62360 invoked by uid 89); 25 Jan 2019 01:52:34 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: indri.birch.relay.mailchannels.net X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Stop-Lonely: 69203bd93a95fc1a_1548381151006_41005964 X-MC-Loop-Signature: 1548381151006:3681058234 X-MC-Ingress-Time: 1548381151006 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=uqCu/4 ZvSDJlfxX6fW7HO37l9fs=; b=DXZEp+9tAVP5JXJmHgErOZmP5nj78ylLDjDLmw 6nRbnRofZ93o7xS6B3gs8Z2bdyy6ssHMhD3he59iN02YXvvXRWRw7nQ+E4qxctev /SL4v2SiAxdkk1zVuVpmaKR45a4LFRIeDYAnlDqnPOumOBDZiAAO8MAAf09PUy5E 3DwUs= Subject: Re: [PATCHv2] nptl: Fix pthread_rwlock_try*lock stalls [BZ #23844] To: Carlos O'Donell Cc: Florian Weimer , Torvald Riegel , Rik Prohaska , GNU C Library References: <878szcevu9.fsf@oldenburg2.str.redhat.com> <390f7db7-8e72-e718-f0eb-673eb91199c0@redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a46 From: Siddhesh Poyarekar Message-ID: <5fb71914-ccb7-2918-9d13-5854fe98117d@gotplt.org> Date: Fri, 25 Jan 2019 07:22:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrieefgdegudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtqhertddtfeejnecuhfhrohhmpefuihguughhvghshhcurfhohigrrhgvkhgrrhcuoehsihguughhvghshhesghhothhplhhtrdhorhhgqeenucfkphepuddvfedrvdehvddrvddtvddrudejvdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghloheplgduledvrdduieekrdehrdduudelngdpihhnvghtpeduvdefrddvhedvrddvtddvrddujedvpdhrvghtuhhrnhdqphgrthhhpefuihguughhvghshhcurfhohigrrhgvkhgrrhcuoehsihguughhvghshhesghhothhplhhtrdhorhhgqedpmhgrihhlfhhrohhmpehsihguughhvghshhesghhothhplhhtrdhorhhgpdhnrhgtphhtthhopegtrghrlhhoshesrhgvughhrghtrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd On 25/01/19 7:14 AM, Carlos O'Donell wrote: > On 1/22/19 1:12 PM, Carlos O'Donell wrote: >> v2 >> - Added analysis comment to tryrdlock test. >> - Removed rw var and avoided boolean coercion. >> - Avoided incomplete test output to stdout. >=20 > Siddhesh, >=20 > Both Torvald and Rik have OK'd my use of Signed-off-by. >=20 > Florian has done a review of tests. >=20 > Torvald, Rik and myself have reviewed and tested the fix. >=20 > Rik restated that the current fix I have here fixes his test case. >=20 > I plan to do a "quick" b-m-g run to look for issues and then push > this fix as my last fix for 2.29. Sure, please do this before the end of the week and if anything breaks, revert and retry in 2.30. Siddhesh