unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
	libc-alpha@sourceware.org, fweimer@redhat.com
Subject: Re: [PATCH] locale: Handle loading a missing locale twice (Bug 14247)
Date: Tue, 9 Apr 2024 08:44:09 -0400	[thread overview]
Message-ID: <5ed2f8e8-7367-4a08-a769-7e105d693351@redhat.com> (raw)
In-Reply-To: <94141573-394d-4a38-a7ee-a349a8f73623@linaro.org>

On 3/1/24 12:26, Adhemerval Zanella Netto wrote:
> Change looks ok, some minor style issue and a suggestion to use libsupport.

Thanks for the review.

Posted v2 incorporating your changes.

https://patchwork.sourceware.org/project/glibc/patch/20240409124205.1512915-1-carlos@redhat.com/

Test is easier to read and shorter now too.

-- 
Cheers,
Carlos.


      reply	other threads:[~2024-04-09 12:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27 15:35 [PATCH] locale: Handle loading a missing locale twice (Bug 14247) Carlos O'Donell
2024-03-01 17:26 ` Adhemerval Zanella Netto
2024-04-09 12:44   ` Carlos O'Donell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ed2f8e8-7367-4a08-a769-7e105d693351@redhat.com \
    --to=carlos@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).