From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 474D51F48A for ; Tue, 11 Feb 2020 20:56:09 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=fuNv0Zbtm9r3hueC VFoT0+pxDZNUUvJd+qpxgHScNmUaXzRfrNHDESp+nhF+nEKXpjUtBx71Us4ppSyj Ualv/xo2xYOkB8/4Q/P4747FO2LW+9/e4lepgU9TpRz8xypjUWbQsaXZAvaZPiN2 omnoXeVAUWU3BDB2r0drjjYcDrE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=eja77LWtcncAp/Ps9Nek6/ H92lk=; b=BUEYB6lYtFvPa9hWBWim2jtT4+UtM2Zqq7dHpxspvZ3AowAzwTaZ3k bDYYPla2/kaHFxyr+nkC9f0Oh8JCk+Svca+/rGUjbCl4kzdsDWXhlR0/FFk/QoDj bI38A0Y27wewTACLq7MaOvDyVmXtgOmnh38YbvFYuIaoqwxkyjAJw= Received: (qmail 120985 invoked by alias); 11 Feb 2020 20:56:06 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 120973 invoked by uid 89); 11 Feb 2020 20:56:05 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qk1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Qsw2/MFsEpn3cc1Wg92k2cd7p66eTQzANWKPx+EteOg=; b=d/u42u1UL5Knu8mW5AFqmZufypVuMgSyHDybdY7sUgyN+h6Y8VkSr2RqI0Fav6FDKP rMB/8adEjFuV1qniIbwAd4K8URMwsm2PSMSHjxqDeGyRHGKEG5sRTdohsxwl0QbXExcp f8lQ29SlT3ozYN6aCJ0Rg17rSIa1Ch4j5KFvbJ+WyrGRDxxGYWoA2FUOQJ17dfcyuF9j QcDtvrDzbxH2SS+rtIGjCVOzSL4AgZ1yFIayt7dOWeAhNy4QAb+MTDYg8RwciTDPdTzd UgCB0Yq8koLSEoz7YoU23k10gt0ocquw+TngFmTz+K2cgFaJJ5dLEMn5FJ9dQEpongFh pcDw== Subject: Re: [PATCH 15/15] linux: Remove INTERNAL_SYSCALL_DECL To: Florian Weimer Cc: libc-alpha@sourceware.org References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-15-adhemerval.zanella@linaro.org> <87r1z1mgs6.fsf@oldenburg2.str.redhat.com> From: Adhemerval Zanella Message-ID: <5b9a4291-1c34-446b-3393-32a4855e7568@linaro.org> Date: Tue, 11 Feb 2020 17:55:59 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87r1z1mgs6.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 11/02/2020 09:48, Florian Weimer wrote: > * Adhemerval Zanella: > >> With all Linux ABIs using the expected Linux kABI to indicate >> syscalls errors, the INTERNAL_SYSCALL_DECL is an empty declaration >> on all ports. >> >> This patch removes the 'err' argument on INTERNAL_SYSCALL* macro >> and remove the INTERNAL_SYSCALL_DECL usage. > > I see some cases where you modify lines which contain INTERNAL_SYSCALL > without changing it to INTERNAL_SYSCALL_CALL. Maybe you can fix those > as well? Ack, I will update the patch. > > Same for long vs long int. Ack. > > Apart from the other quirks I mentioned, this patch looks okay to me. > > Thanks, > Florian >