From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C276D1F463 for ; Thu, 2 Jan 2020 13:50:18 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=qRZNLvjF7jOo4nl4 d+Sx0B5xDLqEuN8eDfXuv6HuIHNjw1iEw3TFkPNGQkN+ufo138RqFVH2ykGmob4k ZjpQpqBi5MQsdqXv5fQhDpxYInvdJx7yxTBTp1f5wzPqJHr2M1njqWEtShC2BKjo b8Q6sZLWPkkC/WD1RzTyPzfdlR0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=GX3qbqVgajuI7gKIwWEBsX zlKUs=; b=xLue6/42rQpHWliUyvvZBD7oEcu3FWXfSYwXUEOCMxbcbjOGDaNesi pFEpLsVMVGMT+er/+e+WMdH5ziJJdJCaTu+q7Znr9xyKYxC3FomU9Xe1527MaVgB 2FCGvuHcY4VQ1OwuPp0XqyXTW+p/IQXkmm6KoMsYolSg3wNue2fKU= Received: (qmail 13395 invoked by alias); 2 Jan 2020 13:50:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 13365 invoked by uid 89); 2 Jan 2020 13:50:15 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-pf1-f196.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=H/j8OddIortE4fO+esmOjNnqznOe6UkfJ+vc8KZZmkU=; b=AeNKH0ysn7U8q+uODrwwM3lD7lC/qcTwUZt7SUPV+WE9wkwGNS3CqNZwfaR8GhXLu8 ksplU/ofgEwbfEccyAWoovnMxwh7c2KvCL89ZW/O+N4CcBDeb52WTFF2VSsRrVtfazsf 7WNf23owRNN46hwchHv00rgb7f+8LCDgKoVTFVKJxk5JMa088A75Tpy6BefJuFpL2REn c8Mw20oH/6ed2M09ONX0kkduKZTiEg8yBlRx+cwIglslIb05Yf+j9rB1le0e3WTg9MLC 6/uonSfVo5p0Ag2Y0enB2MeOlvlC4UFOWZVC0CLTdDeSKeHZfipTM1wBysx7dD1ryRgO 1Clg== Subject: Re: [PATCH 14/16] linux: Enable vDSO clock_gettime64 for mips To: Siddhesh Poyarekar , libc-alpha@sourceware.org References: <20191217214728.2886-1-adhemerval.zanella@linaro.org> <20191217214728.2886-14-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Message-ID: <590d001b-9028-ad61-a81e-d372a1cacf7d@linaro.org> Date: Thu, 2 Jan 2020 10:50:09 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02/01/2020 10:13, Siddhesh Poyarekar wrote: > On 18/12/19 3:17 am, Adhemerval Zanella wrote: >> It was added on Linux 5.4 (commit 1f66c45db3302). >> --- >> sysdeps/unix/sysv/linux/mips/sysdep.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/sysdeps/unix/sysv/linux/mips/sysdep.h b/sysdeps/unix/sysv/linux/mips/sysdep.h >> index c2bec03806..67a2f74df2 100644 >> --- a/sysdeps/unix/sysv/linux/mips/sysdep.h >> +++ b/sysdeps/unix/sysv/linux/mips/sysdep.h >> @@ -16,11 +16,16 @@ >> License along with the GNU C Library. If not, see >> . */ >> >> +#include >> + > > Do you need this at all? It seems to me that the compiler sets _MIPS_SIM. The compiler does sets _MIPS_SIM, but it might not define _ABIXX (for instance -mabi=32 does not define _ABI64). > >> #define VDSO_NAME "LINUX_2.6" >> #define VDSO_HASH 61765110 >> >> /* List of system calls which are supported as vsyscalls. */ >> #define HAVE_CLOCK_GETTIME_VSYSCALL "__vdso_clock_gettime" >> +#if _MIPS_SIM != _ABI64 >> +#define HAVE_CLOCK_GETTIME64_VSYSCALL "__vdso_clock_gettime64" >> +#endif >> #define HAVE_GETTIMEOFDAY_VSYSCALL "__vdso_gettimeofday" >> #define HAVE_CLOCK_GETRES_VSYSCALL "__vdso_clock_getres" >> >> >