From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C720F1F466 for ; Mon, 20 Jan 2020 10:02:40 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:date:mime-version :in-reply-to:content-type:content-transfer-encoding:message-id; q=dns; s=default; b=lx5sJiT/ky2Kxjw2ojCjmmNc3i33fTDhvVRZ98XceHG joQQRoubIT5Tq+y0L8GeiqF7ZpVIOeKCfVQkTNioiSqGkCIhZVP6hvbVsacyi6sC S3kocM2k6NWN9SkofxJ7OTp8Afvh12AiiMOUE8/U3KLOX/3A6W42DjW404Mzsank = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:date:mime-version :in-reply-to:content-type:content-transfer-encoding:message-id; s=default; bh=b/sGDZsEsHsXsAtBvnezeMu9Xuw=; b=A8AmlTv/2dZsc5yo2 xEOQpnm7b7RLct+I3l242o7CCypnAppKFEOutIRQNq7fRs3F+qAsvYYrNSkBJ898 8bH495/Tf78eT1EWFs4T4iCTI3zs754kNVM4gIJoVxKja9OjcgiQCTW33Y3nyERD jFDlsElrugS9Rxukt9IK6ldUxE= Received: (qmail 46374 invoked by alias); 20 Jan 2020 10:02:38 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 46362 invoked by uid 89); 20 Jan 2020 10:02:38 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH] Get rid of Werror=maybe-uninitialized in res_send.c. To: Siddhesh Poyarekar , GNU C Library References: <03d65724-d69b-d553-18a5-dece072e5a45@linux.ibm.com> From: Stefan Liebler Date: Mon, 20 Jan 2020 11:02:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit x-cbid: 20012010-0008-0000-0000-0000034B0894 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20012010-0009-0000-0000-00004A6B6AA1 Message-Id: <58f48ec0-9db1-103f-dd46-44f790f7059f@linux.ibm.com> On 1/20/20 9:27 AM, Siddhesh Poyarekar wrote: > On 03/12/19 2:20 pm, Stefan Liebler wrote: >> Hi, >> >> the commit 446997ff1433d33452b81dfa9e626b8dccf101a4 introduced >> this new usage of resplen. If build with gcc 9 -march>=z13 on s390x, >> the following warning occurs: >> res_send.c: In function ‘__res_context_send’: >> res_send.c:539:6: error: ‘resplen’ may be used uninitialized in this >> function [-Werror=maybe-uninitialized] >> 539 |   if (resplen > HFIXEDSZ) >> |      ^ >> >> Therefore this patch adds a further DIAG_IGNORE_NEEDS_COMMENT in the >> same way as it was previously done for usages of resplen or n. >> See commit d1bc2cbbed9aea2017ef941f63c8786571da5b4f. > > This is fine. OK to commit to master. > > Reviewed-by: Siddhesh Poyarekar > > PS: Please send patches inline (using git send-email) since it's easier > to add review comments that way. > Okay. Committed. Thanks. Stefan