From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F2CC11F44D for ; Thu, 28 Mar 2024 18:39:41 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RywBwJdK; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ECFD63858D38 for ; Thu, 28 Mar 2024 18:39:40 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C852B3858D1E for ; Thu, 28 Mar 2024 18:39:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C852B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C852B3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711651161; cv=none; b=iZjHeCACi2lctWSQOyw5+AuQ+hnAYYFiD1Mxm1K8sNz09FjijqfezuGBy5FQeuJDx5vFZbwy45OXrUAH9+RtQAvFnlqsjMlzisgXd4DhGR/Vkd0By4C/1U9pfGVJTLtmsf1my9DNO2f5+/V3fxwroWJLWSDp6WLGVuSGfl45hyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711651161; c=relaxed/simple; bh=tQskAlpU2UhpxINFxzDbrF/yXIac9l62hGfY111KC+k=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=SC0idbH0xvYIzT/1SNGlxb3wZzmkkO2oeZjlPvc00A+zKH8jAN3KvZ/y0qpbxJMS02InGt5vkxZ61YQSLbhI2ltHSdD26gd+NbZDaW0QdB2ome9XPyJfgep5Xi21P7QeK7eaO1QwMq2JojWpVK0ZAInNJ6Oh4Quj+iVcznXPhSI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711651159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IbXoSnn+jzmMU48sfhUENZemitBk1rRr9Wa+QvyqOMI=; b=RywBwJdKtMr4XTULK37FEvb/q9fG9wV7tUBg0LuC51KuPLzqEOoMzbDOpdvcZRcIrX81+J bDmkhdg43BIh3ADwqnDOjiBPTSARKenqIupTBOi1DTY+es5LxtZ7ALQwnQquxloIdzeznN TyWOgMUpdEy9/UJ0ySjGIy1K/VddWak= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-486-ks1bBd9CPzWw9PgS45hs-g-1; Thu, 28 Mar 2024 14:39:16 -0400 X-MC-Unique: ks1bBd9CPzWw9PgS45hs-g-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4147ddecd52so7039835e9.0 for ; Thu, 28 Mar 2024 11:39:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711651155; x=1712255955; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IbXoSnn+jzmMU48sfhUENZemitBk1rRr9Wa+QvyqOMI=; b=ulfpxNWQzIAfViMC3jrIpdIa72wmIpxGOO9hVCbBP9a0UHOZoM/4m/iPwbj0+/fyZa wI2skJNN5/xEcJzHmMHZ95qFJAS18j5XtwyN4yLVCpQxaSmxO6IgKr13peFDmBJ7yseG pGZwCqfu+iXwaJsJd+ESdBvDFCEmp/nMUaP6KPaBpo59s56WNce5PfFOvL70Tz0bFHYL zs4AbvRsTZzGN35/KhepcjZyAtUd0DITRnfYTr5Ai2vOEqWWH+wdztPXZNT7lQJMg3Wr 04Wrk13nGuy9J9O3gt77GMQKHvNQJUKWttprP8hpK5yXvTOtOPFqKm93+9RjvhJa6Bwf CzxA== X-Forwarded-Encrypted: i=1; AJvYcCVwFaFCpwpZn3XDo1AUH3BgTYsb38vUfB8OSD/lx7IuL2w24IQsuZr0m4T91CUVfCI/0EBwn+M8aPQBKe+/wqRUxmtgwA3Gq2G0 X-Gm-Message-State: AOJu0Yy7kMrDnY9ZZ8FFuofVbK9RSqjyYqvXhjIOOaPUPwAIFgJGE+5p B9G58KQhIE30V77SgT+zSjoByF2fvpaTkkH6do3R0UxaMNmWVz1wp68gRGfWMaNBqDpDo0G2Ata Nj4ocpKL0Ef2E5ugNlQMmYdJnHnzxqYzsk+bsFVUGkv1Xbehbn5OIHM0hTg== X-Received: by 2002:a05:600c:510b:b0:414:902d:a891 with SMTP id o11-20020a05600c510b00b00414902da891mr2990519wms.16.1711651155717; Thu, 28 Mar 2024 11:39:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkbdUU1zHmkXnejC2pKMpikBT+Wkreb2yu80qyJ6bTsKDqyg6+p5K7NBIgIA2MRfAzo1WxrA== X-Received: by 2002:a05:600c:510b:b0:414:902d:a891 with SMTP id o11-20020a05600c510b00b00414902da891mr2990506wms.16.1711651155396; Thu, 28 Mar 2024 11:39:15 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id ch9-20020a5d5d09000000b0034330c9eccasm1887597wrb.79.2024.03.28.11.39.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 11:39:15 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rpue7-001Lbn-Ca; Thu, 28 Mar 2024 18:38:39 +0000 Date: Thu, 28 Mar 2024 18:38:39 +0000 (UTC) From: Joseph Myers To: Adhemerval Zanella Netto cc: "H.J. Lu" , GNU C Library Subject: Re: [PATCH v2 03/10] i386: Use generic fmod In-Reply-To: <1c27a80e-30f9-48fb-b608-8f2387621f5e@linaro.org> Message-ID: <581bcd44-11eb-5dc4-de67-8de9e23435@redhat.com> References: <20240327194024.1409677-1-adhemerval.zanella@linaro.org> <20240327194024.1409677-4-adhemerval.zanella@linaro.org> <1936623e-b6c1-40ef-b7c8-249eef54d071@linaro.org> <1048273f-c636-4c2b-83f6-7535839bce03@linaro.org> <9bf7af32-afa3-439c-84c0-76e76b220e44@linaro.org> <0e4733a3-d569-4a73-b2d3-001cc6c3d751@linaro.org> <1c27a80e-30f9-48fb-b608-8f2387621f5e@linaro.org> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On Thu, 28 Mar 2024, Adhemerval Zanella Netto wrote: > We don't really have SVID compatibility tests for any other > optimization/simplification, and although I don't really oppose on > adding I also thinking that this is making this change even more > complicated than it would require. We have math/test-matherr* as generic tests of matherr working with binaries that specifically use the compat symbol matherr and not with newly linked binaries. Those don't however attempt to test properties of specific symbols for individual libm functions. A change like the present one is not meant to be user-visible for any newly linked binary, as a legitimate newly linked binary couldn't link against the matherr compat symbol anyway. And we don't have any attempt to ensure that old symbol versions of individual libm functions can be used together with the compat symbol of matherr - just that the compat symbol of matherr works with one libm function. -- Joseph S. Myers josmyers@redhat.com