From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-5.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 104A21F8C6 for ; Fri, 10 Sep 2021 13:38:19 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 06C933858405 for ; Fri, 10 Sep 2021 13:38:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 06C933858405 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631281098; bh=d8AMTVJENsvwjoLJ2Vo2uff9MCPqlp5aeEJ/a9ZWayw=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ilTLVdn6A89oX2Ox9hR/EwYygyixIVqEd1fTeTouMGZvySWufs+c9yPkysk30QV4n QV0FmeLsJcrPaVj3F+hWASxdRw9pzYO6NOPGso+iJdM734tJX26axUdgD0PdNaYwsT ZsLbVpmeoE1NQ+3O78X9Hjk4dzmJLi61iGMYHPT8= Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 1E7503858405 for ; Fri, 10 Sep 2021 13:37:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E7503858405 Received: by mail-wr1-x436.google.com with SMTP id t18so2739714wrb.0 for ; Fri, 10 Sep 2021 06:37:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d8AMTVJENsvwjoLJ2Vo2uff9MCPqlp5aeEJ/a9ZWayw=; b=Cm+6fYTie/vi7ez8aTwTV4UYEd+GvSJ7K0WGZZfYA/i2HeaOEpBzHZJbq+2AL+hyU4 MCv5N/HghpOCQHLx8m2x+QsPkT9VszIlKiNGRDZbDPBfyTKau+UWQ46AW8SlNHbBMefP FcvHthaOjo/2RDVtoL6CoNgb/ag41h9jus8lRYClKzifNDWkyu1h7arIf5ZQsN+Z+Br3 sUWuHzTZcWIgoj5cYIlqMUTC0Jio6kF7s/349sGjPIgnvLkDN0GmFyOfZ7xiACKYf/eh chbzzchV5OvkPTzya7qi1B39iVIHehbeoYGvX+y/9OsnS8NavEoX/3ZjB3Jp6b7CPcqS l0hw== X-Gm-Message-State: AOAM531U7Nn5XuycdJDG7imUDyf8DLj1phhRBBUy06sWjDPXKqXnDS+A EsCNZLazdyPG9Yj4Dg4gKXBkMhVbZHY= X-Google-Smtp-Source: ABdhPJx7adg3aHLA2oIDdFFIZDFQSZhDSWHTmsekQJg2QfkmLkRBCfHTHZVh9PUV4K4rHRi8IqVExA== X-Received: by 2002:adf:f892:: with SMTP id u18mr9529952wrp.31.1631281076154; Fri, 10 Sep 2021 06:37:56 -0700 (PDT) Received: from [10.168.10.11] ([170.253.36.171]) by smtp.gmail.com with ESMTPSA id o2sm5077823wrh.13.2021.09.10.06.37.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Sep 2021 06:37:55 -0700 (PDT) Subject: Re: [PATCH v4] ioctl_tty.2: Add example how to get or set baudrate on the serial port To: =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <20210730095333.6118-1-pali@kernel.org> <20210810194928.16408-1-pali@kernel.org> <20210831203436.hy52aimer5hozb6r@pali> Message-ID: <56938369-cd99-d768-55da-5eac4cd268d4@gmail.com> Date: Fri, 10 Sep 2021 15:37:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210831203436.hy52aimer5hozb6r@pali> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Alejandro Colomar \(man-pages\) via Libc-alpha" Reply-To: "Alejandro Colomar \(man-pages\)" Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , "G. Branden Robinson" , libc-alpha@sourceware.org, Michael Kerrisk , linux-man@vger.kernel.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Hi, Pali! On 8/31/21 10:34 PM, Pali Rohár wrote: > On Tuesday 10 August 2021 21:49:28 Pali Rohár wrote: >> Setting custom baudrate for which is not defined Bnnn constant is possible >> via BOTHER flag and then filling speed in c_ospeed and c_ispeed fields. >> >> These two fields are either in struct termios or struct termios2. Former >> belongs to TCGETS/TCSETS ioctls, latter to TCGETS2/TCSETS2 ioctls. >> >> BOTHER flag with these two fields and new struct termios2 is not supported >> by older versions of include header files. >> >> Some architectures (e.g. amd64) provide both struct termios and struct >> termios2, but c_ospeed and c_ispeed are only in struct termios2. >> >> Some other architectures (e.g. alpha) provide both struct termios and struct >> termios2 and both have c_ospeed and c_ispeed fields. >> >> And some other architectures (e.g. powerpc) provide only struct termios >> (no struct termios2) and it has c_ospeed and c_ispeed fields. >> >> So basically to support all architectures it is needed to use >> struct termios2 when TCGETS2/TCSETS2 is supported. Otherwise it is needed >> to use struct termios with TCGETS/TCSETS (case for e.g. powerpc). >> >> Setting input baudrate is done via IBSHIFT macro. >> >> Signed-off-by: Pali Rohár > > Hello! Do you have any comments on this patch? Sorry, I started to fix the licensing issues Greg pointed out, and forgot about this. I assume it's good since you have been doing a lot of related work in recent patches. I'll only point out a cosmetic issue with the preprocessor stuff: I'd indent with a single space after '#' to clarify preprocessor #if #else #endif relationships and improve readability. I also prefer '#if [!]defined()' rather than '#if[n]def' (except for include guards); and there seems to be a mix in the existing pages, so I'll standardize that way from now on. For example: #if !defined a #else # if defined b # endif #endif However, I applied those changes myself in a following patch, so you don't worry about them. Patch applied! Thanks, Alex > >> --- >> Changes in v4: >> * Add SPDX-License-Identifier >> * Correctly process split baudrates (separate output and input) via IBSHIFT >> * Update commit message >> >> Changes in v3: >> * Check support for custom baudrate only based on BOTHER macro >> * Use TCGETS/TCSETS/termios when TCGETS2/TCSETS2/termios2 is not available >> >> Changes in v2: >> * Use \e for backslash >> * Use exit(EXIT_*) instead of return num >> * Sort includes >> * Add comment about possible fallback >> --- >> man2/ioctl_tty.2 | 100 +++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 100 insertions(+) >> >> diff --git a/man2/ioctl_tty.2 b/man2/ioctl_tty.2 >> index abfdc1e21fe9..7b2b03ff6757 100644 >> --- a/man2/ioctl_tty.2 >> +++ b/man2/ioctl_tty.2 >> @@ -796,6 +796,106 @@ main(void) >> close(fd); >> } >> .EE >> +.PP >> +Get or set arbitrary baudrate on the serial port. >> +.PP >> +.EX >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +int >> +main(int argc, char *argv[]) >> +{ >> +#ifndef BOTHER >> + fprintf(stderr, "BOTHER is unsupported\en"); >> + /* Program may fallback to TCGETS/TCSETS with Bnnn constants */ >> + exit(EXIT_FAILURE); >> +#else >> + /* Declare tio structure, its type depends on supported ioctl */ >> +#ifdef TCGETS2 >> + struct termios2 tio; >> +#else >> + struct termios tio; >> +#endif >> + int fd, rc; >> + >> + if (argc != 2 && argc != 3 && argc != 4) { >> + fprintf(stderr, "Usage: %s device [output [input] ]\en", argv[0]); >> + exit(EXIT_FAILURE); >> + } >> + >> + fd = open(argv[1], O_RDWR | O_NONBLOCK | O_NOCTTY); >> + if (fd < 0) { >> + perror("open"); >> + exit(EXIT_FAILURE); >> + } >> + >> + /* Get the current serial port settings via supported ioctl */ >> +#ifdef TCGETS2 >> + rc = ioctl(fd, TCGETS2, &tio); >> +#else >> + rc = ioctl(fd, TCGETS, &tio); >> +#endif >> + if (rc) { >> + perror("TCGETS"); >> + close(fd); >> + exit(EXIT_FAILURE); >> + } >> + >> + /* Change baud rate when more arguments were provided */ >> + if (argc == 3 || argc == 4) { >> + /* Clear the current output baud rate and fill a new value */ >> + tio.c_cflag &= ~CBAUD; >> + tio.c_cflag |= BOTHER; >> + tio.c_ospeed = atoi(argv[2]); >> + >> + /* Clear the current input baud rate and fill a new value */ >> + tio.c_cflag &= ~(CBAUD << IBSHIFT); >> + tio.c_cflag |= BOTHER << IBSHIFT; >> + /* When 4th argument is not provided reuse output baud rate */ >> + tio.c_ispeed = (argc == 4) ? atoi(argv[3]) : atoi(argv[2]); >> + >> + /* Set new serial port settings via supported ioctl */ >> +#ifdef TCSETS2 >> + rc = ioctl(fd, TCSETS2, &tio); >> +#else >> + rc = ioctl(fd, TCSETS, &tio); >> +#endif >> + if (rc) { >> + perror("TCSETS"); >> + close(fd); >> + exit(EXIT_FAILURE); >> + } >> + >> + /* And get new values which were really configured */ >> +#ifdef TCGETS2 >> + rc = ioctl(fd, TCGETS2, &tio); >> +#else >> + rc = ioctl(fd, TCGETS, &tio); >> +#endif >> + if (rc) { >> + perror("TCGETS"); >> + close(fd); >> + exit(EXIT_FAILURE); >> + } >> + } >> + >> + close(fd); >> + >> + printf("output baud rate: %u\en", tio.c_ospeed); >> + printf("input baud rate: %u\en", tio.c_ispeed); >> + >> + exit(EXIT_SUCCESS); >> +#endif >> +} >> +.EE >> .SH SEE ALSO >> .BR ldattach (1), >> .BR ioctl (2), >> -- >> 2.20.1 >> -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/