From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Carlos O'Donell" Newsgroups: gmane.comp.lib.glibc.alpha Subject: Re: New template for 'libc' made available Date: Mon, 03 Aug 2015 14:50:04 -0400 Message-ID: <55BFB7DC.3090403@redhat.com> References: <87bnepigsb.fsf@echidna.jochen.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1438627815 7175 80.91.229.3 (3 Aug 2015 18:50:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Aug 2015 18:50:15 +0000 (UTC) Cc: libc-alpha@sourceware.org To: Joseph Myers , Jochen Hein Original-X-From: libc-alpha-return-61589-glibc-alpha=m.gmane.org@sourceware.org Mon Aug 03 20:50:14 2015 Return-path: Envelope-to: glibc-alpha@plane.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=cs4wID657DLI2dr3 5qYMmgsT8vS6t6jMHg4qX8ADB/ibepUF21LoD1Z6OoLQgvkQccA9/5Z/MqEh43tv j7PZ6+0BLX7WSEXYcyUoSIATlQCPJC7NYQ1Eyuurn3P3Wn380kzUjGodQRleHSkF TjIsdQo3AWj9UnJyuk7DtO0mPVU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; s=default; bh=gSniFOZzshXzppwEpv50Uh 1rFjo=; b=Rb7WB8+P9SdkKb5IyENetj+nCg2kab9CWR06ypRS2fn0Jq0WhjaFaw t0+MRbp54NNM0/tj/iBo/Gfm0sSGfFuv4AKtGjm4Rowt1lzKxCFps+H6POlB6Tco FAG/I7usr+9QC6RgM9U4+r30HyNqObbIqNNTPnrQY0RbcBMxqpx84= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 In-Reply-To: Xref: news.gmane.org gmane.comp.lib.glibc.alpha:53868 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZMKoP-0003dk-OB for glibc-alpha@plane.gmane.org; Mon, 03 Aug 2015 20:50:14 +0200 Received: (qmail 54701 invoked by alias); 3 Aug 2015 18:50:09 -0000 Received: (qmail 54690 invoked by uid 89); 3 Aug 2015 18:50:08 -0000 On 08/03/2015 01:06 PM, Joseph Myers wrote: > On Sun, 2 Aug 2015, Jochen Hein wrote: > >> There are some new strings with `%s` instead of the usual `%s'. Is this >> intentional? > > That seems like a bug. In fact, any use of ` as a quote in messages is a > bug that should be filed in Bugzilla (one bug covering all such cases); > the GNU Coding Standards now specify neutral quotes in the C locale. This is my mistake. The quotes were intended to be `', as previously used by most GNU programs. However, now we have: https://www.gnu.org/prep/standards/html_node/Quote-Characters.html#Quote-Characters Which recommends "", and I agree with this new recommendation. All such quotes should therefore be handled by one cleanup bug. >> There are some messages that are constructed dynamically, which may or >> may not be possible to use in translations. And the dynamic strings are >> not marked for translation. For example: > > Those are also bugs that should be filed in Bugzilla. That is a bug. I believe there are 3 such instances and fixed by this patch. I do not plan to hold the release for this. We'll fix it in 2.23, and the translations will get updated in the next release. 2015-08-03 Carlos O'Donell * nscd/connections.c (inotify_check_files): Quote strings for translating. diff --git a/nscd/connections.c b/nscd/connections.c index cba5e6a..a6daeaa 100644 --- a/nscd/connections.c +++ b/nscd/connections.c @@ -1966,7 +1966,7 @@ inotify_check_files (bool *to_clear, union __inev *inev) } dbg_log (_("monitored file `%s` was %s, removing watch"), - finfo->fname, moved ? "moved" : "deleted"); + finfo->fname, moved ? _("moved") : _("deleted")); /* File was moved out, remove the watch. Watches are automatically removed when the file is deleted. */ if (moved) @@ -2013,7 +2013,7 @@ inotify_check_files (bool *to_clear, union __inev *inev) if (finfo->inotify_descr[TRACED_FILE] != -1) { dbg_log (_("monitored parent directory `%s` was %s, removing watch on `%s`"), - finfo->dname, moved ? "moved" : "deleted", finfo->fname); + finfo->dname, moved ? _("moved") : _("deleted"), finfo->fname); if (inotify_rm_watch (inotify_fd, finfo->inotify_descr[TRACED_FILE]) < 0) dbg_log (_("failed to remove file watch `%s`: %s"), finfo->dname, strerror (errno)); @@ -2040,7 +2040,7 @@ inotify_check_files (bool *to_clear, union __inev *inev) int ret; dbg_log (_("monitored file `%s` was %s, adding watch"), finfo->fname, - inev->i.mask & IN_CREATE ? "created" : "moved into place"); + inev->i.mask & IN_CREATE ? _("created") : _("moved into place")); /* File was moved in or created. Regenerate the watch. */ if (finfo->inotify_descr[TRACED_FILE] != -1) inotify_rm_watch (inotify_fd, --- Cheers, Carlos.