From: "Carlos O'Donell" <carlos@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>, Jochen Hein <jochen@jochen.org>
Cc: libc-alpha@sourceware.org
Subject: Re: New template for 'libc' made available
Date: Mon, 03 Aug 2015 14:50:04 -0400 [thread overview]
Message-ID: <55BFB7DC.3090403@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1508031704500.22507@digraph.polyomino.org.uk>
On 08/03/2015 01:06 PM, Joseph Myers wrote:
> On Sun, 2 Aug 2015, Jochen Hein wrote:
>
>> There are some new strings with `%s` instead of the usual `%s'. Is this
>> intentional?
>
> That seems like a bug. In fact, any use of ` as a quote in messages is a
> bug that should be filed in Bugzilla (one bug covering all such cases);
> the GNU Coding Standards now specify neutral quotes in the C locale.
This is my mistake. The quotes were intended to be `', as previously used
by most GNU programs. However, now we have:
https://www.gnu.org/prep/standards/html_node/Quote-Characters.html#Quote-Characters
Which recommends "", and I agree with this new recommendation. All such
quotes should therefore be handled by one cleanup bug.
>> There are some messages that are constructed dynamically, which may or
>> may not be possible to use in translations. And the dynamic strings are
>> not marked for translation. For example:
>
> Those are also bugs that should be filed in Bugzilla.
That is a bug.
I believe there are 3 such instances and fixed by this patch.
I do not plan to hold the release for this. We'll fix it in 2.23, and the
translations will get updated in the next release.
2015-08-03 Carlos O'Donell <carlos@redhat.com>
* nscd/connections.c (inotify_check_files): Quote strings for
translating.
diff --git a/nscd/connections.c b/nscd/connections.c
index cba5e6a..a6daeaa 100644
--- a/nscd/connections.c
+++ b/nscd/connections.c
@@ -1966,7 +1966,7 @@ inotify_check_files (bool *to_clear, union __inev *inev)
}
dbg_log (_("monitored file `%s` was %s, removing watch"),
- finfo->fname, moved ? "moved" : "deleted");
+ finfo->fname, moved ? _("moved") : _("deleted"));
/* File was moved out, remove the watch. Watches are
automatically removed when the file is deleted. */
if (moved)
@@ -2013,7 +2013,7 @@ inotify_check_files (bool *to_clear, union __inev *inev)
if (finfo->inotify_descr[TRACED_FILE] != -1)
{
dbg_log (_("monitored parent directory `%s` was %s, removing watch on `%s`"),
- finfo->dname, moved ? "moved" : "deleted", finfo->fname);
+ finfo->dname, moved ? _("moved") : _("deleted"), finfo->fname);
if (inotify_rm_watch (inotify_fd, finfo->inotify_descr[TRACED_FILE]) < 0)
dbg_log (_("failed to remove file watch `%s`: %s"),
finfo->dname, strerror (errno));
@@ -2040,7 +2040,7 @@ inotify_check_files (bool *to_clear, union __inev *inev)
int ret;
dbg_log (_("monitored file `%s` was %s, adding watch"),
finfo->fname,
- inev->i.mask & IN_CREATE ? "created" : "moved into place");
+ inev->i.mask & IN_CREATE ? _("created") : _("moved into place"));
/* File was moved in or created. Regenerate the watch. */
if (finfo->inotify_descr[TRACED_FILE] != -1)
inotify_rm_watch (inotify_fd,
---
Cheers,
Carlos.
next prev parent reply other threads:[~2015-08-03 18:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 7:18 New template for 'libc' made available Translation Project Robot
2015-08-02 20:20 ` Jochen Hein
2015-08-03 17:06 ` Joseph Myers
2015-08-03 18:50 ` Carlos O'Donell [this message]
2015-08-03 19:08 ` Paul Eggert
2015-08-03 20:34 ` Joseph Myers
2015-08-04 14:30 ` Carlos O'Donell
-- strict thread matches above, loose matches on Subject: below --
2024-01-03 10:38 Translation Project Robot
2023-07-18 14:07 Translation Project Robot
2023-01-25 10:19 Translation Project Robot
2022-07-31 9:09 Translation Project Robot
2022-01-30 15:39 Translation Project Robot
2021-07-29 8:00 Translation Project Robot
2020-07-23 7:17 Translation Project Robot
2020-01-10 9:00 Translation Project Robot
2019-07-24 18:14 Translation Project Robot
2019-01-16 16:40 Translation Project Robot
2018-07-27 18:54 Translation Project Robot
2018-01-10 19:12 Translation Project Robot
2017-07-25 19:05 Translation Project Robot
2017-01-11 13:46 Translation Project Robot
2017-01-11 13:41 Translation Project Robot
2015-01-22 19:22 Translation Project Robot
2014-08-21 7:39 Translation Project Robot
2014-01-08 12:37 Translation Project Robot
2013-07-26 8:04 Translation Project Robot
2012-12-11 7:10 Translation Project Robot
2012-06-30 16:24 Translation Project Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BFB7DC.3090403@redhat.com \
--to=carlos@redhat.com \
--cc=jochen@jochen.org \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).