unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
To: Florian Weimer <fweimer@redhat.com>,
	Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v4 0/3] C.UTF-8
Date: Thu, 29 Jul 2021 23:12:50 -0400	[thread overview]
Message-ID: <54c709a4-21ef-6bc8-1258-604d7b36c0f7@redhat.com> (raw)
In-Reply-To: <87bl6l5zeb.fsf@oldenburg.str.redhat.com>

On 7/29/21 3:53 AM, Florian Weimer wrote:
> * Carlos O'Donell via Libc-alpha:
> 
>> The following changes implement a minimally sized C.UTF-8.
>> First we implement the 'strcmp_collation' directive.
>> Then we implement C.UTF-8 with an LC_COLLATE that uses the
>> 'strcmp_collation' directive to support using strcmp for
>> collation i.e. code point sorting. The final C.UTF-8 is
>> only ~396KiB with the largest ~346KiB in LC_CTYPE for all
>> of Unicode.
>>
>> This v4 fixes the regressions detected in Fedora Rawhide
>> here: https://bugzilla.redhat.com/show_bug.cgi?id=1986421
>> Additional testing coverage is provided for fnmatch, regcomp,
>> and regexec (which would have caught the regression).
> 
> From a high-level point of view I wonder if the more conservative choice
> would be to fix the localdef generation for LC_COLLATE, at least for
> this release.  It would also mean that we do not break statically linked
> executables.

That is a great idea. In fact it's actually fairly easy to split and
reuse the tables from C-collate.c in ld-collate.c and emit them when
you have a nrules == 0 scenario and thus provide support in fnmatch,
regexec, and regcomp for ASCII ranges.

I've finished a new v5 along these lines and I'm testing it right now.

-- 
Cheers,
Carlos.


  reply	other threads:[~2021-07-30  3:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  6:35 [PATCH v4 0/3] C.UTF-8 Carlos O'Donell via Libc-alpha
2021-07-29  6:35 ` [PATCH v4 1/3] Add support for locales with zero collation rules Carlos O'Donell via Libc-alpha
2021-07-29  9:44   ` Florian Weimer via Libc-alpha
2021-07-29 19:12     ` Paul Eggert
2021-07-29  6:35 ` [PATCH v4 2/3] Add 'strcmp_collation' support for LC_COLLATE Carlos O'Donell via Libc-alpha
2021-07-29  6:35 ` [PATCH v4 3/3] Add generic C.UTF-8 locale (Bug 17318) Carlos O'Donell via Libc-alpha
2021-07-29  7:53 ` [PATCH v4 0/3] C.UTF-8 Florian Weimer via Libc-alpha
2021-07-30  3:12   ` Carlos O'Donell via Libc-alpha [this message]
2021-08-18  8:12   ` Mike Frysinger via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54c709a4-21ef-6bc8-1258-604d7b36c0f7@redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=carlos@redhat.com \
    --cc=fweimer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).