* [PATCH] i386: Remove NO_TLS_DIRECT_SEG_REFS handling
@ 2020-05-28 9:12 Florian Weimer via Libc-alpha
2020-05-28 9:46 ` Andreas Schwab
2020-05-28 11:41 ` Andrew Cooper via Libc-alpha
0 siblings, 2 replies; 3+ messages in thread
From: Florian Weimer via Libc-alpha @ 2020-05-28 9:12 UTC (permalink / raw)
To: libc-alpha; +Cc: Andrew Cooper
This was needed for 32-bit PV Xen, which has been superseded by this
point according to Xen developers.
---
sysdeps/i386/Makefile | 4 ----
sysdeps/i386/i686/multiarch/strcmp-sse4.S | 20 --------------------
sysdeps/i386/i686/multiarch/strcmp-ssse3.S | 20 --------------------
3 files changed, 44 deletions(-)
diff --git a/sysdeps/i386/Makefile b/sysdeps/i386/Makefile
index c0a4fe15d4..b9b1367f60 100644
--- a/sysdeps/i386/Makefile
+++ b/sysdeps/i386/Makefile
@@ -33,10 +33,6 @@ else
stack-align-test-flags += -malign-double
endif
-ifneq (,$(filter -mno-tls-direct-seg-refs,$(CFLAGS)))
-defines += -DNO_TLS_DIRECT_SEG_REFS
-endif
-
ifeq ($(subdir),elf)
sysdep-dl-routines += tlsdesc dl-tlsdesc
diff --git a/sysdeps/i386/i686/multiarch/strcmp-sse4.S b/sysdeps/i386/i686/multiarch/strcmp-sse4.S
index 5454cba2e3..802609839a 100644
--- a/sysdeps/i386/i686/multiarch/strcmp-sse4.S
+++ b/sysdeps/i386/i686/multiarch/strcmp-sse4.S
@@ -101,19 +101,9 @@ ENTRY (__strcasecmp_sse4_2)
PUSH (%ebx)
LOAD_PIC_REG(bx)
movl __libc_tsd_LOCALE@GOTNTPOFF(%ebx), %eax
-# ifdef NO_TLS_DIRECT_SEG_REFS
- addl %gs:0, %eax
- movl (%eax), %eax
-# else
movl %gs:(%eax), %eax
-# endif
# else
-# ifdef NO_TLS_DIRECT_SEG_REFS
- movl %gs:0, %eax
- movl __libc_tsd_LOCALE@NTPOFF(%eax), %eax
-# else
movl %gs:__libc_tsd_LOCALE@NTPOFF, %eax
-# endif
# endif
# if LOCALE_T___LOCALES != 0 || LC_CTYPE != 0
movl LOCALE_T___LOCALES+LC_CTYPE*4(%eax), %eax
@@ -138,19 +128,9 @@ ENTRY (__strncasecmp_sse4_2)
PUSH (%ebx)
LOAD_PIC_REG(bx)
movl __libc_tsd_LOCALE@GOTNTPOFF(%ebx), %eax
-# ifdef NO_TLS_DIRECT_SEG_REFS
- addl %gs:0, %eax
- movl (%eax), %eax
-# else
movl %gs:(%eax), %eax
-# endif
# else
-# ifdef NO_TLS_DIRECT_SEG_REFS
- movl %gs:0, %eax
- movl __libc_tsd_LOCALE@NTPOFF(%eax), %eax
-# else
movl %gs:__libc_tsd_LOCALE@NTPOFF, %eax
-# endif
# endif
# if LOCALE_T___LOCALES != 0 || LC_CTYPE != 0
movl LOCALE_T___LOCALES+LC_CTYPE*4(%eax), %eax
diff --git a/sysdeps/i386/i686/multiarch/strcmp-ssse3.S b/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
index 8e830dec6f..1b9d53c1fe 100644
--- a/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
+++ b/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
@@ -118,19 +118,9 @@ ENTRY (__strcasecmp_ssse3)
PUSH (%ebx)
LOAD_PIC_REG(bx)
movl __libc_tsd_LOCALE@GOTNTPOFF(%ebx), %eax
-# ifdef NO_TLS_DIRECT_SEG_REFS
- addl %gs:0, %eax
- movl (%eax), %eax
-# else
movl %gs:(%eax), %eax
-# endif
# else
-# ifdef NO_TLS_DIRECT_SEG_REFS
- movl %gs:0, %eax
- movl __libc_tsd_LOCALE@NTPOFF(%eax), %eax
-# else
movl %gs:__libc_tsd_LOCALE@NTPOFF, %eax
-# endif
# endif
# if LOCALE_T___LOCALES != 0 || LC_CTYPE != 0
movl LOCALE_T___LOCALES+LC_CTYPE*4(%eax), %eax
@@ -155,19 +145,9 @@ ENTRY (__strncasecmp_ssse3)
PUSH (%ebx)
LOAD_PIC_REG(bx)
movl __libc_tsd_LOCALE@GOTNTPOFF(%ebx), %eax
-# ifdef NO_TLS_DIRECT_SEG_REFS
- addl %gs:0, %eax
- movl (%eax), %eax
-# else
movl %gs:(%eax), %eax
-# endif
# else
-# ifdef NO_TLS_DIRECT_SEG_REFS
- movl %gs:0, %eax
- movl __libc_tsd_LOCALE@NTPOFF(%eax), %eax
-# else
movl %gs:__libc_tsd_LOCALE@NTPOFF, %eax
-# endif
# endif
# if LOCALE_T___LOCALES != 0 || LC_CTYPE != 0
movl LOCALE_T___LOCALES+LC_CTYPE*4(%eax), %eax
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i386: Remove NO_TLS_DIRECT_SEG_REFS handling
2020-05-28 9:12 [PATCH] i386: Remove NO_TLS_DIRECT_SEG_REFS handling Florian Weimer via Libc-alpha
@ 2020-05-28 9:46 ` Andreas Schwab
2020-05-28 11:41 ` Andrew Cooper via Libc-alpha
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Schwab @ 2020-05-28 9:46 UTC (permalink / raw)
To: Florian Weimer via Libc-alpha; +Cc: Florian Weimer, Andrew Cooper
On Mai 28 2020, Florian Weimer via Libc-alpha wrote:
> This was needed for 32-bit PV Xen, which has been superseded by this
> point according to Xen developers.
Ok.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i386: Remove NO_TLS_DIRECT_SEG_REFS handling
2020-05-28 9:12 [PATCH] i386: Remove NO_TLS_DIRECT_SEG_REFS handling Florian Weimer via Libc-alpha
2020-05-28 9:46 ` Andreas Schwab
@ 2020-05-28 11:41 ` Andrew Cooper via Libc-alpha
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper via Libc-alpha @ 2020-05-28 11:41 UTC (permalink / raw)
To: Florian Weimer, libc-alpha
On 28/05/2020 10:12, Florian Weimer wrote:
> This was needed for 32-bit PV Xen,
PV guests, on 32bit bit Xen.
The latter point is the more important one, because we switched to
64-bit-only Xen itself, in the 4.3 release (July 2013). Xen 4.3 is long
out of security support.
~Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-28 11:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 9:12 [PATCH] i386: Remove NO_TLS_DIRECT_SEG_REFS handling Florian Weimer via Libc-alpha
2020-05-28 9:46 ` Andreas Schwab
2020-05-28 11:41 ` Andrew Cooper via Libc-alpha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).