From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C55601F619 for ; Fri, 28 Feb 2020 14:56:04 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=sls42i2sYW77HMgY Bp1u3HF6OjJfdhV9nWWmwEvKVQfhFsMGdFUqENa0xn8atIWtpZd7aKOd7H/AIkv4 6PjCJ5ByAfhRG4HuK8KpdqCB7oRU7yD93dIbvo1913Se3I0ZG9wH2+/aWP9SIWdh blNYc+G1tVWdLLQbCcSOUoSi9Hs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=insgtAbblWojzsNppUH7sA 1wHnU=; b=UGKaS1mSU+0iX3zmiLwEx9Ttq0ivCaM0oaPXAN1iTUWvYvWzcnF4UN RBYPN1kpdnFlxGsXJViqTR7UhWPyZLTJC/FZbEih+x/90qtcRas/QgbBqHkL+TTH RoAAUvaXDumdmI5bFOJFi8wi3YxPPHsJKD5TGnQixX7Cdk73lzmFg= Received: (qmail 117460 invoked by alias); 28 Feb 2020 14:56:02 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 117451 invoked by uid 89); 28 Feb 2020 14:56:02 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH 3/6] ldbl-128ibm-compat: Redirect long double functions to f128/ieee128 functions From: Paul E Murphy To: libc-alpha@sourceware.org References: <3f4d36225559ca4c84dcac78b31f8fd9bf81c74a.1580757509.git.murphyp@linux.vnet.ibm.com> Message-ID: <5499e11c-d5f8-20b3-fca1-c295ff09c264@linux.ibm.com> Date: Fri, 28 Feb 2020 08:55:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 2/24/20 8:58 AM, Paul E Murphy wrote: > > > On 2/3/20 3:10 PM, Paul E. Murphy wrote: >> From: Tulio Magno Quites Machado Filho >> >> Modify the headers to redirect long double functions to global __*f128 >> symbols or to __*ieee128 otherwise. >> >> Most of the functions in math.h benefit from the infrastructure already >> available for __LDBL_COMPAT.  The only exceptions are nexttowardf and >> nexttoward that need especial treatment. >> >> Both math/bits/mathcalls-helper-functions.h and math/bits/mathcalls.h >> were modified in order to provide alternative redirection destinations >> that are essential to support functions that should not be redirected to >> the same name pattern of the rest of the functions, i.e.: __fpclassify, >> __signbit, __iseqsig, __issignaling, isinf, finite and isnan, which will >> be redirected to __*f128 instead of __*ieee128 used for the rest. >> --- >>   include/math.h                                |  9 ++- >>   math/bits/mathcalls-helper-functions.h        | 18 +++--- >>   math/bits/mathcalls.h                         |  9 ++- >>   math/math.h                                   | 59 ++++++++++++++++++- >>   .../ieee754/ldbl-128ibm/bits/iscanonical.h    |  8 ++- >>   5 files changed, 85 insertions(+), 18 deletions(-) > > I think the majority of this patch is OK.  My only contribution was to > fixup against the deprecation of the finite entry points. > > The naming of the nexttoward ABI is a bit awkward, but I proffer no > better solutions. > > If there are no requests for improvement, or objections, I will commit > this and the following patch 4, the equivalent support for complex.h, on > Friday. > And committed.