From: Yann Droneaud <ydroneaud@opteya.com>
To: Mike Crowe <mac@mcrowe.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 6/7] nptl/tst-rwlock: Use clock_gettime/timespec rather than gettimeofday/timeval
Date: Thu, 14 Mar 2019 15:44:07 +0100 [thread overview]
Message-ID: <52de2bacf060449cc856d7c9253b4d7abbe12abc.camel@opteya.com> (raw)
In-Reply-To: <e7a012d809a6f0cf8b33b923345ebe05b5d739e1.1551291557.git-series.mac@mcrowe.com>
Hi,
Le mercredi 27 février 2019 à 18:23 +0000, Mike Crowe a écrit :
> diff --git a/nptl/tst-rwlock9.c b/nptl/tst-rwlock9.c
> index 34f2d04..ff15f90 100644
> --- a/nptl/tst-rwlock9.c
> +++ b/nptl/tst-rwlock9.c
> @@ -56,9 +56,7 @@ writer_thread (void *nr)
> int e;
> do
> {
> - struct timeval tv;
> - (void) gettimeofday (&tv, NULL);
> - TIMEVAL_TO_TIMESPEC (&tv, &ts);
> + (void) clock_gettime (CLOCK_REALTIME, &ts);
>
> ts.tv_nsec += 2 * TIMEOUT;
> if (ts.tv_nsec >= 1000000000)
Should timespec_add() be used here too ?
> @@ -110,9 +108,7 @@ reader_thread (void *nr)
> int e;
> do
> {
> - struct timeval tv;
> - (void) gettimeofday (&tv, NULL);
> - TIMEVAL_TO_TIMESPEC (&tv, &ts);
> + (void) clock_gettime (CLOCK_REALTIME, &ts);
>
> ts.tv_nsec += TIMEOUT;
> if (ts.tv_nsec >= 1000000000)
Same here
Regards.
--
Yann Droneaud
OPTEYA
next prev parent reply other threads:[~2019-03-14 14:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 18:23 [PATCH 0/7] Implement proposed POSIX _clockwait variants of existing _timedwait functions Mike Crowe
2019-02-27 18:23 ` [PATCH 1/7] nptl: Add clockid parameter to futex timed wait calls Mike Crowe
2019-03-05 12:39 ` Adhemerval Zanella
2019-03-10 8:59 ` Mike Crowe
2019-03-11 11:50 ` Adhemerval Zanella
2019-02-27 18:23 ` [PATCH 2/7] nptl: Add POSIX-proposed sem_clockwait Mike Crowe
2019-02-27 18:35 ` Joseph Myers
2019-03-05 13:31 ` Adhemerval Zanella
2019-03-10 16:17 ` Mike Crowe
2019-03-19 17:07 ` Adhemerval Zanella
2019-03-14 14:09 ` Yann Droneaud
2019-03-14 14:39 ` Mike Crowe
2019-02-27 18:23 ` [PATCH 3/7] nptl: Add POSIX-proposed pthread_cond_clockwait Mike Crowe
2019-03-05 16:45 ` Adhemerval Zanella
2019-05-04 20:22 ` Mike Crowe
2019-02-27 18:23 ` [PATCH 4/7] nptl: pthread_rwlock: Move timeout validation into _full functions Mike Crowe
2019-03-05 16:48 ` Adhemerval Zanella
2019-02-27 18:23 ` [PATCH 5/7] nptl/tst-rwlock14: Test pthread/rwlock_timedwrlock correctly Mike Crowe
2019-03-05 17:36 ` Adhemerval Zanella
2019-02-27 18:23 ` [PATCH 6/7] nptl/tst-rwlock: Use clock_gettime/timespec rather than gettimeofday/timeval Mike Crowe
2019-03-05 18:02 ` Adhemerval Zanella
2019-03-20 21:34 ` Mike Crowe
2019-03-14 14:44 ` Yann Droneaud [this message]
2019-02-27 18:23 ` [PATCH 7/7] nptl: Add POSIX-proposed pthread_rwlock_clockrdlock & pthread_rwlock_clockwrlock Mike Crowe
2019-03-07 12:59 ` Adhemerval Zanella
2019-03-05 12:35 ` [PATCH 0/7] Implement proposed POSIX _clockwait variants of existing _timedwait functions Adhemerval Zanella
2019-03-06 21:15 ` Joseph Myers
2019-03-10 9:12 ` Mike Crowe
2019-03-11 23:13 ` Joseph Myers
2019-03-13 21:42 ` Mike Crowe
2019-03-14 11:30 ` Adhemerval Zanella
2019-03-15 13:25 ` Yann Droneaud
2019-03-15 13:36 ` Mike Crowe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52de2bacf060449cc856d7c9253b4d7abbe12abc.camel@opteya.com \
--to=ydroneaud@opteya.com \
--cc=libc-alpha@sourceware.org \
--cc=mac@mcrowe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).