From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9C15C1F463 for ; Tue, 7 Jan 2020 22:05:39 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=lF2zZm9BtMoGjo8N E81bfPb8Y2q71+oYjQuOZKclXUPy6Gg1zzgk+p89t2X3yVD9N46U+RqJSsq7q/ss GVdnA1rHzRLwVYyW7hh6cORzzM1Y1rYNjeEfPEQOZFAzlF9zhi+H8HWiw5PCGbBG LXH2KTA5M/Ou6+C1d/5xCyHchoE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=w7GhRt3u6fCB0QiN/lUy7L FQvdY=; b=X0j37SHEBsUaPVNUAImV1jJBSqkvjWeKVwcyG0zYqHol7zPCshdnC4 Nbxj9STxYpSmE7mvDoPBD00SRtiutCjzCKQOss9EKhz1wAV32lkEoagqaxvftF6O Kh4HtZ6teK1Aaxx9zQ5U83cD13eN1GKKyI/gwQbzNZjaY4BeTWIxE= Received: (qmail 105689 invoked by alias); 7 Jan 2020 22:05:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 105680 invoked by uid 89); 7 Jan 2020 22:05:36 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qv1-f67.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZBrnQd+4CnGnbpNz+ulbNebp2QtCPKwPR1iHENIjkS4=; b=Fo02qYPPar4LdbDc0s9+xETBiuNhOPpGrLpfn+zwaepeyUT2kho28vaFQmDstSEBjh 1+PXmR6IbNofyy9odfLRS0EKmAHU17M2TlwjXzsUSYy149CxuDBHEnAd5pXznecWgGRR xGS1Z5f0w3aGnbUV4+bqy3URVEsdpe/90VKd/OFnmeohz8+BiOvO+NNVgLq+tnnc/4Ee tNUdKX3biiyseF65HTZGFeV/L9kqksjnkejjxKdAT0Euy4Vr2LgYL0/p557zp3Wh7cIL jcY2r9G2FdTjrQcbtT772pnY9iRgzIiHC7p0CXHsP4ccTmbK6UISXCyEDslVzvDtlbh7 iYmw== Subject: Re: [PATCH 3/4] i386: Add _CET_ENDBR to assembly files without ENTRY To: libc-alpha@sourceware.org References: <20191210204710.4832-1-hjl.tools@gmail.com> <20191210204710.4832-4-hjl.tools@gmail.com> From: Adhemerval Zanella Message-ID: <52b189ea-26a7-172b-f749-0b44fa44c21f@linaro.org> Date: Tue, 7 Jan 2020 19:05:29 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191210204710.4832-4-hjl.tools@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 10/12/2019 17:47, H.J. Lu wrote: > diff --git a/sysdeps/unix/sysv/linux/i386/_exit.S b/sysdeps/unix/sysv/linux/i386/_exit.S > index d59c127501..a21d5f69b3 100644 > --- a/sysdeps/unix/sysv/linux/i386/_exit.S > +++ b/sysdeps/unix/sysv/linux/i386/_exit.S > @@ -21,6 +21,7 @@ > .type _exit,@function > .global _exit > _exit: > + _CET_ENDBR > movl 4(%esp), %ebx > > /* Try the new syscall first. */ > Do we still need this for i386? I think the generic implementation should suffice since __NR_exit_group is always support and i386 does define ABORT_INSTRUCTION.