From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.4 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id DE2821F85E for ; Thu, 12 Jul 2018 17:38:17 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=NVMdtblMf/1rV18+ k8LxJnUJUy6ppNKhsMflZHFEsQIsXtBy0NXjSorNLXx+RvuZVnpyAa1kWcD2SAn1 0FdfSV3g8oSFmskyiEyUQxy4ub8Upl24ZhFqjYVWTjsNRrUuuIE0mLUiBc7f13Kq JmQ8Iw0Fr2ILTTIpWXPSE8I7ohM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=JMmvXJdXlufW4Tbca6SnQ4 kJejI=; b=rgzvFaLFn2sYBeq05ERmBsECpc0R0xysdZSLLlDK0908z/6nbVxEkL vFX9Kku7jonxQKunhmZ2nX45mjN/RhLOEfvBdc4Ew1Z4Q4EMbmV3MeSh3W8ANizj J/Rq4nP41yURTVoD5HSIZiba1WtBYCWsbASffKE48aqjObVRmkgRk= Received: (qmail 40947 invoked by alias); 12 Jul 2018 17:38:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 40547 invoked by uid 89); 12 Jul 2018 17:38:15 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-vk0-f68.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6VpXzuMCgoqIg4Zm4Ttbs6TE7Z6HokLl5ido6f7DJpo=; b=cMUJ8h3jnYuhWEhLJBTBeKloh0WrElWTZ8bmR01KOIX6VWzWzpk7Rrsvy+w6rsEJrV fHvHL7RYr1f83iFOmOepMqPlOFM1HMwKr2QCRK+d54h2Y9cnpu+v3WaUxksY5wAH8lq8 kNZJugqfhSEKnczAH/CemylXrNh2MN2kgtq4U= Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions To: Florian Weimer , Szabolcs Nagy , libc-alpha@sourceware.org Cc: nd@arm.com References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> <23dd1909-5ec2-34b7-9672-827251a4be65@redhat.com> <176c958e-45d6-c1fc-49e4-4eca813d460f@linaro.org> <0566f5a5-f56c-7dd9-5ba6-91c67d9633e9@arm.com> <1fdcdd41-5160-f6db-e585-9775e5b581c3@linaro.org> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: <52af7901-3974-5f7a-5dfd-fed2d5785fe9@linaro.org> Date: Thu, 12 Jul 2018 14:38:07 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 12/07/2018 09:18, Florian Weimer wrote: > On 07/11/2018 06:24 PM, Adhemerval Zanella wrote: >> >> >> On 11/07/2018 12:49, Szabolcs Nagy wrote: >>> On 10/07/18 20:26, Adhemerval Zanella wrote: >>>> >>>> >>>> On 06/07/2018 09:46, Florian Weimer wrote: >>>>> On 02/02/2018 06:04 PM, Adhemerval Zanella wrote: >>>>>> @@ -139,7 +139,9 @@ libpthread-routines = nptl-init vars events version pt-interp \ >>>>>>                   pthread_mutex_getprioceiling \ >>>>>>                   pthread_mutex_setprioceiling \ >>>>>>                   pthread_setname pthread_getname \ >>>>>> -              pthread_setattr_default_np pthread_getattr_default_np >>>>>> +              pthread_setattr_default_np pthread_getattr_default_np \ >>>>>> +              thrd_create thrd_current thrd_detach thrd_equal \ >>>>> >>>>> thrd_current should live in libc, not in libpthread.  Same for thrd_equal, I suppose.  You should just duplicate the comparison, seeing that we haven't done that particular cleanup for pthread_equal yet. >>>>> >>>>> Not sure about thrd_sleep and thrd_yield, but I lean towards libc there as well. >>>> >>>> Right, I added all four symbols (thrd_current, thrd_equal, thrd_sleep, and >>>> thrd_yield) to libc on my personal branch [1] (the change is just to move >>>> the objects from libpthread-routines to routines rule in nptl/Makefile). >>>> I also adjusted the abilist patch with the change. >>>> >>> >>> the abilist patch seems to add >>> sysdeps/unix/sysv/linux/tile/tilegx64/libpthread.abilist >>> i think you can drop that (and update the ChangeLog). >> >> Thanks for catching this up, I fixed on my personal c11 thread branch. > > I still see the attached ABI diffs. Thanks, I have corrected them in my personal branch, along with the ChangeLog entry and a lingering file from tile. > > There is also a new linknamespace failure on hppa: > > [initial] thrd_create -> [libpthread.a(thrd_create.o)] __pthread_create_2_1 -> [libpthread.a(pthread_create.o)] mprotect > > That should be easy to fix.  I'll post a separate patch for that. You seemed to already fix, thanks.