From: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
libc-alpha@sourceware.org
Subject: Re: [hurd,commited] htl: Add clock variants
Date: Fri, 29 May 2020 10:29:43 -0300 [thread overview]
Message-ID: <5202b709-d2ba-c1b5-787a-6a7de2959132@linaro.org> (raw)
In-Reply-To: <20200526005040.1851573-1-samuel.thibault@ens-lyon.org>
On 25/05/2020 21:50, Samuel Thibault wrote:
> * htl/pt-join.c (__pthread_join): Move implementation to...
> (__pthread_join_common): ... new function. Add try, timed and clock support.
> (__pthread_join): Reimplement on top of __pthread_join_common.
> (__pthread_tryjoin_np, __pthread_timedjoin_np, __pthread_clockjoin_np):
> Implement on top of __pthread_join_common.
> (pthread_tryjoin_np, pthread_timedjoin_np, pthread_clockjoin_np): New
> aliases.
There is no needed to keep formatting the change with a CL in the
commit message, although there is no rule against it. I personally
think a more descriptive commit message is more elucidative than
a bland CL.
In this change, maybe something like 'Add hurd pthread variants
to work with different clocks (as done for Linux on 2.30) and the
required Hurd internal changes to avoid code duplication. The
patch also moves the NPTL tests to generic folder).
prev parent reply other threads:[~2020-05-29 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 0:50 [hurd,commited] htl: Add clock variants Samuel Thibault
2020-05-29 13:29 ` Adhemerval Zanella via Libc-alpha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5202b709-d2ba-c1b5-787a-6a7de2959132@linaro.org \
--to=libc-alpha@sourceware.org \
--cc=adhemerval.zanella@linaro.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).