From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4321F1F45E for ; Tue, 18 Feb 2020 15:15:47 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=Simgmj8hALpenewD hgSkZbKSptR3gF2uYZJNq1bg0bqajr38kzfIkqYRrhWkJ0FK9dHBlxwvyAEZPLGw /EVPAt7aIti32cRSxvDpvxFbD5V5HtPaIca5xmfbXZrUxvFX9LLi686RMWetnev+ 7Nte8aZk4IWigLPMcYVjdY3r9BE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=T3nOweObIwkA9zDvCrNyL9 1egwk=; b=jxMJYL419lX5Us/1Ya69WkYXoiJwfdE6/a2rwysKKJC8ETgeqANNlS yKm7IhsO/YfuF/a+ZaitDKPv98GAodKniT9t1hCX7GrI8kXXNDpvUUp/uYwM9N2b oIybBGhsy2WVN3J9x077UsFjXcvI2aj4CsEVLhXe1lLRtucQvUsMw= Received: (qmail 129993 invoked by alias); 18 Feb 2020 15:15:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 129971 invoked by uid 89); 18 Feb 2020 15:15:44 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH 2/6] Undefine redirections after long double definition on __LDBL_COMPAT [BZ #23294] From: Paul E Murphy To: libc-alpha@sourceware.org, Tulio Magno Quites Machado Filho References: <806bbf1d-13a6-7588-52fc-0430a46dd871@linux.ibm.com> Message-ID: <516a7ce5-e6bf-5716-326d-7ec6b7646e97@linux.ibm.com> Date: Tue, 18 Feb 2020 09:15:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <806bbf1d-13a6-7588-52fc-0430a46dd871@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit My only contribution to this patch is to fix the merge conflict in the Makefile while rebasing. Note, this does address the feedback from Joseph [1] about adding a test which will fail without this change. I Have verified the test does fail without the change. If there are no further requests or objections for this patch, I would like to commit it friday. It is necessary to for functional redirection support in ldbl-128ibm-compat. [1] https://sourceware.org/ml/libc-alpha/2018-06/msg00600.html Reviewed-by: Paul E. Murphy On 2/17/20 9:08 AM, Paul E Murphy wrote: > Ping. > > On 2/3/20 3:10 PM, Paul E. Murphy wrote: >> From: Tulio Magno Quites Machado Filho >> >> After defining the long double redirections to double, __MATHDECL_1 has >> to be redefined to its previous state in order to avoid redirecting all >> subsequent types. >> --- >>   math/complex.h                                | 10 ++- >>   math/math.h                                   | 18 ++-- >>   sysdeps/ieee754/ldbl-opt/Makefile             |  4 +- >>   .../ldbl-opt/test-redirection-ldbl-64.c       | 87 +++++++++++++++++++ >>   4 files changed, 112 insertions(+), 7 deletions(-) >>   create mode 100644 sysdeps/ieee754/ldbl-opt/test-redirection-ldbl-64.c